Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for MLP Mixer #63

Merged
merged 14 commits into from
Aug 14, 2023
Merged

Tests for MLP Mixer #63

merged 14 commits into from
Aug 14, 2023

Conversation

shireenchand
Copy link
Contributor

Adding tests for MLP Mixer

shireenchand and others added 3 commits July 31, 2023 22:16
All modification requested

All modification requested

Modified type of weights

Added init.py

Added MLPMixer Model
@shireenchand
Copy link
Contributor Author

Hi @juliagsy, can you please review this PR. I have added the test for the MLP Mixer Model!

@juliagsy
Copy link
Contributor

juliagsy commented Aug 7, 2023

Hey! Just to let you know I'm reviewing the PR already but am looking into a failure, if it's related to ivy or the pr itself, will get back to you soon! thanks!

# Value test
if load_weights:
np_out = ivy.to_numpy(logits)
true_indices = np.array([1, 6, 9, 7, 4])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I've briefly helped out with some permutations updates. Could you please double check the indices and logits because the values are floating pretty much atm, thanks!

@shireenchand
Copy link
Contributor Author

Hi @juliagsy, I have made the changes. Could you please review it 😄
Thanks!

Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the changes! I'm not sure if it's happening on your side, but I'm on latest docker and latest models, there seem to be an unidentical structure in weights (missing dropout attr), would you mind to upload the updated weights to hf again and test it out? (which means the tests are failing, models couldn't be loaded as well) thanks a lot!

@shireenchand
Copy link
Contributor Author

Hi @juliagsy, I have updated the weights. Can you please review it
Thanks!

@juliagsy
Copy link
Contributor

Thanks for the great work!

@juliagsy juliagsy merged commit 19d6623 into ivy-llc:main Aug 14, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants