Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer font color is hard to read when using Dark Mode #672

Closed
TheFrenchGhosty opened this issue Aug 6, 2019 · 9 comments · Fixed by #4100
Closed

Footer font color is hard to read when using Dark Mode #672

TheFrenchGhosty opened this issue Aug 6, 2019 · 9 comments · Fixed by #4100
Labels
good first issue Good for newcomers

Comments

@TheFrenchGhosty
Copy link
Member

In my opinion the color of the font used in the footer is a bit too dark when using dark mode, I don't personally have a problem to read it but I guess it might be better to have a lighter color for people with vision problems.

White would be too "visible" so I guess using a color a bit darker than the one used for the "normal" text (#a0a0a0) would be the way to go.

footer

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Jan 2, 2021
@TheFrenchGhosty
Copy link
Member Author

Still an issue.

@saltycrys
Copy link
Member

The color can be adjusted in default.css:

.footer {
color: #666666;
margin: 2em 0;
text-align: center;
}

@saltycrys saltycrys added good first issue Good for newcomers and removed stale labels Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Jan 5, 2022
@TheFrenchGhosty
Copy link
Member Author

bump

@le-jun
Copy link

le-jun commented Apr 17, 2022

Let’s use this opportunity to tackle the interface accessibility question at the same time. According to W3C, the contrast between text and background should be at least 4.5:1 (AA level) and 7:1 (AAA level). Only modifying the text colour (no text size nor background change), then we could use:

  • #adadad (7:1)
  • #8a8a8a (4.55:1)

Ratio measured using this tool

@ahangarha
Copy link
Contributor

This issue is already resolved. I see good contrast in dark mode.

@TheFrenchGhosty
Copy link
Member Author

@ahangarha No it isn't resolved.

@ahangarha
Copy link
Contributor

Based on my test on yewtu.be and invidious.snopyta.org, the contrast between text and background color in the footer and dark mode is 4.99 AA. It is a good contrast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
4 participants