-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer font color is hard to read when using Dark Mode #672
Comments
This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Still an issue. |
The color can be adjusted in invidious/assets/css/default.css Lines 283 to 287 in e036d89
|
This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked. |
bump |
Let’s use this opportunity to tackle the interface accessibility question at the same time. According to W3C, the contrast between text and background should be at least 4.5:1 (AA level) and 7:1 (AAA level). Only modifying the text colour (no text size nor background change), then we could use:
Ratio measured using this tool |
This issue is already resolved. I see good contrast in dark mode. |
@ahangarha No it isn't resolved. |
Based on my test on yewtu.be and invidious.snopyta.org, the contrast between text and background color in the footer and dark mode is 4.99 AA. It is a good contrast. |
In my opinion the color of the font used in the footer is a bit too dark when using dark mode, I don't personally have a problem to read it but I guess it might be better to have a lighter color for people with vision problems.
White would be too "visible" so I guess using a color a bit darker than the one used for the "normal" text (#a0a0a0) would be the way to go.
The text was updated successfully, but these errors were encountered: