From 15991afceaec3ca3ff5ea19419201f960850d0e3 Mon Sep 17 00:00:00 2001 From: alrex Date: Tue, 3 Dec 2019 15:59:49 -0800 Subject: [PATCH] Adding link to docs (#312) Fixes #245 --- .../tests/test_shim.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ext/opentelemetry-ext-opentracing-shim/tests/test_shim.py b/ext/opentelemetry-ext-opentracing-shim/tests/test_shim.py index b1cefbcbb4c..0daabf199a0 100644 --- a/ext/opentelemetry-ext-opentracing-shim/tests/test_shim.py +++ b/ext/opentelemetry-ext-opentracing-shim/tests/test_shim.py @@ -132,8 +132,8 @@ def test_explicit_start_time(self): now = time.time() with self.shim.start_active_span("TestSpan", start_time=now) as scope: result = util.time_seconds_from_ns(scope.span.unwrap().start_time) - # Tolerate inaccuracies of less than a microsecond. - # TODO: Put a link to an explanation in the docs. + # Tolerate inaccuracies of less than a microsecond. See Note: + # https://open-telemetry.github.io/opentelemetry-python/opentelemetry.ext.opentracing_shim.html # TODO: This seems to work consistently, but we should find out the # biggest possible loss of precision. self.assertAlmostEqual(result, now, places=6) @@ -146,8 +146,8 @@ def test_explicit_end_time(self): span.finish(now) end_time = util.time_seconds_from_ns(span.unwrap().end_time) - # Tolerate inaccuracies of less than a microsecond. - # TODO: Put a link to an explanation in the docs. + # Tolerate inaccuracies of less than a microsecond. See Note: + # https://open-telemetry.github.io/opentelemetry-python/opentelemetry.ext.opentracing_shim.html # TODO: This seems to work consistently, but we should find out the # biggest possible loss of precision. self.assertAlmostEqual(end_time, now, places=6) @@ -412,8 +412,8 @@ def test_log_kv(self): span.unwrap().events[1].timestamp ) self.assertEqual(span.unwrap().events[1].attributes["foo"], "bar") - # Tolerate inaccuracies of less than a microsecond. - # TODO: Put a link to an explanation in the docs. + # Tolerate inaccuracies of less than a microsecond. See Note: + # https://open-telemetry.github.io/opentelemetry-python/opentelemetry.ext.opentracing_shim.html # TODO: This seems to work consistently, but we should find out the # biggest possible loss of precision. self.assertAlmostEqual(result, now, places=6)