Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codebase less partial #265

Open
ulysses4ever opened this issue Jun 21, 2024 · 0 comments
Open

Make codebase less partial #265

ulysses4ever opened this issue Jun 21, 2024 · 0 comments

Comments

@ulysses4ever
Copy link
Collaborator

There are many heads and tails across the code, and since GHC 9.8 they all produce warnings by default. I had to switch our project file from -Werror to -Werror=x-no-partial, sadly.

It'd be a good spring-cleaning/newcomer task to clean these a bit. Worst case you can replace head with headDef with an erroring term that explains the context. But better yet, many of these have to do with how the core datatypes are defined in Gibbon: they make extensive use of the list type, while in some cases those lists can't be empty, and so could be replaced with NonEmpty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant