You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently if progname is set manually, that had better be a unique identifier for the benchmark.
Otherwise, it currently falls back to basename of the target path. But sometimes the target path just ends in "Makefile". It should really do one of the following:
Use the full target path
Use a strategy to report a subset of the target path but ensure that that subset is UNIQUE among the benchmark suite. Also, in A/B/Makefile, it might be good to take B, but this will probably fall out of a more general policy for finding positions in the path that yield unique names.
The problem with the latter strategy is that it's too complicated and can surprise people. Extending the benchmark suite could make non-local changes in the names of the existing suite. So for now, we'll stick with the first strategy.
The text was updated successfully, but these errors were encountered:
Update: these respective behaviors are captured by canonicalBenchName vs prettyBenchName, though the latter isn't implemented yet and is just aliased to the former presently.
This ticket can stay open until the latter policy is implemented.
Currently if
progname
is set manually, that had better be a unique identifier for the benchmark.Otherwise, it currently falls back to basename of the target path. But sometimes the target path just ends in "Makefile". It should really do one of the following:
A/B/Makefile
, it might be good to takeB
, but this will probably fall out of a more general policy for finding positions in the path that yield unique names.The problem with the latter strategy is that it's too complicated and can surprise people. Extending the benchmark suite could make non-local changes in the names of the existing suite. So for now, we'll stick with the first strategy.
The text was updated successfully, but these errors were encountered: