Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git password prompt: clarify what value to enter if GitHub 2FA is enabled #61

Open
ronaldtse opened this issue Nov 29, 2019 · 3 comments
Assignees
Labels
📖 docs enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

If GitHub two factor authentication is enabled, the password prompt will keep being prompted without explaining why.

The workaround is to go to GitHub Settings > Personal Access Token and generate one with “repo” functionality to be able to make the pushes.

If the editor app detects that two factor is enabled, it should prompt the user to create a password access token.

@ronaldtse ronaldtse added the bug Something isn't working label Nov 29, 2019
@ronaldtse ronaldtse changed the title GitHub login: If two factor is enabled, tell the user it is not supported. GitHub login: If two factor is enabled, tell the user what has to be done Nov 29, 2019
@strogonoff
Copy link
Collaborator

strogonoff commented Nov 29, 2019

To work around the password requirement, the options are:

  • Request to create a personal token like suggested in the description
  • Allow to specify SSH key, if Git is installed locally it may be possible to make work, but not certain
  • Support OAuth (this is the least certain way from previous experience)

@strogonoff
Copy link
Collaborator

I’m going to go with the personal access token for now.

By the way, the app may not be able to tell if authentication error is due to 2FA or wrong password. This will be made part of the docs, to which password prompt should link.

@strogonoff strogonoff changed the title GitHub login: If two factor is enabled, tell the user what has to be done Git password prompt: clarify what value to enter if GitHub 2FA is enabled Nov 29, 2019
@strogonoff strogonoff added enhancement New feature or request and removed bug Something isn't working labels Nov 29, 2019
@strogonoff
Copy link
Collaborator

I’m not a fan of tying our app to GitHub, it’s meant to support any Git implementation. Additionally, 2FA means potentially supporting integrations with multiple Git hosting provider APIs in future, which may be overhead we’re unable to bear yet.

No objection to documenting GitHub-specific issues like this one, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 docs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants