You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ronaldtse
changed the title
GitHub login: If two factor is enabled, tell the user it is not supported.
GitHub login: If two factor is enabled, tell the user what has to be done
Nov 29, 2019
I’m going to go with the personal access token for now.
By the way, the app may not be able to tell if authentication error is due to 2FA or wrong password. This will be made part of the docs, to which password prompt should link.
strogonoff
changed the title
GitHub login: If two factor is enabled, tell the user what has to be done
Git password prompt: clarify what value to enter if GitHub 2FA is enabled
Nov 29, 2019
I’m not a fan of tying our app to GitHub, it’s meant to support any Git implementation. Additionally, 2FA means potentially supporting integrations with multiple Git hosting provider APIs in future, which may be overhead we’re unable to bear yet.
No objection to documenting GitHub-specific issues like this one, though.
If GitHub two factor authentication is enabled, the password prompt will keep being prompted without explaining why.
The workaround is to go to GitHub Settings > Personal Access Token and generate one with “repo” functionality to be able to make the pushes.
If the editor app detects that two factor is enabled, it should prompt the user to create a password access token.
The text was updated successfully, but these errors were encountered: