-
Notifications
You must be signed in to change notification settings - Fork 22
Skin tooltip #223
Comments
Hi Madou, I found your repo looking to help contribute towards hacktoberfest. Could you clarify this issue a little bit more? Where do I go to see a skin missing its tooltip? Are you looking for it behave like when you mouse over skills/gear like on the embeds example page |
Hey mate! Almost! This issue is just surrounding the skins tooltip, the skins embed is another issue (and tbh there isn't any community need for skins embed). Currently there is no skins tooltip, so when you hover over a skin, nothing happens! Examples of skins currently in the armory would be skins you have to collect to unlock achievements. I'm not currently on a PC (away from home until tomorrow) so it's a little hard for me to get an example achievement for you. If you can wait 24 hours I can get you a detailed explanation on what |
Needs to happen.. :) |
Yep, I can wait. Thanks! |
hi @esunder For an example, check out the Basic Collections achievements. Tip of the Spear: Each of those items are skins, but currently have no tooltip! They are the Gw2Skin component, which in turn is just a small wrapper over the Item component. Unfortunately the To get started (in no particular order):
Good luck! Let me know if anything else needs explaining. Tests are also setup with mocha/enzyme, so if you're feeling frisky feel free to do some tdd too. |
@Madou Do I need to do anything special to get achievements to load locally? I see that the dailyGroups comes back undefined in fetchAchievementGroups. My local config is pointed at the live backend. Do I need to run the backend locally instead? |
I did some more investigation. It's not supposed to go against the gw2armory, but the guildwars2 official API, so the config shouldnt be an issue. I put a log in the readAchievementGroups call. It looks like this is the function that is responsible for making the actual request to get the data, however my log is never triggered. I am now trying to figure out how this call is wired up to the fetchAchievementGroups function I previously pasted. If I am understanding the code above correctly, it says that the call can accept either an Array OR the string 'all'. However, in the fetchAchievementGroups it is calling with ['all'], which is an Array. I thought this might be why call is not wiring up properly, perhaps there is some kind of binding of fetchAchievementGroups to the readAchievementGroups function, and because its being called with an Array instead of an Array OR string, then it fails to call the appropriate function. However, changing it to just pass the string 'all' still fails to trigger my log. |
Ok, I think I have a fix for this: #349 But I get the following errors when trying to commit. This is on a fresh feature branch off of master in my fork. I understand and like the idea of pre-commit hooks to validate the commit, but does this happen on your machine too? Why is master in this 'broken' state? Should I be working off of dev/react16 instead? |
@esunder did you install deps with nice catch with the achievement stuff, i'll have a look at your PR. (just took a look at the readme, whoops! I never updated it to mention as a side, I've actually started extracting out common functionality between the armory website + armory embeds, see: https://github.com/madou/armory-component-ui/ if you'd like you can add the skin tooltip there (will be easier to develop with, too). I can worry about back porting it back to the armory :). |
@Madou Here is a work in progress! Here is a screenshot of the in-game tooltip. I have some questions below. If so, couple questions:
Otherwise, if you like what I've got, I can package it up and create a PR. |
@esunder nice work so far!
i'll do a code review when you're ready :) |
@esunder howd you go? |
@esunder i believe skins dont fall into that category (only items). so i reckon make the title white as well :) |
Ok, will do that right now. |
There isn't a tooltip for skins atm
The text was updated successfully, but these errors were encountered: