Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release uses vulnerable yargs-parser #302

Closed
chrisdjali-wrld3d opened this issue Nov 5, 2020 · 13 comments · Fixed by #195
Closed

Latest release uses vulnerable yargs-parser #302

chrisdjali-wrld3d opened this issue Nov 5, 2020 · 13 comments · Fixed by #195
Assignees
Labels
dependencies Pull requests that update a dependency file security
Milestone

Comments

@chrisdjali-wrld3d
Copy link

The 9.0.0 release depends on yargs-parser ^10.0.0 via meow ^5.0.0. It looks like this has been resolved on the master branch, but no release has happened since then. This means that users of the NPM package will fail npm audit.

@ghost
Copy link

ghost commented Nov 5, 2020

Yep, seems this was resolved here: #195

Any chance of a new release with the fix @jimmyandrade 🙏

@jimmyandrade jimmyandrade linked a pull request Nov 5, 2020 that will close this issue
@jimmyandrade jimmyandrade added dependencies Pull requests that update a dependency file security labels Nov 5, 2020
@jimmyandrade jimmyandrade added this to the 10.0 milestone Nov 5, 2020
@jimmyandrade
Copy link
Collaborator

jimmyandrade commented Nov 5, 2020

@chrisdjali-wrld3d thanks for sharing and reminding us of this issue.

@iainbethune thanks for asking. I still can't release a new version by myself, because I don't have NPM publishing tokens yet, I need help from @evilebottnawi.

@alexander-akait could you help us with this?

@ghost
Copy link

ghost commented Nov 26, 2020

Just wondering if there is any update on getting a new release out @jimmyandrade @alexander-akait?

@jimmyandrade
Copy link
Collaborator

jimmyandrade commented Nov 26, 2020

@iainbethune I still can't release a new version by myself 😢

@alexander-akait could you give me permissions for publishing webfont on npm?

@alexander-akait
Copy link
Member

@jimmyandrade can you give me your npm account?

@alexander-akait
Copy link
Member

Sorry for delay, there are a lot of issues (over 200-300 every day)

@jimmyandrade
Copy link
Collaborator

jimmyandrade commented Nov 26, 2020

@jimmyandrade can you give me your npm account?

@alexander-akait Of course! It's jimmyandrade (https://www.npmjs.com/~jimmyandrade)

Sorry for delay, there are a lot of issues (over 200-300 every day)

Wow! I had no idea. I hope that with these publishing permissions I will help you to decrease at least some of these requests here 😊

@alexander-akait
Copy link
Member

I really hate npm, they just removed the ability to add outside collaborators, every time when I am working with npm something goes wrong, @jimmyandrade sent invite

@alexander-akait
Copy link
Member

@jimmyandrade now you can publish https://www.npmjs.com/package/webfont, don't forget to enable 2FA to security

@ghost
Copy link

ghost commented Dec 9, 2020

Just got an automated note about this from github today... are we any closer to getting a new release out @jimmyandrade?

P.S. Thanks for both of you guys spending your time solving this :)

@goozo
Copy link

goozo commented Jan 12, 2021

just wondering if the new release is going to be published soon addressing this issue? cheers.

@jimmyandrade
Copy link
Collaborator

just wondering if the new release is going to be published soon addressing this issue? cheers.

I have great news! Now I can publish packages, so Webfont 10 was released yesterday with many dependency upgrades. (It's a breaking change because we removed support to legacy Node versions).

Could you please try v10.0.0? Thanks!

@chrisdjali-wrld3d
Copy link
Author

Looks like this has been resolved now, so I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants