Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to unzip2 #47

Closed
davewasmer opened this issue Oct 18, 2015 · 2 comments
Closed

Switch to unzip2 #47

davewasmer opened this issue Oct 18, 2015 · 2 comments
Labels

Comments

@davewasmer
Copy link

It appears that the unzip module is abandoned. When using this module, I periodically get invalid signature errors, which appear to originate from the unzip. Looking through the unzip issues shows several other folks with similar issues.

It looks like a fork has fixed at least some of these issues: unzip2. It might be worth switching over.

It looks like it maintains the same API. I would submit a PR with the change, but it looks like you are monkey-patching the unzip stream's .emit() function, so I wanted to check with you first.

@haydenbleasel
Copy link
Contributor

@davewasmer To be honest, I haven't touched this module's code in a while - a couple of other contributors implemented the unzip functionality that broke things and I haven't had the time to fix anything up.

That being said, if you reckon you can fix the unzip issues by switching to the fork that's cool with me, but it looks like his fork hasn't got any of the updates from the original repo's 0.1.10 and 0.1.11 updates.

@haydenbleasel
Copy link
Contributor

Hey @davewasmer, merging this issue into Favicons 4.0. I'd love for you to join in the discussion: #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants