-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always generate manifest.json? #202
Comments
@brunocodutra better add option (by default in true) 👍 |
I had to remove this package once I realized that it is also generating |
@musaffa we will have option for disable this 👍 |
@evilebottnawi Is there any update about having an option to disable manifest generation? |
It seems Which as mentioned above is forcing users to use another package to handle the manifest generation, the loss being you're going to have to handle icons separately again. If either this plugin could have a flag to disable manifest, or ideally take an |
@evilebottnawi Any status update about optional manifest generation? This is really blocking us from using this module. |
@slayerpart PR welcome |
It appears that in the latest version, the manifest file's name has been changed. Maybe it's in response to the above complaints, but to me, it totally makes sense that this package generates a manifest file since a large part of the manifest file is the list of icons. I found it particularly annoying that the file extension was changed because now when I view the file in my editor, I don't get syntax lighting. Luckily, I found a workaround that might also work for the above issues. It seems to be totally undocumented, but if in your config object you add the key files.android.manifestFileName and set it to the name you want the file to have, the resulting manifest file will have that name. Of course, that name is also used in the generated index.html file (which you can also rename). For the maintainers, on the README page, there are comments that refer to the 'manifest.json' file, even though by default it's not named that. It might confuse some people (like me ;-) |
@johndeighan See #368 |
Now that browsers other than chrome are picking up on support for
manifest.json
does it make sense to have it always generated?The text was updated successfully, but these errors were encountered: