Add Python Extension's "Create Env" command into DVC Setup #4058
Conversation
| @@ -29,6 +33,9 @@ export const CliUnavailable: React.FC<PropsWithChildren> = ({ children }) => { | |||
| </p> | |||
| <div className={styles.sideBySideButtons}> | |||
| <Button onClick={installDvc} text="Install (pip)" /> | |||
| {isPythonExtensionUsed && ( | |||
| <Button onClick={updatePythonEnvironment} text="Update Env" /> | |||
There was a problem hiding this comment.
This pr's focus is adding the logic and quick pick for updating the python environment or creating a new one. I'm going to do separate prs for:
- adding a
--userto the command if the environment is global - improving the step's contents (for example, updating the text for "Configure")
We can merge this as is or I'll add a do not merge label until the other two prs are ready :)
|
Fine to merge after comment is addressed. |
|
Code Climate has analyzed commit 2d1742e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
|
QQ - does it means that we don't need Configure anymore though? |
Configure (aka "Setup the Workspace" command) would be needed if the user has DVC globally installed, like with |
what does it give on top of Update Env (why update btw?) ? Global vs env choice? Can we combine those somehow into one flow? |
"Setup the Workspace" or "Configure" is focused on locating an already installed version of DVC, starting by asking if you have it installed globally or automatically.
I chose the term "update" since the action updates the selected python environment, either by creating a new one or selecting from already created ones. No strong preference on the name though!
Apologies, I'm a little confused by your question. Could you give me some more details? By the way, I've posted some ideas for the next iteration of the "DVC is unavailable" step in #3935. Might be easier to continue the discussion there for visibility :) |
Demo
Screen.Recording.2023-06-10.at.5.31.09.PM.mov
Part of #3935