Add add configuration button in experiments table #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
approved these changes
Feb 16, 2023
| @@ -998,3 +998,7 @@ $badge-size: 0.85rem; | |||
| font-size: 0.65rem; | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| .addConfigButton { | |||
There was a problem hiding this comment.
Would it look better if the button was directly below the table instead of stuck at the bottom of the webview?
There was a problem hiding this comment.
You're right, changed.
|
Code Climate has analyzed commit 0a5442a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
mattseddon
reviewed
Feb 16, 2023
| } | ||
|
|
||
| public async changeHasConfig() { | ||
| this.hasConfig = !!(await this.hasStages()) |
There was a problem hiding this comment.
[I] As a follow up this needs to get hooked up to FileSystemData events in case the user manually adds a stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3058
Screen.Recording.2023-02-14.at.1.14.02.PM.mov
Still need a followup to change the text of the button and add explanation text.