From f247d044fdeed124ebbe8638b91c45574e39a7f1 Mon Sep 17 00:00:00 2001 From: Matt Seddon Date: Thu, 27 Apr 2023 15:47:23 +1000 Subject: [PATCH] self review --- extension/src/commands/internal.ts | 4 ++-- extension/src/experiments/commands/index.ts | 6 +++--- extension/src/vscode/toast.ts | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/extension/src/commands/internal.ts b/extension/src/commands/internal.ts index b788643fb1..a7f4aec48e 100644 --- a/extension/src/commands/internal.ts +++ b/extension/src/commands/internal.ts @@ -18,7 +18,7 @@ import { Disposable } from '../class/dispose' type Command = (...args: Args) => unknown | Promise export const AvailableCommands = Object.assign( - { EXP_PUSH: 'expPush' } as const, + {}, DvcExecutorCommands, DvcReaderCommands, DvcRunnerCommands, @@ -30,7 +30,7 @@ export const AvailableCommands = Object.assign( typeof DvcRunnerCommands & typeof DvcViewerCommands & typeof GitExecutorCommands & - typeof GitReaderCommands & { EXP_PUSH: 'expPush' } + typeof GitReaderCommands export type CommandId = (typeof AvailableCommands)[keyof typeof AvailableCommands] diff --git a/extension/src/experiments/commands/index.ts b/extension/src/experiments/commands/index.ts index 972fb0bc4d..12c559664a 100644 --- a/extension/src/experiments/commands/index.ts +++ b/extension/src/experiments/commands/index.ts @@ -115,10 +115,10 @@ export const getShareExperimentToStudioCommand = return commands.executeCommand(RegisteredCommands.SETUP_SHOW) } - return Toast.showProgress('Pushing Experiment', async progress => { + return Toast.showProgress('Sharing', async progress => { progress.report({ increment: 0 }) - progress.report({ increment: 25, message: 'Pushing experiment...' }) + progress.report({ increment: 25, message: 'Running exp push...' }) await Toast.runCommandAndIncrementProgress( () => @@ -131,6 +131,6 @@ export const getShareExperimentToStudioCommand = 75 ) - return Toast.delayProgressClosing() + return Toast.delayProgressClosing(15000) }) } diff --git a/extension/src/vscode/toast.ts b/extension/src/vscode/toast.ts index 641e108a65..d8006950a2 100644 --- a/extension/src/vscode/toast.ts +++ b/extension/src/vscode/toast.ts @@ -75,8 +75,8 @@ export class Toast { }) } - static delayProgressClosing() { - return delay(5000) + static delayProgressClosing(ms = 5000) { + return delay(ms) } private static waitForResponse(