From efe870638fd9a43c4f989facacb4ecc86f7f7267 Mon Sep 17 00:00:00 2001 From: Wolmir Nemitz Date: Mon, 18 Jul 2022 13:59:42 -0300 Subject: [PATCH] Change type of cell value as a step towards consolidation --- webview/src/experiments/util/buildDynamicColumns.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/webview/src/experiments/util/buildDynamicColumns.tsx b/webview/src/experiments/util/buildDynamicColumns.tsx index 270a2ff03f..432ecdb38c 100644 --- a/webview/src/experiments/util/buildDynamicColumns.tsx +++ b/webview/src/experiments/util/buildDynamicColumns.tsx @@ -12,6 +12,7 @@ import { Column, ValueWithChanges } from 'dvc/src/experiments/webview/contract' +import { Value } from 'dvc/src/cli/reader' import { formatFloat } from './numberFormatting' import Tooltip, { CELL_TOOLTIP_DELAY @@ -20,7 +21,7 @@ import styles from '../components/table/styles.module.scss' import { CopyButton } from '../../shared/components/copyButton/CopyButton' import { OverflowHoverTooltip } from '../components/overflowHoverTooltip/OverflowHoverTooltip' -export type CellValue = undefined | string | number | ValueWithChanges +export type CellValue = Value | ValueWithChanges export const isValueWithChanges = (raw: CellValue): raw is ValueWithChanges => typeof (raw as ValueWithChanges)?.changes === 'boolean'