apply review feedback

extension/src/connect/index.ts

@@ -12,6 +12,7 @@ import { Title } from '../vscode/title'
 import { openUrl } from '../vscode/external'
 import { ContextKey, setContextValue } from '../vscode/context'
 import { RegisteredCommands } from '../commands/external'
+import { showInformation } from '../vscode/modal'
 
 export class Connect extends BaseRepository<undefined> {
   public readonly viewKey = ViewKey.CONNECT
@@ -90,6 +91,11 @@ export class Connect extends BaseRepository<undefined> {
   private async setContext() {
     const storedToken = await this.getSecret(STUDIO_ACCESS_TOKEN_KEY)
     if (isStudioAccessToken(storedToken)) {
+      if (this.deferred.state === 'resolved') {
+        void showInformation(
+          'Studio is now connected. Use the "Share to Studio" command from an experiment\'s context menu to share experiments.'
+        )
+      }
       this.webview?.dispose()
       return setContextValue(ContextKey.STUDIO_CONNECTED, true)
     }

extension/src/connect/inputBox.test.ts

@@ -2,7 +2,7 @@ import { validateTokenInput } from './inputBox'
 
 describe('validateTokenInput', () => {
   const mockedStudioAccessToken =
-    'isat_1Z4T0zVHvq9Cu03XEe9Zjvx2vkBihfGPdY7FfmEMAagOXfQxU'
+    'isat_1Z4T0zVHvq9Cu03XEe9Zjvx2vkBihfGPdY7FfmEMAagOXfQx'
   it('should return the warning if the input is not valid', () => {
     expect(
       validateTokenInput(mockedStudioAccessToken.slice(0, -1))

extension/src/connect/token.ts

@@ -4,5 +4,5 @@ export const isStudioAccessToken = (text?: string): boolean => {
   if (!text) {
     return false
   }
-  return text.startsWith('isat_') && text.length === 54
+  return text.startsWith('isat_') && text.length >= 53
 }

extension/src/vscode/modal.ts

@@ -6,3 +6,9 @@ export const warnOfConsequences = (
   ...items: Response[]
 ): Thenable<string | undefined> =>
   window.showWarningMessage(text, { modal: true }, ...items)
+
+export const showInformation = (
+  text: string,
+  ...items: Response[]
+): Thenable<string | undefined> =>
+  window.showInformationMessage(text, { modal: true }, ...items)

webview/src/connect/components/Studio.tsx

@@ -1,29 +1,18 @@
 import React from 'react'
-import { MessageFromWebviewType } from 'dvc/src/webview/contract'
 import { STUDIO_URL } from 'dvc/src/connect/webview/contract'
+import { openStudio, openStudioProfile, saveStudioToken } from './messages'
 import { EmptyState } from '../../shared/components/emptyState/EmptyState'
 import { Button } from '../../shared/components/button/Button'
-import { sendMessage } from '../../shared/vscode'
 
 export const Studio: React.FC = () => {
-  const openStudio = () =>
-    sendMessage({ type: MessageFromWebviewType.OPEN_STUDIO })
-
-  const openStudioProfile = () =>
-    sendMessage({ type: MessageFromWebviewType.OPEN_STUDIO_PROFILE })
-
-  const saveStudioToken = () =>
-    sendMessage({ type: MessageFromWebviewType.SAVE_STUDIO_TOKEN })
-
   return (
     <EmptyState>
       <div>
         <h1>
           Connect to <a href={STUDIO_URL}>Studio</a>
         </h1>
         <p>
-          To share experiments and plots with collaborators directly from your
-          IDE.
+          Share experiments and plots with collaborators directly from your IDE.
         </p>
         <p>
           An{' '}
@@ -52,7 +41,7 @@ export const Studio: React.FC = () => {
         />
         <p>
           {"Don't Have an account?\n"}
-          <a href={STUDIO_URL}>Sign-Up</a>
+          <a href={STUDIO_URL}>Get Started</a>
         </p>
       </div>
     </EmptyState>

webview/src/connect/components/messages.ts

@@ -0,0 +1,11 @@
+import { MessageFromWebviewType } from 'dvc/src/webview/contract'
+import { sendMessage } from '../../shared/vscode'
+
+export const openStudio = () =>
+  sendMessage({ type: MessageFromWebviewType.OPEN_STUDIO })
+
+export const openStudioProfile = () =>
+  sendMessage({ type: MessageFromWebviewType.OPEN_STUDIO_PROFILE })
+
+export const saveStudioToken = () =>
+  sendMessage({ type: MessageFromWebviewType.SAVE_STUDIO_TOKEN })