From b2b194c4c90340453943fdb6e3b2f74a6eea8c83 Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:16:36 -0700 Subject: [PATCH 1/7] drop ubuntu test --- .github/workflows/check.yml | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 6272e9f..83f0fa5 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -3,6 +3,10 @@ on: schedule: - cron: 0 0 * * * pull_request: + +permissions: + contents: write + jobs: verify: runs-on: ubuntu-latest @@ -22,29 +26,9 @@ jobs: - ubuntu-latest - macos-latest - windows-latest - include: - - system: ubuntu-18.04 - container: ubuntu:18.04 runs-on: ${{ matrix.system }} - container: ${{ matrix.container }} steps: - - name: install deps - if: matrix.container == 'ubuntu:18.04' - run: | - apt update - apt install -y software-properties-common - add-apt-repository ppa:git-core/ppa - apt update - apt install -y git fontconfig make gcc pkg-config - - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 - if: - matrix.container == 'ubuntu:18.04' || matrix.system == - 'windows-latest' - with: - node-version: '16' - + - uses: actions/checkout@v3 - run: npm ci - run: npm run lint - run: npm run test From 96e424eafabd2f1571df03db4e32dcc530e86130 Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:22:46 -0700 Subject: [PATCH 2/7] add issues? --- .github/workflows/check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 83f0fa5..2bbabcf 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -6,6 +6,7 @@ on: permissions: contents: write + issues: write jobs: verify: From 71f795cc956a9a0c18244ef72bce737e5c7c1272 Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:35:59 -0700 Subject: [PATCH 3/7] target pr? --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 2bbabcf..2298c64 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -63,5 +63,5 @@ jobs: REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | echo 'Hello CML from ${{ matrix.system }}!' > report.md - cml comment create report.md + cml comment create ${{ github.event_name == 'pull_request' && "--target=pr" }} report.md cml check create report.md From 650be764093f52c4c34a5d2b9d54a71f1602f064 Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:40:56 -0700 Subject: [PATCH 4/7] . --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 2298c64..1a0e8fd 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -63,5 +63,5 @@ jobs: REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | echo 'Hello CML from ${{ matrix.system }}!' > report.md - cml comment create ${{ github.event_name == 'pull_request' && "--target=pr" }} report.md + cml comment create ${{ github.event_name == 'pull_request' && '--target=pr' }} report.md cml check create report.md From 0471710ad2f523e4b6eb548d51d0ee2b44c1ddd5 Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:44:04 -0700 Subject: [PATCH 5/7] different permissions --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 1a0e8fd..4bb97c6 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -6,7 +6,7 @@ on: permissions: contents: write - issues: write + pull-requests: write jobs: verify: From bf9e80e245520c78ac4f08b4f24cee2387170df5 Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:50:18 -0700 Subject: [PATCH 6/7] add statuses? --- .github/workflows/check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 4bb97c6..6070121 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -7,6 +7,7 @@ on: permissions: contents: write pull-requests: write + statuses: write jobs: verify: From 67cc0033fa9d52501ed6afc96962257a873f8c5f Mon Sep 17 00:00:00 2001 From: Daniel Barnes Date: Thu, 4 May 2023 10:52:11 -0700 Subject: [PATCH 7/7] checks not statuses --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 6070121..ea07a4c 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -7,7 +7,7 @@ on: permissions: contents: write pull-requests: write - statuses: write + checks: write jobs: verify: