Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Unify what authorization MLEM and DVC require #616

Open
aguschin opened this issue Feb 24, 2023 · 4 comments
Open

Unify what authorization MLEM and DVC require #616

aguschin opened this issue Feb 24, 2023 · 4 comments
Labels
credentials Authentication-related stuff git Working with Git in MLEM p1-high High priority ux Things that matter for user experience

Comments

@aguschin
Copy link
Contributor

Right now, when working with private repos, MLEM require HTTPS auth, while DVC require SSH https://mlem.ai/doc/user-guide/dvc/#working-with-private-repositories

It's awkward, so we'd like to allow to use a single authentication method. IIUC, DVC supports SSH only https://dvc.org/doc/api-reference/open#example-accessing-private-repos (@skshetry, @efiop, can you please confirm?)

If so, then it makes sense to make MLEM support SSH (we can keep supporting HTTPs if that's possible).

related to #497

@aguschin aguschin added git Working with Git in MLEM credentials Authentication-related stuff p1-high High priority ux Things that matter for user experience labels Feb 24, 2023
@skshetry
Copy link
Member

skshetry commented Feb 24, 2023

DVC supports both HTTPS/SSH authentication. The docs was just showing an example with ssh. You can pass passwords in url itself, or better enable git credentials-helper, from which dvc can extract username/password for the remote url.

Regarding GITHUB_USERNAME and GITHUB_TOKEN, it's mlem's implementation than being a standard, and even does not have anything to do with fsspec.

kwargs["username"] = LOCAL_CONFIG.GITHUB_USERNAME
kwargs["token"] = LOCAL_CONFIG.GITHUB_TOKEN

@aguschin
Copy link
Contributor Author

aguschin commented Mar 9, 2023

Hi @skshetry! Is this incorrect info that should be fixed then?
image
https://dvc.org/doc/command-reference/exp/push

@aguschin
Copy link
Contributor Author

aguschin commented Mar 14, 2023

@skshetry could you please TAL and answer? :)

@skshetry
Copy link
Member

yes, it is incorrect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
credentials Authentication-related stuff git Working with Git in MLEM p1-high High priority ux Things that matter for user experience
Projects
None yet
Development

No branches or pull requests

2 participants