Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Problem with example in docs #387

Closed
shortcipher3 opened this issue Jul 5, 2022 · 6 comments
Closed

Problem with example in docs #387

shortcipher3 opened this issue Jul 5, 2022 · 6 comments
Assignees
Labels
A: docs DEPRECATED Area: user documentation; See github.com/iterative/mlem.ai/labels/A%3A%20docs cli MLEM command-line interface ux Things that matter for user experience

Comments

@shortcipher3
Copy link

Testing out mlem I ran mlem --help and saw the examples:

Examples:
    $ mlem init
    $ mlem list https://github.com/iterative/example-mlem
    $ mlem clone models/logreg --project https://github.com/iterative/example-mlem --rev main logreg
    $ mlem link logreg latest
    $ mlem apply latest https://github.com/iterative/example-mlem/data/test_x -o pred
    $ mlem serve latest fastapi -c port=8001
    $ mlem build latest docker_dir -c target=build/ -c server.type=fastapi

Great, let's test out the second one:

$ mlem clone models/logreg --project https://github.com/iterative/example-mlem --rev main logreg
❌ Revision 'main' wasn't found in path=https://github.com/iterative/example-mlem, fs=None
Please report it here: <https://github.com/iterative/mlem/issues>

Maybe try a different example:

➜ mlem clone models/logreg --project https://github.com/iterative/example-mlem --rev main logreg
❌ Revision 'main' wasn't found in path=https://github.com/iterative/example-mlem, fs=None

Oh it looks like this url https://github.com/iterative/example-mlem is bad, maybe I should use the frozen repo?

$ mlem clone models/logreg --project https://github.com/iterative/example-mlem-frozen --rev main logreg
❌ Unexpected error: 403 Client Error: rate limit exceeded for url: https://api.github.com/repos/iterative/example-mlem-frozen/git/trees/main
Please report it here: <https://github.com/iterative/mlem/issues>

It would be great for quick testing purposes if the examples worked or if these are dummy urls to make it more clear that we need to provide urls for projects we set up. I'm also concerned about the rate limiting error, is that something I will run into if I start using this for my projects?

@aguschin
Copy link
Contributor

aguschin commented Jul 6, 2022

@mike0sv, we discussed this already. Do you think we need to just remove this examples, or update them? Since we need to update docs already, it's not that convenient to update this in both places for such a huge project. But it's still useful. WDYT?

@aguschin
Copy link
Contributor

aguschin commented Jul 6, 2022

I'm fine with both, but considering limited capacity we have I would prefer removing this and keeping docs only.

@mike0sv
Copy link
Contributor

mike0sv commented Jul 6, 2022

ok, can we add a link to documentation instead?

@aguschin
Copy link
Contributor

aguschin commented Jul 7, 2022

Yes, sure. In mlem --help only? Or in each mlem cmd --help?

@aguschin aguschin added the A: docs DEPRECATED Area: user documentation; See github.com/iterative/mlem.ai/labels/A%3A%20docs label Jul 7, 2022
@mike0sv
Copy link
Contributor

mike0sv commented Jul 7, 2022

makes sense to do each

@jorgeorpinel jorgeorpinel transferred this issue from iterative/mlem Aug 24, 2022
@jorgeorpinel jorgeorpinel transferred this issue from iterative/mlem.ai Aug 24, 2022
@jorgeorpinel jorgeorpinel added ux Things that matter for user experience cli MLEM command-line interface labels Aug 24, 2022
@aguschin aguschin self-assigned this Aug 29, 2022
@aguschin aguschin moved this to Todo in MLEM + GTO Aug 29, 2022
@aguschin aguschin moved this from Todo to In review in MLEM + GTO Sep 23, 2022
@aguschin
Copy link
Contributor

aguschin commented Oct 5, 2022

closed by #408

@aguschin aguschin closed this as completed Oct 5, 2022
Repository owner moved this from In review to Done in MLEM + GTO Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: docs DEPRECATED Area: user documentation; See github.com/iterative/mlem.ai/labels/A%3A%20docs cli MLEM command-line interface ux Things that matter for user experience
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants