-
Notifications
You must be signed in to change notification settings - Fork 11
Update Scenarios for DVC 2.0 #20
Comments
Could you arrange the permissions/membership so that I can take over updating katacoda? @shcheklein Thank you. |
@iesahin I've added you to the repo. You can now do PRs and they are merged it will deployed I think. Feel free to merge them as you go, unless it's some substantial change to the content and you feel that review is needed |
Thank you. |
I have updated the versioning part. |
Changed the name because most of the parts require an update for 1.0 as well. After the release we can update the commands and breaking changes for 2.0 |
Hi @iesahin 👋. I noticed you started committing directly to
|
Seems like that should be a separate issue in this repo? I'd also add checkboxes to the description above for each Get Started chapter:
|
Question: what's the purpose of updating scenarios but keep using 1.0? Should we focus on updating them with 2.0 along the way? Per iterative/dvc.org#2026 |
@jorgeorpinel Hi. 👋🏼 I began writing with PRs but the iteration takes 2x time that way. You need to merge to I thought establishing a basic structure first and iterating with PRs is more reasonable.
The initial title for this issue had DVC 2.0. Then, as a stable release was needed to install with Almost all the content and scripts in scenarios required update. I didn't stick to the issues. (e.g. the scenarios weren't able to run because the containers were not able to install DVC in the first place.) I'll just review and check if the issues are done, move them here and see whether we have some missing items. Thank you for reviewing all. 🙏🏼 Muchas gracias. I'll update the scenarios in PRs. |
Shouldn't take that much longer, maybe 10-20% extra time? But it's worth it. Without branching or PRs it's pretty hard to go back and find where/why things were updated. For example your recent PRs are very clear e.g. #31 fixes up the language in the GS/Init scenario. We can go there and comment on any further/pending issues related to that, etc. (divide and conquer). BTW we can make reviews before you merge PRs if you want, you just need to request a review before merging. Look how much better organized the Git history is now, with branches (you can tell where they start from) that have all the commits, while Finally, this kind of an industry standard for collaborative/public repos. Further reading if you're interested: https://www.gitkraken.com/learn/git/best-practices/git-branch-strategy. |
Sounds good!
Yes they were probably made for dvc 0.x still! At least now they run and have decent, updated explanations, which is the most important step 👍 Looking forward to the 2.0 updates (again, feel free to request in-PR reviews before merging) @iesahin. Thanks |
I think the portions related to katacoda in iterative/dvc.org#1943 are resolved. We can close this. |
Currently there are a few issues in documentation repo for katacoda scenarios. Basically these are not running because of a required system upgrade to Python 3.8.
Update 2021-03-08
The text was updated successfully, but these errors were encountered: