Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping required for promotion tags #114

Open
aguschin opened this issue Apr 12, 2022 · 3 comments
Open

Escaping required for promotion tags #114

aguschin opened this issue Apr 12, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@aguschin
Copy link
Contributor

Rn promotions tags look like rf#prod. # requires escaping in some shells. Is there a better alternative? Need to check @ also.

@aguschin aguschin added this to the First GTO release milestone Apr 12, 2022
@omesser
Copy link
Contributor

omesser commented Apr 16, 2022

: and @ don't require escapes and are common delimiters, I think : is easiest on the eyes and also familiar from other places like $PATH

@aguschin
Copy link
Contributor Author

aguschin commented Aug 31, 2022

Since we released it with # already, I don't think we need to change this anytime soon.

Still, when we print a git push suggestion, we need to escape those characters I believe (how this will work in shells where you don't need to escape them? Won't it break there?)

e.g. in

$ gto assign xx --stage prod
Created git tag 'xx#prod#1' that assigns stage to version 'v0.0.1'
To push the changes upstream, run:
    git push xx#prod#1

@aguschin aguschin added the good first issue Good for newcomers label Aug 31, 2022
@aguschin
Copy link
Contributor Author

aguschin commented Sep 6, 2022

One more things with this: git push xx#prod#1 miss remote name. E.g. it should be git push origin xx#prod#1 or something. Not sure how to print this in CLI output. git push origin xx#prod#1 or git push <remote> xx#prod#1 to avoid blindly copy-pasting and running the suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants