Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: infer when the step should be finalized #9

Closed
pared opened this issue Dec 1, 2020 · 1 comment
Closed

logging: infer when the step should be finalized #9

pared opened this issue Dec 1, 2020 · 1 comment
Assignees
@pared
Labels
enhancement

Comments

@pared
Copy link
Contributor

pared commented Dec 1, 2020 •
edited
Loading

Currently we require user to call next_step to append metrics to history, and dump new summary json.

We could probably omit that with some logic, eg:

  • assume new step when trying to insert duplicated key to metrics dict.

Worth checking if and how other tools deal with that.
@pared
Copy link
Contributor Author

pared commented Jan 4, 2021

Done in iterative/dvc#4902

@pared pared closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pared pared

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pared