Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frameworks: improve log_artifact for model "checkpoints" #504

Closed
dberenbaum opened this issue Mar 20, 2023 · 2 comments
Closed

frameworks: improve log_artifact for model "checkpoints" #504

dberenbaum opened this issue Mar 20, 2023 · 2 comments
Assignees
Labels
A: frameworks Area: ML Framework integration discussion requires active participation to reach a conclusion p1-important Include in the next sprint

Comments

@dberenbaum
Copy link
Collaborator

When auto-logging model artifacts as part of the frameworks in #500, sometimes frameworks save multiple model files at different paths within a directory to allow users to keep multiple model checkpoints:

This present some questions for our callbacks:

  1. Should we save the individual files or the entire directory?
  2. How should we keep track of the latest model file so that it can be used to resume/analyze/deploy?
@dberenbaum
Copy link
Collaborator Author

After #472, live.log_artifact should be adding something to dvclive/dvc.yaml like:

artifacts:
  fast-ai-model:
    path: model.pth
    type: model

This artifacts section could be used to answer question 2 above. Each call to live.log_artifact can update the path in that artifacts section from model_1.pth to model_2.pth and so on, and @aguschin is working on making it possible to do things like dvc get . fast-ai-model so that it's possible to get the model without specifying the exact path of the last checkpoint.

In that case, question 1 becomes less important and is mostly about how we want to organize the .dvc files: is it okay to have one for each checkpoint, or should we try to track the model directory?

@dberenbaum dberenbaum added discussion requires active participation to reach a conclusion A: frameworks Area: ML Framework integration p1-important Include in the next sprint labels Mar 20, 2023
@dberenbaum dberenbaum added this to DVC Jun 13, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jun 13, 2023
@dberenbaum dberenbaum self-assigned this Jun 27, 2023
@dberenbaum dberenbaum moved this from Backlog to Todo in DVC Jul 4, 2023
@dberenbaum dberenbaum moved this from Todo to In Progress in DVC Jul 11, 2023
@dberenbaum
Copy link
Collaborator Author

I think we can close this as completed with the work we have done so far in lightning and huggingface

@github-project-automation github-project-automation bot moved this from In Progress to Done in DVC Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: frameworks Area: ML Framework integration discussion requires active participation to reach a conclusion p1-important Include in the next sprint
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant