-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc
: Enable model loading/saving based on checkpoint: true
#191
Comments
What do you mean by "we use the value of the output as |
Yes. Make DVC store the output path in an env var, like it does for DVCLIVE_PATH |
@daavoo That would work only in integrations, right? |
With the current implementation, yes. |
It makes sense to me. It still seems slightly awkward to have to define the path in |
Given a DVC stage where
checkpoints
are enabled:Users need to also remember enabling checkpoints on the stage code.
Maybe we could treat the
model_file
argument of the integrations similar to how we treat thepath
argument:A) If
checkpoint: true
is set in DVC andmodel_file
is None in DVCLive: we use the value of the output asmodel_file
.B) If
checkpoint: true
is set in DVC andmodel_file
is set in DVCLive but does not match: raiseConfigMismatchError
.C) If
checkpoint: false
, just use whichever value hasmodel_file
in DVCLive.The text was updated successfully, but these errors were encountered: