-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logger: log to summary first, then to logs #145
Comments
Related: #157 (comment) |
Coming from #157 , looks like instead of switching |
From #157 (comment):
This might not be an issue since I think a final checkpoint is implicitly added at the end if anything has changed since the last checkpoint. |
@dberenbaum I modified the discussion title to make it clearer |
Extracted from #142 (review).
Would summary -> tsv be more helpful (this would obviously require summary to always exist)? It's more intuitive to me (and follows the internal logic of MetricLogger._metrics) to gather all metrics for a step and then append to metrics logs. It also enables no-step scenarios like classical ML algorithms by logging the summary without ever creating the tsv files.
The text was updated successfully, but these errors were encountered: