Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: log to summary first, then to logs #145

Closed
dberenbaum opened this issue Aug 26, 2021 · 4 comments · Fixed by #164
Closed

logger: log to summary first, then to logs #145

dberenbaum opened this issue Aug 26, 2021 · 4 comments · Fixed by #164
Assignees
Labels
discussion requires active participation to reach a conclusion refactoring

Comments

@dberenbaum
Copy link
Collaborator

Extracted from #142 (review).

Would summary -> tsv be more helpful (this would obviously require summary to always exist)? It's more intuitive to me (and follows the internal logic of MetricLogger._metrics) to gather all metrics for a step and then append to metrics logs. It also enables no-step scenarios like classical ML algorithms by logging the summary without ever creating the tsv files.

@daavoo daavoo added discussion requires active participation to reach a conclusion refactoring labels Aug 26, 2021
@daavoo daavoo mentioned this issue Aug 27, 2021
@daavoo
Copy link
Contributor

daavoo commented Sep 13, 2021

Related: #157 (comment)

@daavoo daavoo self-assigned this Sep 14, 2021
@daavoo daavoo mentioned this issue Sep 14, 2021
2 tasks
@daavoo
Copy link
Contributor

daavoo commented Sep 14, 2021

Coming from #157 , looks like instead of switching tsv -> summary order would be better to just do tsv and summary in the same place (dvclive.log)

@dberenbaum
Copy link
Collaborator Author

dberenbaum commented Sep 14, 2021

From #157 (comment):

@dberenbaum @pared even if we consider thesummary behavior fixed (by moving it to log), it doesn't feel like there is a way to fulfill the 3 points listed above when considering html and checkpoints.

This might not be an issue since I think a final checkpoint is implicitly added at the end if anything has changed since the last checkpoint.

@pared pared changed the title tsv -> summary workflow logger: log to summary first, then to logs Sep 15, 2021
@pared
Copy link
Contributor

pared commented Sep 15, 2021

@dberenbaum I modified the discussion title to make it clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion requires active participation to reach a conclusion refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants