Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: config: show merged config with --show-origin #5188

Merged
merged 4 commits into from
Jan 4, 2021

Conversation

mrstegeman
Copy link
Contributor

Builds on #5126 and #5184 by showing the full merged config when
listing or getting config options.

References #5126
References #5184
References iterative/dvc.org#2028
Fixes #5119

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Builds on iterative#5126 and iterative#5184 by showing the full merged config when
listing or getting config options.

References iterative#5126
References iterative#5184
References iterative/dvc.org#2028
Fixes iterative#5119
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Do you plan on introducing tests for this?

@mrstegeman
Copy link
Contributor Author

The existing tests are still valid, but I've added some additional ones to cover some additional cases.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@efiop efiop merged commit 764960f into iterative:master Jan 4, 2021
@mrstegeman mrstegeman deleted the show-origin branch January 19, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: add support for --show-origin
2 participants