Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dvcignore reset in repo._reset #4371

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Aug 10, 2020

fix #3869
Repo add,checkout,etc will not change .dvcignore, and can remove dvcignore reset after these operations.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

No performance improvement in dvc status(only influence commands using repo._reset())
Screenshot from 2020-08-10 22-47-39

@pared Excuse me, my dvc add tests failed.
On origin/master, clone the local repo to ./ then edit hashes.txt manually and run asv run HASHFILE:hashes.txt. And these is my error message.
Screenshot from 2020-08-10 22-54-53

Repo `add`,`checkout`,etc will not change `.dvcignore`, and can remove dvcignore reset after these operations.
@pared
Copy link
Contributor

pared commented Aug 10, 2020

@karajan1001
You need to pull the cats_dogs data from public repo, it should be configured inside repo. Please run:
dvc pull data/cats_dogs.dvc -r bench_s3_public

EDIT:
updated README: iterative/dvc-bench#200

@pared pared requested a review from efiop August 10, 2020 15:19
@skshetry
Copy link
Member

@karajan1001, one test is failing, need adjustment on:

dvc_tree = dvc.tree

Just need to call after that location dvc_tree.__dict__.pop("dvcignore", None).

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #4371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4371   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         178      178           
  Lines       12352    12352           
=======================================
  Hits        11231    11231           
  Misses       1121     1121           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 78458ee...6cf5b93. Read the comment docs.

1. subrepo created during session open time.
Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we need tree._reset() kind of API anyway for the tests. Though, looks good for now.

@efiop efiop merged commit 12c7013 into iterative:master Aug 11, 2020
@karajan1001 karajan1001 deleted the dvcignore_optimize branch August 11, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize dvcignore
4 participants