From a59d909a10b858c7afb5500337eafb5dc35a40c9 Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Thu, 7 May 2020 10:58:13 -0500 Subject: [PATCH 1/4] plot: update datafile desc. --- dvc/command/plot.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dvc/command/plot.py b/dvc/command/plot.py index f52dd639cb..2084060851 100644 --- a/dvc/command/plot.py +++ b/dvc/command/plot.py @@ -166,7 +166,7 @@ def add_parser(subparsers, parent_parser): plot_show_parser.add_argument("--xlab", default=None, help="X axis title.") plot_show_parser.add_argument("--ylab", default=None, help="Y axis title.") plot_show_parser.add_argument( - "datafile", nargs="?", default=None, help="Metrics file to visualize.", + "datafile", nargs="?", default=None, help="Metrics file to visualize", ) plot_show_parser.set_defaults(func=CmdPlotShow) @@ -193,7 +193,7 @@ def add_parser(subparsers, parent_parser): "--datafile", nargs="?", default=None, - help="Metrics file to visualize.", + help="Metrics file to visualize", ) plot_diff_parser.add_argument( "-f", "--file", default=None, help="Name of the generated file." From 150be951c968bdc7f9cf7536e82fbb4da040b119 Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Thu, 7 May 2020 12:07:38 -0500 Subject: [PATCH 2/4] plot: link to cmd ref in output --- dvc/repo/plot/data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dvc/repo/plot/data.py b/dvc/repo/plot/data.py index dff044a9a7..4c9d736d17 100644 --- a/dvc/repo/plot/data.py +++ b/dvc/repo/plot/data.py @@ -29,7 +29,7 @@ class PlotDataStructureError(DvcException): def __init__(self): super().__init__( "Plot data extraction failed. Please see " - "documentation for supported data formats." + "https://man.dvc.org/plot for supported data formats." ) From e0b065cfd775807f6ec9cd84cead585c4eef1f4b Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Thu, 7 May 2020 12:12:01 -0500 Subject: [PATCH 3/4] plot: update --stdout desc per https://github.com/iterative/dvc/pull/3577#pullrequestreview-407036181 --- dvc/command/plot.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dvc/command/plot.py b/dvc/command/plot.py index 2084060851..6e5cbd8a33 100644 --- a/dvc/command/plot.py +++ b/dvc/command/plot.py @@ -148,7 +148,7 @@ def add_parser(subparsers, parent_parser): "--stdout", action="store_true", default=False, - help="Print plot specification to stdout.", + help="Print plot location to stdout.", ) plot_show_parser.add_argument( "--no-csv-header", @@ -214,7 +214,7 @@ def add_parser(subparsers, parent_parser): "--stdout", action="store_true", default=False, - help="Print plot specification to stdout.", + help="Print plot location to stdout.", ) plot_diff_parser.add_argument( "--no-csv-header", From ab1d34a17649d7e9746dbf3840962fe84df02f4f Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Mon, 11 May 2020 22:36:40 -0500 Subject: [PATCH 4/4] plot: a few more output string updates per https://github.com/iterative/dvc/pull/3759#pullrequestreview-409011291 and https://github.com/iterative/dvc.org/pull/1283 --- dvc/command/plot.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/dvc/command/plot.py b/dvc/command/plot.py index 6e5cbd8a33..0e29c9c995 100644 --- a/dvc/command/plot.py +++ b/dvc/command/plot.py @@ -148,7 +148,7 @@ def add_parser(subparsers, parent_parser): "--stdout", action="store_true", default=False, - help="Print plot location to stdout.", + help="Print plot specification to stdout.", ) plot_show_parser.add_argument( "--no-csv-header", @@ -171,7 +171,7 @@ def add_parser(subparsers, parent_parser): plot_show_parser.set_defaults(func=CmdPlotShow) PLOT_DIFF_HELP = ( - "Plot metrics differences between commits in the DVC " + "Plot differences in metrics between commits in the DVC " "repository, or between the last commit and the workspace." ) plot_diff_parser = plot_subparsers.add_parser( @@ -214,7 +214,7 @@ def add_parser(subparsers, parent_parser): "--stdout", action="store_true", default=False, - help="Print plot location to stdout.", + help="Print plot specification to stdout.", ) plot_diff_parser.add_argument( "--no-csv-header", @@ -232,9 +232,6 @@ def add_parser(subparsers, parent_parser): plot_diff_parser.add_argument("--xlab", default=None, help="X axis title.") plot_diff_parser.add_argument("--ylab", default=None, help="Y axis title.") plot_diff_parser.add_argument( - "revisions", - nargs="*", - default=None, - help="Git revisions to plot from", + "revisions", nargs="*", default=None, help="Git commits to plot from", ) plot_diff_parser.set_defaults(func=CmdPlotDiff)