Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plots diff/show: caching is broken for files in legacy cache format #9727

Closed
skshetry opened this issue Jul 12, 2023 · 3 comments · Fixed by #9849
Closed

plots diff/show: caching is broken for files in legacy cache format #9727

skshetry opened this issue Jul 12, 2023 · 3 comments · Fixed by #9849
Assignees
@skshetry
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do product: VSCode Integration with VSCode extension regression Ohh, we broke something :-(

Comments

@skshetry
Copy link
Member 

git clone https://github.com/iterative/vscode-dvc-demo
cd vscode-dvc-demo
dvc plots diff
ls .dvc/cache -la
dvc plots diff

The plots diff refetches them from remote, and is not being cached.
See #9183.
@skshetry skshetry added bug Did we break something? regression Ohh, we broke something :-( labels Jul 12, 2023
@dberenbaum dberenbaum added the p1-important Important, aka current backlog of things to do label Jul 12, 2023
@dberenbaum dberenbaum added this to DVC Jul 12, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jul 12, 2023
@dberenbaum dberenbaum moved this from Backlog to Todo in DVC Aug 10, 2023
@dberenbaum
Copy link
Collaborator

@skshetry This is another outstanding 3.0 regression.

@skshetry skshetry self-assigned this Aug 15, 2023
@skshetry
Copy link
Member Author

Previously @efiop was against introducing caching built into dvc_data.fs.DataFileSystem.
It is a bit difficult to introspect the appropriate odb/cache from the outside. I'll try to look into this again.

@efiop, if you have any ideas?

@daavoo daavoo added the product: VSCode Integration with VSCode extension label Aug 15, 2023
@skshetry
Copy link
Member Author

I decided to look into adding support for caching to DataFileSystem.

@skshetry skshetry mentioned this issue Aug 16, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in DVC Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
bug Did we break something? p1-important Important, aka current backlog of things to do product: VSCode Integration with VSCode extension regression Ohh, we broke something :-(
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plots: fix caching of legacy format skshetry/dvc
3 participants
@dberenbaum @daavoo @skshetry