Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: more helpful error message on corrupted/invalid dvc.yaml #7787

Open
dberenbaum opened this issue May 19, 2022 · 4 comments
Open

plots: more helpful error message on corrupted/invalid dvc.yaml #7787

dberenbaum opened this issue May 19, 2022 · 4 comments
Labels
A: plots Related to the plots p3-nice-to-have It should be done this or next sprint

Comments

@dberenbaum
Copy link
Collaborator

When dvc.yaml is either corrupted or fails validation, dvc plots show/diff output shows DVC failed to load some plots for following revisions: workspace. There are a couple issues with this:

  • It makes it seem like the issue is with one or more of the plots, when it's really about the structure of dvc.yaml and may be completely unrelated to plots.
  • It makes it seem like some plots from that revision might still be shown, which isn't true.
  • It doesn't give any indication of how to fix it. Other commands like dvc repro give output about what failed like:
'./dvc.yaml' is invalid.

While scanning a simple key, in line 24, column 1
  24 dfdf

Could not find expected ':', in line 25, column 1
  25

For dvc plots show, can we show something similar?

For dvc plots diff, this might not make sense by default since there could be many revisions. However, it still seems like we could improve the message. For example, it could say something like Failed to read dvc.yaml for the following revisions (add -v to see errors): workspace.

@dberenbaum dberenbaum added the A: plots Related to the plots label May 19, 2022
@dberenbaum
Copy link
Collaborator Author

On second thought, should dvc plots show ever include DVC failed to load some plots for the following revisions? It is always operating in the current workspace, so mentioning revisions at all seems confusing.

@francisquintallauzon
Copy link

+1 on this issue. I am having the same issue with hint on resolution. We are considering using DVC as part of our MLOps tool stack, but this kind of issue (no/unclear error messages) is really a break on adoption for us.

@dberenbaum dberenbaum added the p3-nice-to-have It should be done this or next sprint label Mar 16, 2023
@serious-gist
Copy link

Is their any progress on this issue, we are currently facing this issue out of nowhere

@dberenbaum
Copy link
Collaborator Author

@serious-gist If you post the full output of what you are getting, we may be able to help resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots p3-nice-to-have It should be done this or next sprint
Projects
None yet
Development

No branches or pull requests

3 participants