Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp run: Results cannot be found if experiment name includes space #6652

Closed
lassepe opened this issue Sep 20, 2021 · 1 comment · Fixed by #6848
Closed

exp run: Results cannot be found if experiment name includes space #6652

lassepe opened this issue Sep 20, 2021 · 1 comment · Fixed by #6848
Labels
A: experiments Related to dvc exp bug Did we break something? p1-important Important, aka current backlog of things to do

Comments

@lassepe
Copy link

lassepe commented Sep 20, 2021

Bug Report

Description

When running an experiment with white space in the name, the resulting experiment does not show up in exp show later.

Reproduce

  1. `dvc exp run --name "some name": Experiments runs as expected.
  2. dvc exp show: Experiment is not listed.

Expected

I would expect that either

  • dvc exp run should refuse to assign names with white space in them,
  • or dvc exp show shows this experiment in the summary regardless of the white space in the name.

Environment information

Output of dvc doctor:

DVC version: 2.7.2 (pip)
---------------------------------
Platform: Python 3.7.10 on Linux-5.14.5-arch1-1-x86_64-with-arch
@karajan1001 karajan1001 added bug Did we break something? A: experiments Related to dvc exp labels Sep 20, 2021
@pmrowla
Copy link
Contributor

pmrowla commented Sep 21, 2021

For reference, the intended behavior is:

dvc exp run should refuse to assign names with white space in them,

Experiment names must be valid Git ref/branch names and cannot contain whitespace (https://git-scm.com/docs/git-check-ref-format)

@dberenbaum dberenbaum added the p1-important Important, aka current backlog of things to do label Sep 25, 2021
@efiop efiop added this to DVC Oct 18, 2021
@efiop efiop moved this to Backlog in DVC Oct 18, 2021
@pmrowla pmrowla moved this from Backlog to Todo in DVC Oct 19, 2021
Repository owner moved this from Todo to Done in DVC Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp bug Did we break something? p1-important Important, aka current backlog of things to do
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants