-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX of the stage:list command #5390
Comments
IMO:
p.s. for the record, a few other UI text enhancement suggestions can be found in #5282 (review). |
Sorry for being slow to respond here. What you have looks great to me. I have been hesitant to respond to the questions since I don't think adding another opinion will be that productive. What do you think about using this opportunity to outline some standards for what to expect for output generally? Hopefully, that might save time in the future with needing to gather UI feedback on every command, and the UI will be more consistent. This seems like one of many cases where the output is basically a table. There are at least 3 different output formats that I've seen for different dvc tables:
Questions on these:
Feel free to push back if any of this is too broad or not useful. I can also open a separate issue to not block this specific use case. |
Hybrid with a focus on piping, with I'd definitely extract all the secondary/generalized questions to a separate issue, if we're trying to decide on |
@skshetry I'm fine moving forward with the suggestions you and @jorgeorpinel have proposed here. As far as what to show for descriptions, we could potentially have the I'm not going to make a separate issue at the moment for the other questions I raised since we have enough other priorities, but I know you have been doing some research in these areas, so it would be great to hear anything you have found and any thoughts on UI design (doesn't have to be in this issue). |
To clarify above, it might be better to have separate fields for |
I should have introduced the
What should the order be? I still question why we need to make it machine-readable by default. 😄 With a longer form of output, we could provide more context here by default. |
👍
I liked the verbose pretty output you had before. No reason we can't still do that with a Since more consistent UI is a goal, making machine-readable the default is probably a good idea since it might be important for other commands, and it keeps the output somewhat simple, which should make it easier to maintain consistency. |
I would also distinguish |
Closing as not planned. |
We introduced
dvc stage list
command for 2 reasons:Both of which are mentioned as a pain point in #3743.
I initially implemented it on #5191 as a POC with a rich UI and a format that can accommodate more information, but removed it later to the following format:
As the above format is one-liner, it is hard to add any more information.
There have been a few questions that are up for debate:
desc
field (right now it does) in thedvc.yaml
file?etc.
It's a bit hard to express the full context around it as everyone has there contradictory view to it and what they expect here.
Please ask if there's anything regarding implementation that needs to be clarified, as most of the implementations right now are up for debate/questionable, so I am leaving it for clarity.
cc @dberenbaum @shcheklein @dmpetrov
The text was updated successfully, but these errors were encountered: