Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: improve message for overlapping outputs #4529

Closed
shcheklein opened this issue Sep 4, 2020 · 5 comments · Fixed by #5385
Closed

add: improve message for overlapping outputs #4529

shcheklein opened this issue Sep 4, 2020 · 5 comments · Fixed by #5385
Labels
hacktoberfest p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@shcheklein
Copy link
Member

shcheklein commented Sep 4, 2020

Bug Report

Please provide information about your setup

Output of dvc version:

$ dvc version
DVC version: 1.6.6+79e8e4
---------------------------------
Platform: Python 3.8.5 on macOS-10.15.6-x86_64-i386-64bit
Supports: All remotes
Cache types: reflink, hardlink, symlink
Cache directory: apfs on /dev/disk1s1
Workspace directory: apfs on /dev/disk1s1
Repo: dvc, git

Reproduce

Run dvc add on a directory with some data twice and get something like:

(.env) √ Projects/test-dvc % dvc add data
Stage is cached, skipping

Problem

stage term is not applicable here. This message should be fixed/changed. #5385

Bonus

Error message on the overlapping data should be avoiding term output. Instead we should be using directory or file. Also should we recommend dvc add data instead of commit (might be easier for users, no need to learn a new command).

(.env) √ Projects/test-dvc % dvc add data/file3
Adding...
ERROR: Cannot add 'data/file3', because it is overlapping with other DVC tracked output: 'data'.
To include 'data/file3' in 'data', run 'dvc commit data.dvc'
@efiop efiop added p1-important Important, aka current backlog of things to do ui user interface / interaction p2-medium Medium priority, should be done, but less important and removed p1-important Important, aka current backlog of things to do labels Sep 7, 2020
@gsvolt
Copy link
Contributor

gsvolt commented Sep 27, 2020

@shcheklein - may I work on this issue?

@shcheklein
Copy link
Member Author

@gsvolt yes! absolutely, feel free to take it! thanks 🙏

@DiPaolo
Copy link
Contributor

DiPaolo commented Jan 8, 2021

Is it fine to use a message similar I've tried to use at #5236? Something like this:
WARNING 'data' is already under DVC control

If it's okay, I will fix the issue soon.

@efiop efiop changed the title add: wrong message when data is already tracked add: improve message for overlapping outputs Feb 2, 2021
@efiop
Copy link
Contributor

efiop commented Feb 2, 2021

Repurposing for the "bonus"

@efiop efiop reopened this Feb 2, 2021
@skshetry
Copy link
Member

skshetry commented Jan 3, 2023

Note that the message these days says something like following:

ERROR: bad DVC file name 'data/file3.dvc' is git-ignored.

@mattseddon mattseddon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants