Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/etc: better handle file tracking crashes [qa] #4349

Closed
jorgeorpinel opened this issue Aug 6, 2020 · 2 comments
Closed

add/etc: better handle file tracking crashes [qa] #4349

jorgeorpinel opened this issue Aug 6, 2020 · 2 comments
Labels
enhancement Enhances DVC

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Aug 6, 2020

Report

DVC moves data files to the cache and changes their file permissions (to 444), but if anything goes wrong (e.g. dvc add a file owned by another user, so DVC can't change the perms) the process crashes (some error is thrown) but not before disappearing the data file.

These complex operations should probably behave like transaction, or have some sort of backup mechanism to roll back the caching of the file if any error is thrown.

Please provide information about your setup

DVC 1.3
(Tried on Linux)

Additional Information (if any):

Context: https://discord.com/channels/485586884165107732/485596304961962003/740974097063739423 (starts before that)

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Aug 6, 2020
@jorgeorpinel jorgeorpinel added the enhancement Enhances DVC label Aug 6, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Aug 6, 2020
@jorgeorpinel jorgeorpinel changed the title add/etc: better handle tracking files owned by other users add/etc: better handle file tracking crashes Aug 6, 2020
@jorgeorpinel jorgeorpinel changed the title add/etc: better handle file tracking crashes add/etc: better handle file tracking crashes [qa] Aug 6, 2020
@efiop
Copy link
Contributor

efiop commented Aug 7, 2020

Duplicate of #4348

@efiop efiop marked this as a duplicate of #4348 Aug 7, 2020
@efiop efiop closed this as completed Aug 7, 2020
@jorgeorpinel
Copy link
Contributor Author

Thanks. I looked for key words "add owner permissions" and didn't find any issues so opened this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

No branches or pull requests

2 participants