Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML no included as a dependency in the conda build for dvc #4318

Closed
yfarjoun opened this issue Aug 2, 2020 · 2 comments · Fixed by conda-forge/dvc-feedstock#133
Closed
Assignees
Labels
build Issues/features related to building dvc install packages. p0-critical Critical issue. Needs to be fixed ASAP.

Comments

@yfarjoun
Copy link
Contributor

yfarjoun commented Aug 2, 2020

when attempting to install dvc using the conda build dvc=1.3.1=py37hc8dfbb8_0 I ended up with a non working dvc as it was missing the toml package, as reported by the error:

$ dvc
<SNIP>
    import toml
ModuleNotFoundError: No module named 'toml'

It seems that toml wasn't added to the prerequisites of the dvc conda build.

I would like to suggest two things:

  1. Add toml (v0.10.1 seems to work) to the conda recipe.
  2. Add a test that creates a conda environment for dvc and tests it as part of the CI so that this doesn't happen again and that the recipes remain uptodate.

THANKS!

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Aug 2, 2020
@efiop
Copy link
Contributor

efiop commented Aug 2, 2020

@yfarjoun Coul you please show full traceback?

@yfarjoun
Copy link
Contributor Author

yfarjoun commented Aug 2, 2020

$ dvc
Traceback (most recent call last):
  File "/ROOT/bin/dvc", line 7, in <module>
    from dvc.main import main
  File "/ROOT/lib/python3.7/site-packages/dvc/main.py", line 6, in <module>
    from dvc import analytics
  File "/ROOT/lib/python3.7/site-packages/dvc/analytics.py", line 17, in <module>
    from dvc.repo import Repo
  File "/ROOT/lib/python3.7/site-packages/dvc/repo/__init__.py", line 9, in <module>
    from dvc.dvcfile import PIPELINE_FILE, Dvcfile, is_valid_filename
  File "/ROOT/lib/python3.7/site-packages/dvc/dvcfile.py", line 9, in <module>
    from dvc.stage import serialize
  File "/ROOT/lib/python3.7/site-packages/dvc/stage/__init__.py", line 8, in <module>
    import dvc.dependency as dependency
  File "/ROOT/lib/python3.7/site-packages/dvc/dependency/__init__.py", line 11, in <module>
    from dvc.dependency.param import ParamsDependency
  File "/ROOT/lib/python3.7/site-packages/dvc/dependency/param.py", line 5, in <module>
    import toml
ModuleNotFoundError: No module named 'toml'

@efiop efiop added build Issues/features related to building dvc install packages. p0-critical Critical issue. Needs to be fixed ASAP. labels Aug 2, 2020
@efiop efiop self-assigned this Aug 2, 2020
@triage-new-issues triage-new-issues bot removed triage Needs to be triaged labels Aug 2, 2020
@skshetry skshetry mentioned this issue Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues/features related to building dvc install packages. p0-critical Critical issue. Needs to be fixed ASAP.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants