Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag: do not include DVC-tracked dependencies as stages #4058

Closed
shcheklein opened this issue Jun 17, 2020 · 1 comment
Closed

dag: do not include DVC-tracked dependencies as stages #4058

shcheklein opened this issue Jun 17, 2020 · 1 comment
Labels
p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@shcheklein
Copy link
Member

DVC version:

DVC version: 1.0.0a10+4042d5
Python version: 3.7.7
Platform: Darwin-19.4.0-x86_64-i386-64bit
Binary: False
Package: None
Supported remotes: azure, gdrive, gs, hdfs, http, https, s3, ssh, oss
Cache: reflink - supported, hardlink - supported, symlink - supported
Repo: dvc, git

Reproduce:

clone the https://github.com/shcheklein/example-get-started, run dvc dag

Issue:

We print something like this:

   +-------------------+
    | data/data.xml.dvc  |
    +------------------+
              *
              *
              *
         +---------+
         | prepare   |
         +---------+
              *
              *
              *
        +-----------+
        | featurize    |
        +-----------+
         **        **
       **            *
      *               **
+-------+             *
|   train   |             **
+-------+            *
         **        **
           **    **
             *  *
        +----------+
        | evaluate   |
        +----------+

It's not clear why we consider data dependency a stage. Why do we consider only DVC-tracked or imported deps as stages, not any other deps?

Suggestion is to avoid showing any dependencies (at least in the default view) and focus on stages only.

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jun 17, 2020
@efiop efiop added p2-medium Medium priority, should be done, but less important ui user interface / interaction labels Jun 17, 2020
@triage-new-issues triage-new-issues bot removed triage Needs to be triaged labels Jun 17, 2020
@efiop
Copy link
Contributor

efiop commented Dec 8, 2023

Closing as stale.

@efiop efiop closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

2 participants