Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking type should not be committed to git #3697

Closed
drorata opened this issue Apr 29, 2020 · 4 comments
Closed

Linking type should not be committed to git #3697

drorata opened this issue Apr 29, 2020 · 4 comments
Labels
awaiting response we are waiting for your reply, please respond! :) feature request Requesting a new feature p2-medium Medium priority, should be done, but less important

Comments

@drorata
Copy link

drorata commented Apr 29, 2020

Consider the case that a project is cloned on two different platform, one which supports reflinks and the other only supports copying. Currently, dvc config cache.type copy would be committed to git and be used on both systems although one of them can enjoy a much smarter linking.

In other words, the cache type (and maybe other configurations) are local to the environment and should not be part of the .dvc/config which is committed to git.

Ref

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Apr 29, 2020
@pared pared added the feature request Requesting a new feature label Apr 29, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Apr 29, 2020
@pared pared added the p2-medium Medium priority, should be done, but less important label Apr 29, 2020
@efiop
Copy link
Contributor

efiop commented Apr 29, 2020

@drorata You could use .dvc/config.local for that. Just use --local flag when configuring your link type. Works for other config options too.

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Apr 29, 2020
@drorata
Copy link
Author

drorata commented Apr 29, 2020

That makes a lot of sense! Thanks for the pointer. Maybe it is worthy to mention in the docs of cache.type that it is recommended to use the --local flag for the config?

@shcheklein
Copy link
Member

@drorata there is an even simpler solution to this, I believe. You can set a comma separated list of cache types - DVC'll be trying them one by one. E.g.:

reflink,copy - means try reflinks, if they are not available, go with copy.

You can combine any link types like this.

@efiop
Copy link
Contributor

efiop commented Jun 3, 2020

Closing. Docs issue iterative/dvc.org#1368 . Thanks again for the feedback @drorata !

@efiop efiop closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response we are waiting for your reply, please respond! :) feature request Requesting a new feature p2-medium Medium priority, should be done, but less important
Projects
None yet
Development

No branches or pull requests

4 participants