Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use **kwargs instead of very long function declarations #3612

Closed
pmrowla opened this issue Apr 9, 2020 · 1 comment
Closed

refactor: use **kwargs instead of very long function declarations #3612

pmrowla opened this issue Apr 9, 2020 · 1 comment
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring

Comments

@pmrowla
Copy link
Contributor

pmrowla commented Apr 9, 2020

should we start using **kwargs @pmrowla @efiop ? it seems we have to change a lot of method just to pass one arguments, and it's not very scalable - not ideal to have functions with 9 args?

Originally posted by @shcheklein in #3600

Any commands and functions that use remote status (i.e. push/pull/fetch/gc/status) require passing 9+ args through multiple function calls in repo/cloud/remote/etc. Would be much cleaner to just use **kwargs and document the expected parameters at the top level function declarations (most of these functions do not currently have docstrings).

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Apr 9, 2020
@pmrowla pmrowla added the refactoring Factoring and re-factoring label Apr 9, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Apr 9, 2020
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Apr 20, 2020
@efiop
Copy link
Contributor

efiop commented Oct 8, 2021

Closing as stale

@efiop efiop closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring
Projects
None yet
Development

No branches or pull requests

2 participants