Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc metrics add: should it dvc add untracked files? #3606

Closed
jorgeorpinel opened this issue Apr 7, 2020 · 3 comments · Fixed by #3584
Closed

dvc metrics add: should it dvc add untracked files? #3606

jorgeorpinel opened this issue Apr 7, 2020 · 3 comments · Fixed by #3584
Labels
discussion requires active participation to reach a conclusion enhancement Enhances DVC

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Apr 7, 2020

I propose dvc metrics add, when used with an untracked file, automatically creates the orphan DVC-stage for it (calling dvc add under the hood) instead of

λ dvc metrics add un-tracked.file
ERROR: failed to add metric file 'metric' - Unable to find DVC-file with output 'metric'
@jorgeorpinel jorgeorpinel added enhancement Enhances DVC discussion requires active participation to reach a conclusion labels Apr 7, 2020
@efiop
Copy link
Contributor

efiop commented Apr 14, 2020

Oops, forgot to post the comment that this is going to happen after multistage dvcfile, as we will pretty much decouple metrics from the rest of the things. So you would be able to

metrics:
    - mymetrics.json
stages:
  ....

in your pipeline file.

@jorgeorpinel
Copy link
Contributor Author

Sounds good. But is the multistage DVC-file change going to existing commands in a non-backward compatible way so that this request will become outdated? Otherwise maybe we should still considered doing this separately.

@efiop
Copy link
Contributor

efiop commented Apr 15, 2020

Yes, it will become outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion requires active participation to reach a conclusion enhancement Enhances DVC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants