Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc: -c works without scope specifier (-w,a,T etc) #3489

Closed
skshetry opened this issue Mar 17, 2020 · 0 comments · Fixed by #3493
Closed

gc: -c works without scope specifier (-w,a,T etc) #3489

skshetry opened this issue Mar 17, 2020 · 0 comments · Fixed by #3493
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do

Comments

@skshetry
Copy link
Member

skshetry commented Mar 17, 2020 •
edited
Loading

As the title says, dvc gc -c works without -w/-T/-a specifiers (i.e. by default, it assumes -w).
It'd be good to only get in action when those specifiers are mentioned for dvc gc -c.

Refs:

Discord discussion
#3363 made it mandatory to require use of flags.
@skshetry skshetry added enhancement Enhances DVC p1-important Important, aka current backlog of things to do discussion requires active participation to reach a conclusion labels Mar 17, 2020
@skshetry skshetry changed the title gc: -c also removes from local cache gc: -c works without scope specifier (-w, -a, -T or --all-commits) Mar 17, 2020
@skshetry skshetry changed the title gc: -c works without scope specifier (-w, -a, -T or --all-commits) gc: -c works without scope specifier (-w,a,T etc) Mar 17, 2020
@skshetry skshetry added bug Did we break something? and removed discussion requires active participation to reach a conclusion enhancement Enhances DVC labels Mar 17, 2020
@skshetry skshetry mentioned this issue Mar 17, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gc: do not work without specifier when using -c flag skshetry/dvc
1 participant
@skshetry