Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored exception in destructor when pushing to ssh remote #3248

Closed
byaka opened this issue Jan 28, 2020 · 13 comments
Closed

Ignored exception in destructor when pushing to ssh remote #3248

byaka opened this issue Jan 28, 2020 · 13 comments
Assignees
Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. ui user interface / interaction

Comments

@byaka
Copy link

byaka commented Jan 28, 2020

DVC version 0.82.3
Platform Linux Ubuntu 18.04
Installed with pip3

Inited new repo and added some files to dvc, now im try to push them.

user@dev5:~/projects/recsys_similar_new$ dvc remote list --global
myremote	ssh://[email protected]/srv/dvc/storage
user@dev5:~/projects/recsys_similar_new$ dvc push -r myremote
Everything is up to date.                                                                                                                                 
Exception ignored in: <bound method Pool.__del__ of <dvc.remote.pool.Pool object at 0x7f7594a35f98>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/dvc/remote/pool.py", line 42, in __del__
  File "/usr/local/lib/python3.6/dist-packages/dvc/remote/pool.py", line 46, in close
  File "/usr/local/lib/python3.6/dist-packages/dvc/remote/ssh/connection.py", line 59, in close
  File "/usr/local/lib/python3.6/dist-packages/paramiko/sftp_client.py", line 195, in close
  File "/usr/local/lib/python3.6/dist-packages/paramiko/channel.py", line 666, in close
  File "/usr/local/lib/python3.6/dist-packages/paramiko/channel.py", line 1255, in _close_internal
  File "/usr/local/lib/python3.6/dist-packages/paramiko/channel.py", line 1246, in _send_eof
  File "/usr/local/lib/python3.6/dist-packages/paramiko/message.py", line 232, in add_int
TypeError: 'NoneType' object is not callable
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jan 28, 2020
@efiop efiop added bug Did we break something? p1-important Important, aka current backlog of things to do labels Jan 28, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Jan 28, 2020
@efiop
Copy link
Contributor

efiop commented Jan 28, 2020

Hi @byaka !

dvc push succeeded, but there has been a hickup when the interpreter was shutting down, that doesn't really affect the functionality but is indeed really ugly. We will take a closer look ASAP.

Thanks for the feedback!

@byaka
Copy link
Author

byaka commented Jan 28, 2020

@efiop ah, ok, so this not a fatal error. thx for answer!

@byaka byaka changed the title Cant push to ssh remote - paramiko exception Ignored exception in destructor when pushing to ssh remote Jan 28, 2020
@efiop
Copy link
Contributor

efiop commented Jan 28, 2020

@byaka Btw, are you able to reliably reproduce? Or does it happen just once in a while for you?

@byaka
Copy link
Author

byaka commented Jan 29, 2020

no, it happens for me on every push, pull or status but only on servers where dvc installed via pip
on my centos servers dvc installed via yam and this problem not happens

@efiop
Copy link
Contributor

efiop commented Jan 29, 2020

@byaka yum packages are a bit different, they are built with pyinstaller, so it might be swallowing such hickups. Thanks for clarifying! We will try to take look soon. Let us know if you'll have any other issues 🙂

@efiop
Copy link
Contributor

efiop commented Jan 30, 2020

For the record: another user is experiencing the same issue https://discordapp.com/channels/485586884165107732/485596304961962003/672421181185589275

@efiop efiop added the ui user interface / interaction label Jan 30, 2020
@efiop efiop added p0-critical Critical issue. Needs to be fixed ASAP. p1-important Important, aka current backlog of things to do and removed p1-important Important, aka current backlog of things to do p0-critical Critical issue. Needs to be fixed ASAP. labels Jan 30, 2020
@e3bo
Copy link
Contributor

e3bo commented Jan 31, 2020

I'm also experiencing this issue.

Ubuntu 19.04 and Arch Linux
DVC version 0.82.6.
Installed via pip

Additionally, I have gotten

Exception ignored in: <function Pool.__del__ at 0x7fb429b86e50>                                                    
Traceback (most recent call last):                                                                                 
 File "/home/eamon/venv2/lib/python3.8/site-packages/dvc/remote/pool.py", line 42, in __del__                     
 File "/home/eamon/venv2/lib/python3.8/site-packages/dvc/remote/pool.py", line 46, in close                       
 File "/home/eamon/venv2/lib/python3.8/site-packages/dvc/remote/ssh/connection.py", line 59, in close
 File "/home/eamon/venv2/lib/python3.8/site-packages/paramiko/sftp_client.py", line 195, in close
 File "/home/eamon/venv2/lib/python3.8/site-packages/paramiko/channel.py", line 671, in close
 File "/home/eamon/venv2/lib/python3.8/site-packages/paramiko/transport.py", line 1846, in _send_user_message
 AttributeError: 'NoneType' object has no attribute 'time'

following dvc pull. But this does not occur every time I run that command.

@efiop efiop added p0-critical Critical issue. Needs to be fixed ASAP. and removed p1-important Important, aka current backlog of things to do labels Feb 2, 2020
@efiop efiop self-assigned this Feb 2, 2020
@efiop
Copy link
Contributor

efiop commented Feb 2, 2020

For the record: can reproduce with paramiko 2.5.0, 2.6.0 and 2.7.1, so it is something else that broke. Looking into it. dvc 0.80.0 indeed doesn't have that bug.

@efiop
Copy link
Contributor

efiop commented Feb 2, 2020

Guys, thanks for the feedback! The issue is fixed by #3274. We are releasing new version right now.

@efiop efiop closed this as completed Feb 2, 2020
@efiop
Copy link
Contributor

efiop commented Feb 3, 2020

@byaka @e3bo @aprimostka Guys, 0.82.8 is out. Please upgrade and give it a try. Let us know if the issue still persists or not 🙂

@byaka
Copy link
Author

byaka commented Feb 3, 2020

@efiop thank u and dvc-team, new version works like a charm

@aprimostka
Copy link

I had not time to fully test but first run gone smoothly

@e3bo
Copy link
Contributor

e3bo commented Feb 4, 2020

Upgrading to 82.8 from 82.6 resolved the issue for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

4 participants