Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: flatten the test structure / merg unit with functional #3243

Closed
ghost opened this issue Jan 27, 2020 · 1 comment
Closed

tests: flatten the test structure / merg unit with functional #3243

ghost opened this issue Jan 27, 2020 · 1 comment
Labels
discussion requires active participation to reach a conclusion testing Related to the tests and the testing infrastructure

Comments

@ghost
Copy link

ghost commented Jan 27, 2020

I see no advantage in distinguishing between unit and functional tests.

Now that migratation to pytest is happening, tests are getting more slim and descriptive (thanks to fixtures and helpers), we could fit all the tests of a module in a single file test_<module>.py.

@ghost ghost added testing Related to the tests and the testing infrastructure discussion requires active participation to reach a conclusion labels Jan 27, 2020
@efiop
Copy link
Contributor

efiop commented Jan 30, 2020

@MrOutis By definition, func and unit tests serve different purposes and have different requirements. Mixing those together will just result in giant files with mixed test contexts, which is a terrible idea. We will get integration tests at some point too, which will add to the chaos if we don't keep them separate. Migration to pytest has nothing to do here, it is just a test framework.

There is no need to invent the wheel here, separation of func/int/unit tests is a standard best practice in any well-maintained project. Sure, our current test suite is a bit vague in terms of separating contexts(especially because of legacy func tests), but there is no need to make it worse 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion requires active participation to reach a conclusion testing Related to the tests and the testing infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant