Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use ABC's for Remote base class instead of a plain object #3110

Closed
ghost opened this issue Jan 11, 2020 · 2 comments
Closed

refactor: use ABC's for Remote base class instead of a plain object #3110

ghost opened this issue Jan 11, 2020 · 2 comments
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring

Comments

@ghost
Copy link

ghost commented Jan 11, 2020

This would make the interface more explicit.

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jan 11, 2020
@ghost ghost added the refactoring Factoring and re-factoring label Jan 11, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Jan 11, 2020
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Jan 11, 2020
@Suor
Copy link
Contributor

Suor commented Jan 18, 2020

Not a big fan. It won't make our code any significantly easier to read, we are not writing Java after all.

However, there are possible big gains from separating remote and cache functionality.

@ghost
Copy link
Author

ghost commented Feb 12, 2020

Let's close it then, @Suor , I also think it is better to rethink remote and cache 👀

@ghost ghost closed this as completed Feb 12, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring
Projects
None yet
Development

No branches or pull requests

2 participants