Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline show: use pager instead of rendering ourselves #2807

Closed
efiop opened this issue Nov 17, 2019 · 1 comment · Fixed by #2815
Closed

pipeline show: use pager instead of rendering ourselves #2807

efiop opened this issue Nov 17, 2019 · 1 comment · Fixed by #2815
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@efiop
Copy link
Contributor

efiop commented Nov 17, 2019

After many discussions #2420 #2768 about why our --ascii rendering is bad, I've finally remembered 🤦‍♂ that I should probably check how git does it and, lo and behold, git does use less https://github.com/git/git/blob/v2.24.0/pager.c#L8 or whatever is configured to show you things like git log instead of rendering it by itself using ncurses. We should do the same.
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Nov 17, 2019
@efiop efiop added the enhancement Enhances DVC label Nov 17, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 17, 2019
@efiop efiop added triage Needs to be triaged ui user interface / interaction labels Nov 17, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 17, 2019
@efiop efiop added p2-medium Medium priority, should be done, but less important triage Needs to be triaged labels Nov 17, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 17, 2019
This was referenced Nov 17, 2019
Closed
Closed
Closed
Closed
@ghost
Copy link

ghost commented Nov 19, 2019

I'll take it. @efiop If you have any hints to make work more efficient, I'll grateful :)

@ghost ghost mentioned this issue Nov 19, 2019
Merged
3 tasks
@weekly-digest weekly-digest bot mentioned this issue Nov 24, 2019
Closed
@ghost ghost mentioned this issue Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dvc/dagascii: Use pager instead of AsciiCanvas._do_draw
1 participant
@efiop