Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress when collecting directories with giant number of files #2770

Closed
efiop opened this issue Nov 10, 2019 · 3 comments
Closed

progress when collecting directories with giant number of files #2770

efiop opened this issue Nov 10, 2019 · 3 comments
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@efiop
Copy link
Contributor

efiop commented Nov 10, 2019

Was adding one particularly large dataset of a few hundred G with lots of files and saw dvc appear to be frozen when it was collecting all the files to start adding them around https://github.com/iterative/dvc/blob/0.67.0/dvc/remote/base.py#L196 . Would be nice to either speed it up so it is not noticable(which I really doubt is possible with that amount of files to walk through) or at least provide a progress bar to keep the user updated.
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Nov 10, 2019
@efiop efiop added enhancement Enhances DVC ui user interface / interaction labels Nov 10, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Nov 10, 2019
@efiop efiop added the p2-medium Medium priority, should be done, but less important label Nov 10, 2019
@efiop efiop changed the title add progress bar when collecting giant directories progress when collecting directories with giant number of files Nov 10, 2019
@shcheklein
Copy link
Member

@efiop I think it's part of the #2546 ? see, the large dirs progress bar hanging checkbox and the relevant comment there.

@efiop
Copy link
Contributor Author

efiop commented Nov 10, 2019

@shcheklein Not seeing that checkbox there. Could you clarify?

@efiop
Copy link
Contributor Author

efiop commented Nov 10, 2019

@shcheklein You meant #2699 . Got it.

@efiop efiop closed this as completed Nov 10, 2019
@shcheklein shcheklein mentioned this issue Nov 10, 2019
Closed
7 tasks
@weekly-digest weekly-digest bot mentioned this issue Nov 17, 2019
Closed
@casperdcl casperdcl mentioned this issue Nov 26, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shcheklein @efiop