Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage: rename force argument to unpersist #2416

Closed
ghost opened this issue Aug 20, 2019 · 0 comments
Closed

stage: rename force argument to unpersist #2416

ghost opened this issue Aug 20, 2019 · 0 comments
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring

Comments

@ghost
Copy link

ghost commented Aug 20, 2019

In stage.remove_outs there's a parameter force that is used to remove "persistent outputs":

    def remove_outs(self, ignore_remove=False, force=False):
        """Used mainly for `dvc remove --outs` and :func:`Stage.reproduce`."""
        for out in self.outs:
            if out.persist and not force:
                out.unprotect()
            else:
                logger.debug(
                    "Removing output '{out}' of '{stage}'.".format(
                        out=out, stage=self.relpath
                    )
                )
                out.remove(ignore_remove=ignore_remove)

I think unpersist makes more sense in this case.

@ghost ghost added the refactoring Factoring and re-factoring label Aug 20, 2019
@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Aug 20, 2019
@efiop efiop closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-nice-to-have It should be done this or next sprint refactoring Factoring and re-factoring
Projects
None yet
Development

No branches or pull requests

1 participant