Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get: disable state lock and .dvc/lock to be able to deploy on nfs #2135

Closed
efiop opened this issue Jun 17, 2019 · 4 comments · Fixed by #2323
Closed

get: disable state lock and .dvc/lock to be able to deploy on nfs #2135

efiop opened this issue Jun 17, 2019 · 4 comments · Fixed by #2323
Assignees
@pared
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research

Comments

@efiop
Copy link
Contributor

efiop commented Jun 17, 2019 •
edited
Loading

Due to #1918 , our dvc get command won't be able to deploy on nfs. Since we are creating a temporary repo for dvc get and using by ourselves alone, we could simply disable all the locks to workaround that limitation. Another option would be to simply fix #1918 🙂
@efiop efiop added the bug Did we break something? label Jun 17, 2019
@efiop efiop mentioned this issue Jun 17, 2019
Merged
10 tasks
@shcheklein shcheklein mentioned this issue Jun 21, 2019
Merged
@shcheklein shcheklein added the p1-important Important, aka current backlog of things to do label Jul 22, 2019
@efiop efiop changed the title pkg: get: disable state lock and .dvc/lock to be able to deploy on nfs get: disable state lock and .dvc/lock to be able to deploy on nfs Jul 24, 2019
@efiop
Copy link
Contributor Author

efiop commented Jul 24, 2019

Related #1918

@efiop
Copy link
Contributor Author

efiop commented Jul 24, 2019

The .dvc/lock is not an issue, as we are not using it at all in get. But sqlite's lock is, so we need to figure out if we can disable it.

@efiop efiop added the research label Jul 24, 2019
@efiop
Copy link
Contributor Author

efiop commented Jul 24, 2019

Or maybe we could simply replace self.state with StateBase and be done with it.

@efiop
Copy link
Contributor Author

efiop commented Jul 24, 2019 •
edited
Loading

From @Suor might be worth just replacing repo.state with StateBase in get()'s logic. And we should leave a proper comment in the code about it.

@pared pared mentioned this issue Jul 25, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pared pared

Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get: use StateBase pared/dvc
3 participants
@shcheklein @efiop @pared