Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dvc pull recursive option UX #1705

Closed
shcheklein opened this issue Mar 9, 2019 · 2 comments
Closed

Improve dvc pull recursive option UX #1705

shcheklein opened this issue Mar 9, 2019 · 2 comments
Labels
p3-nice-to-have It should be done this or next sprint ui user interface / interaction

Comments

@shcheklein
Copy link
Member

From discord: https://discordapp.com/channels/485586884165107732/519377613110902784/553649896264040505

And the follow up:

yes! I think so. basically -r is just a way to change list of targets specified
and in case of dvc pull targets are DVC files, not data files
so, when you specified it it was probably looking for DVC files in the directory. I'm not sure why did it write anything at all though.
Also, I would write an error message/warning if -R is specified and target is not directory
so there is def some space for improvement
@shcheklein
Copy link
Member Author

I would check and implement the same warnings if needed for other commands that accept DVC files and sometimes directories (metrics show -R?). At least in case when -a or -T are not specified it should print a warning if path is not a directory?

@efiop efiop added ui user interface / interaction p3-nice-to-have It should be done this or next sprint labels Jul 23, 2019
@skshetry
Copy link
Member

Closing due to lack of activity. It's a nice to have, but these days we support pulling files just by path: dvc pull data/subdir, etc.

@skshetry skshetry closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-nice-to-have It should be done this or next sprint ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

3 participants