From 5d58d8bf1953bc896219198d8db44442f2ccbcf9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 6 Jun 2022 18:16:15 -0400 Subject: [PATCH 01/11] Use link check from the CLI instead of an action --- .github/workflows/link-check-deploy.yml | 34 ++++--------------------- 1 file changed, 5 insertions(+), 29 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 481f0ca668..d0c0047112 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -12,37 +12,13 @@ jobs: github.event.deployment.ref != 'master' && github.event.deployment_status.state == 'success' steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - - id: build_check - uses: LouisBrunner/checks-action@v1.0.0 + - uses: actions/setup-node@v3 with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Report - status: queued + node-version: 16 + cache: 'yarn' - name: Run Link Check id: check - uses: iterative/link-check.action@v0.11 - with: - diff: master - configFile: config/link-check/config.yml - rootURL: '${{ github.event.deployment.payload.web_url }}' - output: checksAction - - uses: LouisBrunner/checks-action@v1.0.0 - if: ${{ success() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ steps.build_check.outputs.check_id }} - status: completed - conclusion: ${{ steps.check.outputs.conclusion }} - output: ${{ steps.check.outputs.output }} - - uses: LouisBrunner/checks-action@v1.0.0 - if: ${{ failure() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ steps.build_check.outputs.check_id }} - status: completed - conclusion: failure - output: >- - {"summary": "The Link Check script had an error!"} + run: yarn link-check-diff -f From 3aaf1f80f551d8417625fe7ad3416b6899bfb4a3 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 6 Jun 2022 18:27:58 -0400 Subject: [PATCH 02/11] Remove deployment trigger --- .github/workflows/link-check-deploy.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index d0c0047112..95c696c6a7 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -2,14 +2,12 @@ name: Check new links against deployment # This workflow "triggers" and skips on deployment because GitHub Actions / # Checks refuses to show the check on deployment_status on: - - deployment - deployment_status jobs: run: - name: Initialize + name: Link Check runs-on: ubuntu-latest if: - github.event.deployment.ref != 'master' && github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v3 @@ -19,6 +17,6 @@ jobs: with: node-version: 16 cache: 'yarn' - - name: Run Link Check + - name: Check id: check run: yarn link-check-diff -f From 9f7026873599540b6f6f75e4425ed971f918413d Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 6 Jun 2022 18:53:01 -0400 Subject: [PATCH 03/11] Use deployment URL --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 95c696c6a7..ad324ebee0 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -19,4 +19,4 @@ jobs: cache: 'yarn' - name: Check id: check - run: yarn link-check-diff -f + run: 'yarn link-check-diff -f -r "${{ github.event.deployment.payload.web_url }}"' From 3889cfef1aceffb5585a6a807d50220fb4561280 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 6 Jun 2022 18:53:16 -0400 Subject: [PATCH 04/11] Don't use cache because it doesn't work on deployment_status --- .github/workflows/link-check-deploy.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index ad324ebee0..aa31d52e5e 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -16,7 +16,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - cache: 'yarn' - name: Check id: check run: 'yarn link-check-diff -f -r "${{ github.event.deployment.payload.web_url }}"' From 8d0b98d15f72118dfcfed7ca2b17ba9a88e5d953 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 00:51:07 -0400 Subject: [PATCH 05/11] Add install step --- .github/workflows/link-check-deploy.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index aa31d52e5e..5d1b7f4b86 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -16,6 +16,8 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - name: Check + - name: Install + run: 'yarn add repo-link-check' + - name: Check Links id: check run: 'yarn link-check-diff -f -r "${{ github.event.deployment.payload.web_url }}"' From 777e7eff0d2690f976a2e8ecf723a6b82018ac1b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 15:50:49 -0400 Subject: [PATCH 06/11] Use npx --- .github/workflows/link-check-deploy.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 5d1b7f4b86..266aa76d42 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -16,8 +16,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - name: Install - run: 'yarn add repo-link-check' - name: Check Links id: check - run: 'yarn link-check-diff -f -r "${{ github.event.deployment.payload.web_url }}"' + run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}"' From 6b1373db30939586e70ed00fb6725f049b411a2c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 15:58:47 -0400 Subject: [PATCH 07/11] Add test links --- content/blog/2022-05-24-MLEM-release.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/content/blog/2022-05-24-MLEM-release.md b/content/blog/2022-05-24-MLEM-release.md index 03677a1870..e606137521 100644 --- a/content/blog/2022-05-24-MLEM-release.md +++ b/content/blog/2022-05-24-MLEM-release.md @@ -26,6 +26,16 @@ tags: With MLEM ML teams get a single tool to **run your models anywhere** that strikes to cover all model productionization scenarios you have. +[full good link](https://www.google.com) [short good link](www.google.com) +[shorter good link](google.com) +[full bad link](https://www.google.com/adddddbnbe) +[short bad link](www.google.com/adddddbnbe) +[shorter bad link](google.com/adddddbnbe) + +https://www.google.com + +https://www.google.com/adbbne + MLEM enables this via **model metadata codification**: saving all information that is required to use a model later. Besides packaging a model for deployment it can be used for many things, including search and documentation. To make it From 5f4ba6b4784911f821f91c615ba95b996d5977d3 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 16:47:55 -0400 Subject: [PATCH 08/11] Use summary --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 266aa76d42..ed428e8a29 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -18,4 +18,4 @@ jobs: node-version: 16 - name: Check Links id: check - run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}"' + run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}" >> $GITHUB_STEP_SUMMARY' From fb4bd1b39bdbd90e9afac1ab71a5348c428cbd89 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 16:58:55 -0400 Subject: [PATCH 09/11] Remove name and id --- .github/workflows/link-check-deploy.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index ed428e8a29..0c41d5dbf4 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -16,6 +16,4 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - name: Check Links - id: check - run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}" >> $GITHUB_STEP_SUMMARY' + - run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}" >> $GITHUB_STEP_SUMMARY' From d62a338f4572a7905b476b870e50f472cb28c5a2 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 18:03:03 -0400 Subject: [PATCH 10/11] Use tee instead of pipe --- .github/workflows/link-check-deploy.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 0c41d5dbf4..1c885ca1cb 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -16,4 +16,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}" >> $GITHUB_STEP_SUMMARY' + - name: Check Links + id: check + run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}" | tee $GITHUB_STEP_SUMMARY' From 1cc648a3875bb7b8eb92fc05439c3909abdf261c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 7 Jun 2022 18:18:04 -0400 Subject: [PATCH 11/11] Remove all summary piping --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 1c885ca1cb..266aa76d42 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -18,4 +18,4 @@ jobs: node-version: 16 - name: Check Links id: check - run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}" | tee $GITHUB_STEP_SUMMARY' + run: 'npx repo-link-check -c config/link-check/config.yml -d master -f -r "${{ github.event.deployment.payload.web_url }}"'