From cb6708e375e854a134e4487636074d7e5400a883 Mon Sep 17 00:00:00 2001 From: Roger Date: Thu, 23 Jul 2020 15:15:22 -0400 Subject: [PATCH 001/174] GitHub Actions link checker: Attempt 1 This is my attempt to rig up our link checker to run on GitHub Actions after the deployment is finished. Boy howdy do I hope this can be tested in a deploy preview. --- .github/workflows/link-check.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/link-check.yml diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml new file mode 100644 index 0000000000..8cba27f063 --- /dev/null +++ b/.github/workflows/link-check.yml @@ -0,0 +1,23 @@ +name: DVC Link Check +on: deployment_status + +jobs: + run: + runs-on: ubuntu-latest + if: deployment_status.state == 'success' + + steps: + - uses: actions/checkout@v2 + + - name: Run the link checker + id: check + run: "./scripts/link-check-git-diff.sh" + env: + CHECK_LINKS_RELATIVE_URL: ${{ deployment_status.target_url }} + + - uses: LouisBrunner/checks-action@v0.1.0 + if: always() + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check + conclusion: ${{ job }} From ed8079bdc474b55a4f5a8a52fd64bb4f202b969a Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 15:38:50 -0400 Subject: [PATCH 002/174] Use `github.event` instead of `deployment_status` --- .github/workflows/link-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 8cba27f063..8c7326556c 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -4,7 +4,7 @@ on: deployment_status jobs: run: runs-on: ubuntu-latest - if: deployment_status.state == 'success' + if: github.event.state == 'success' steps: - uses: actions/checkout@v2 @@ -13,7 +13,7 @@ jobs: id: check run: "./scripts/link-check-git-diff.sh" env: - CHECK_LINKS_RELATIVE_URL: ${{ deployment_status.target_url }} + CHECK_LINKS_RELATIVE_URL: ${{ github.event.target_url }} - uses: LouisBrunner/checks-action@v0.1.0 if: always() From 830e86bbff4e58c878446d514957e9c0d3282525 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 15:50:55 -0400 Subject: [PATCH 003/174] Adjust deployment_status fetch again This time I read the payload docs more carefully --- .github/workflows/link-check.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 8c7326556c..375b3c95eb 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -3,8 +3,9 @@ on: deployment_status jobs: run: + name: Run Link Checker runs-on: ubuntu-latest - if: github.event.state == 'success' + if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 @@ -13,7 +14,7 @@ jobs: id: check run: "./scripts/link-check-git-diff.sh" env: - CHECK_LINKS_RELATIVE_URL: ${{ github.event.target_url }} + CHECK_LINKS_RELATIVE_URL: ${{ github.event.deployment_status.target_url }} - uses: LouisBrunner/checks-action@v0.1.0 if: always() From bb8a9e5769c6e0523033e4e86e81642a3329e1be Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 16:06:00 -0400 Subject: [PATCH 004/174] Split Check action and fetch master before running differ --- .github/workflows/link-check.yml | 11 +++++++++-- scripts/link-check-git-diff.sh | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 375b3c95eb..db049a3c36 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -17,8 +17,15 @@ jobs: CHECK_LINKS_RELATIVE_URL: ${{ github.event.deployment_status.target_url }} - uses: LouisBrunner/checks-action@v0.1.0 - if: always() + if: success() with: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check - conclusion: ${{ job }} + conclusion: "Pass" + + - uses: LouisBrunner/checks-action@v0.1.0 + if: failure() + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check + conclusion: "Fail" diff --git a/scripts/link-check-git-diff.sh b/scripts/link-check-git-diff.sh index 5376aeae7d..4c33f9308d 100755 --- a/scripts/link-check-git-diff.sh +++ b/scripts/link-check-git-diff.sh @@ -4,6 +4,8 @@ set -euo pipefail source "$(dirname "$0")"/utils.sh pushd "$repo" +git fetch origin master + differ="git diff $(git merge-base HEAD origin/master)" changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" From 0d244bc6390002f1c36ecd9daf55d36b251a66e9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 16:32:00 -0400 Subject: [PATCH 005/174] Use correct strings for checks --- .github/workflows/link-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index db049a3c36..799b28a585 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -21,11 +21,11 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check - conclusion: "Pass" + conclusion: success - uses: LouisBrunner/checks-action@v0.1.0 if: failure() with: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check - conclusion: "Fail" + conclusion: failure From acae09273b6f6480897360315d75f2f80a861f01 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 16:48:37 -0400 Subject: [PATCH 006/174] Make check init at start then update when done --- .github/workflows/link-check.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 799b28a585..40f74a9f66 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -8,6 +8,12 @@ jobs: if: github.event.deployment_status.state == 'success' steps: + - uses: LouisBrunner/checks-action@v0.1.0 + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check + status: in_progress + - uses: actions/checkout@v2 - name: Run the link checker @@ -19,13 +25,9 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 if: success() with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check conclusion: success - uses: LouisBrunner/checks-action@v0.1.0 if: failure() with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check conclusion: failure From b35fdc73f0ab9f6dcb938b07188d25c8714032a0 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 17:00:40 -0400 Subject: [PATCH 007/174] Add tokens to every run on checks action --- .github/workflows/link-check.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 40f74a9f66..d31ccb958f 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -25,9 +25,13 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 if: success() with: + token: ${{ secrets.GITHUB_TOKEN }} + status: completed conclusion: success - uses: LouisBrunner/checks-action@v0.1.0 if: failure() with: + token: ${{ secrets.GITHUB_TOKEN }} + status: completed conclusion: failure From b33ea804bda5de07bf88db13f4c19d640d898630 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 17:19:46 -0400 Subject: [PATCH 008/174] Add conditional build flag to `yarn start` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e21f8753a6..7c29774823 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "scripts": { "develop": "gatsby develop", "dev": "gatsby develop", - "build": "gatsby build", + "build": "GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES=true gatsby build --log-pages", "start": "node ./src/server/index.js", "heroku-postbuild": "./scripts/deploy-with-s3.js", "test": "jest", From 51b59ab87773c7bfe92f8a6e1cf3461b82b90a4e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 17:44:16 -0400 Subject: [PATCH 009/174] Remove init behavior for now --- .github/workflows/link-check.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index d31ccb958f..6026c6e1d9 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -8,11 +8,6 @@ jobs: if: github.event.deployment_status.state == 'success' steps: - - uses: LouisBrunner/checks-action@v0.1.0 - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check - status: in_progress - uses: actions/checkout@v2 @@ -26,6 +21,7 @@ jobs: if: success() with: token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check status: completed conclusion: success @@ -33,5 +29,6 @@ jobs: if: failure() with: token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check status: completed conclusion: failure From 9256d831cbd32ca510defb3d610a1f4e86c97f69 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 23 Jul 2020 18:03:40 -0400 Subject: [PATCH 010/174] Adapt git link checker to use exit codes --- scripts/link-check-git-diff.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/link-check-git-diff.sh b/scripts/link-check-git-diff.sh index 4c33f9308d..87d4d6270c 100755 --- a/scripts/link-check-git-diff.sh +++ b/scripts/link-check-git-diff.sh @@ -1,13 +1,11 @@ #!/usr/bin/env bash -set -euo pipefail - source "$(dirname "$0")"/utils.sh -pushd "$repo" git fetch origin master differ="git diff $(git merge-base HEAD origin/master)" changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" +code=0 [ -z "$changed" ] && exit 0 @@ -17,6 +15,9 @@ echo "$changed" | while read -r file ; do # check just changed lines echo -n "$file:" "$(dirname "$0")"/link-check.sh <($differ -U0 -- "$file" | grep '^\+') + if [ $? -ne 0 ] ; then + code=1 + fi done -popd +exit $code From 2826f416cc8b9b7fa2681ce30675991381b24f30 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 24 Jul 2020 02:10:25 -0400 Subject: [PATCH 011/174] Give link checker its own script and restore old script from master --- .github/workflows/link-check.yml | 2 +- scripts/link-check-action.sh | 23 +++++++++++++++++++++++ scripts/link-check-git-diff.sh | 11 ++++------- 3 files changed, 28 insertions(+), 8 deletions(-) create mode 100755 scripts/link-check-action.sh diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 6026c6e1d9..ce7a9a5bf8 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - run: "./scripts/link-check-git-diff.sh" + run: "./scripts/link-check-action.sh" env: CHECK_LINKS_RELATIVE_URL: ${{ github.event.deployment_status.target_url }} diff --git a/scripts/link-check-action.sh b/scripts/link-check-action.sh new file mode 100755 index 0000000000..a07fa2e4e5 --- /dev/null +++ b/scripts/link-check-action.sh @@ -0,0 +1,23 @@ +#!/usr/bin/env bash +source "$(dirname "$0")"/utils.sh + +git fetch origin master >/dev/null 2>&1 + +differ="git diff $(git merge-base HEAD origin/master)" +changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" +code=0 + +[ -z "$changed" ] && exit 0 + +echo "$changed" | while read -r file ; do + # check whole file + # "$(dirname "$0")"/link-check.sh "$file" + # check just changed lines + echo -n "$file:" + "$(dirname "$0")"/link-check.sh <($differ -U0 -- "$file" | grep '^\+') + if [ $? -ne 0 ] ; then + code=1 + fi +done + +exit $code diff --git a/scripts/link-check-git-diff.sh b/scripts/link-check-git-diff.sh index 87d4d6270c..5376aeae7d 100755 --- a/scripts/link-check-git-diff.sh +++ b/scripts/link-check-git-diff.sh @@ -1,11 +1,11 @@ #!/usr/bin/env bash -source "$(dirname "$0")"/utils.sh +set -euo pipefail -git fetch origin master +source "$(dirname "$0")"/utils.sh +pushd "$repo" differ="git diff $(git merge-base HEAD origin/master)" changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" -code=0 [ -z "$changed" ] && exit 0 @@ -15,9 +15,6 @@ echo "$changed" | while read -r file ; do # check just changed lines echo -n "$file:" "$(dirname "$0")"/link-check.sh <($differ -U0 -- "$file" | grep '^\+') - if [ $? -ne 0 ] ; then - code=1 - fi done -exit $code +popd From bd1eaa10ffc698823e14b7e05ad69ea0c05d9337 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 24 Jul 2020 02:56:21 -0400 Subject: [PATCH 012/174] Consolidate check reporter --- .github/workflows/link-check.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index ce7a9a5bf8..df00b434a5 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -18,17 +18,8 @@ jobs: CHECK_LINKS_RELATIVE_URL: ${{ github.event.deployment_status.target_url }} - uses: LouisBrunner/checks-action@v0.1.0 - if: success() with: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check status: completed - conclusion: success - - - uses: LouisBrunner/checks-action@v0.1.0 - if: failure() - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check - status: completed - conclusion: failure + conclusion: ${{ steps.check.conclusion }} From db1512a5c3e0383f733f5d830e5e5091adc41cf6 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 24 Jul 2020 03:00:19 -0400 Subject: [PATCH 013/174] Add a failing link to test the new action --- content/blog/2020-07-07-cml-release.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/blog/2020-07-07-cml-release.md b/content/blog/2020-07-07-cml-release.md index a678666291..ce6dd957db 100644 --- a/content/blog/2020-07-07-cml-release.md +++ b/content/blog/2020-07-07-cml-release.md @@ -25,6 +25,8 @@ tags: ## CI/CD for machine learning +[This link doesn't exist](https://example.com/link/that/surely/doesnotexist) + Today, the DVC team is releasing a new open-source project called Continuous Machine Learning, or CML (https://cml.dev) to mainstream the best engineering practices of CI/CD to AI and ML teams. CML helps to organize MLOps From 2d4883c3023e033a393f5679ccd0f43410e9f75d Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 24 Jul 2020 03:37:10 -0400 Subject: [PATCH 014/174] Change link check script to use pwd-relative instead of $0 I think this could be causing a bug with GH actions --- scripts/link-check-action.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/link-check-action.sh b/scripts/link-check-action.sh index a07fa2e4e5..2ea269293c 100755 --- a/scripts/link-check-action.sh +++ b/scripts/link-check-action.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash -source "$(dirname "$0")"/utils.sh +source ./scripts/utils.sh git fetch origin master >/dev/null 2>&1 @@ -11,10 +11,10 @@ code=0 echo "$changed" | while read -r file ; do # check whole file - # "$(dirname "$0")"/link-check.sh "$file" + # ./scripts/link-check.sh "$file" # check just changed lines echo -n "$file:" - "$(dirname "$0")"/link-check.sh <($differ -U0 -- "$file" | grep '^\+') + ./scripts/link-check.sh <($differ -U0 -- "$file" | grep '^\+') if [ $? -ne 0 ] ; then code=1 fi From 3a8eda22b0ab479d90ad1c0255ff76278bee448f Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 24 Jul 2020 04:11:04 -0400 Subject: [PATCH 015/174] Add echo messages for debugging --- scripts/link-check-action.sh | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/scripts/link-check-action.sh b/scripts/link-check-action.sh index 2ea269293c..f4ec6db02b 100755 --- a/scripts/link-check-action.sh +++ b/scripts/link-check-action.sh @@ -1,23 +1,25 @@ #!/usr/bin/env bash source ./scripts/utils.sh +echo "Fetching origin/master to diff against" git fetch origin master >/dev/null 2>&1 differ="git diff $(git merge-base HEAD origin/master)" changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" code=0 -[ -z "$changed" ] && exit 0 +if [ -z "$changed" ]; then + echo "\nNo checkable files have changed." + exit 0 +fi +echo "\nChecking links in changed files...\n" echo "$changed" | while read -r file ; do - # check whole file - # ./scripts/link-check.sh "$file" - # check just changed lines - echo -n "$file:" - ./scripts/link-check.sh <($differ -U0 -- "$file" | grep '^\+') - if [ $? -ne 0 ] ; then - code=1 - fi + echo -n "$file:" + ./scripts/link-check.sh <($differ -U0 -- "$file" | grep '^\+') + if [ $? -ne 0 ] ; then + code=1 + fi done exit $code From 6e0744274a2b8af5ed3dba90a5ea168d3e547041 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 24 Jul 2020 14:05:04 -0400 Subject: [PATCH 016/174] Change diff command and move all links to relative Maybe this will work better with the incomplete (but more performant) default commit action. --- scripts/link-check-action.sh | 22 +++++++++++----------- scripts/link-check.sh | 2 +- scripts/utils.sh | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/scripts/link-check-action.sh b/scripts/link-check-action.sh index f4ec6db02b..d6477e4b23 100755 --- a/scripts/link-check-action.sh +++ b/scripts/link-check-action.sh @@ -4,22 +4,22 @@ source ./scripts/utils.sh echo "Fetching origin/master to diff against" git fetch origin master >/dev/null 2>&1 -differ="git diff $(git merge-base HEAD origin/master)" -changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" -code=0 +CHANGED_FILES="$(git diff origin/master HEAD --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" +EXIT_CODE=0 -if [ -z "$changed" ]; then - echo "\nNo checkable files have changed." +if [ -z "$CHANGED_FILES" ]; then + echo "No checkable files have changed." exit 0 fi -echo "\nChecking links in changed files...\n" -echo "$changed" | while read -r file ; do - echo -n "$file:" - ./scripts/link-check.sh <($differ -U0 -- "$file" | grep '^\+') +echo -e "\nChecking links in changed files:" + +echo "$CHANGED_FILES" | while read -r CHANGED_FILE ; do + echo -n "$CHANGED_FILE:" + ./scripts/link-check.sh <($DIFF_COMMAND -U0 -- "$CHANGED_FILE" | grep '^\+') if [ $? -ne 0 ] ; then - code=1 + EXIT_CODE=1 fi done -exit $code +exit $EXIT_CODE diff --git a/scripts/link-check.sh b/scripts/link-check.sh index 4db2374667..229171c249 100755 --- a/scripts/link-check.sh +++ b/scripts/link-check.sh @@ -6,7 +6,7 @@ # link-check.sh [] set -euo pipefail -source "$(dirname "$0")"/utils.sh +source ./scripts/utils.sh checker(){ # expects list of urls errors=0 diff --git a/scripts/utils.sh b/scripts/utils.sh index 85bd8efeb4..76f7f3c9af 100644 --- a/scripts/utils.sh +++ b/scripts/utils.sh @@ -3,9 +3,9 @@ # Defines: # repo, base_url, exclude, user_agent, urlfinder() -repo="$(dirname "$(realpath "$(dirname "$0")")")" +repo="$(dirname "$(realpath "./scripts")")" base_url="${CHECK_LINKS_RELATIVE_URL:-https://dvc.org}" -exclude="${CHECK_LINKS_EXCLUDE_LIST:-$(dirname "$0")/exclude-links.txt}" +exclude="${CHECK_LINKS_EXCLUDE_LIST:-./scripts/exclude-links.txt}" [ -f "$exclude" ] && exclude="$(cat "$exclude")" user_agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:74.0) Gecko/20100101 Firefox/74.0" From 96fe61a8e620736ae17fd35a369850a9e3ca6ac4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 25 Jul 2020 02:21:41 -0400 Subject: [PATCH 017/174] Add example links --- content/blog/2020-07-24-first-mlops-tutorial.md | 2 ++ content/blog/2020-07-27-example.md | 8 ++++++++ 2 files changed, 10 insertions(+) create mode 100644 content/blog/2020-07-27-example.md diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index 11c1f8bd00..0a3e68a721 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -25,6 +25,8 @@ DevOps practices (like continuous integration) as a regular fixture of machine learning and data science projects. But there are plenty of challenges ahead, and a big one is _literacy_. +[Relative broken link](/not/a/real/path) + So many data scientists, like developers, are self-taught. Data science degrees have only recently emerged on the scene, which means if you polled a handful of senior-level data scientists, there'd almost certainly be no universal training diff --git a/content/blog/2020-07-27-example.md b/content/blog/2020-07-27-example.md new file mode 100644 index 0000000000..0555fbaef1 --- /dev/null +++ b/content/blog/2020-07-27-example.md @@ -0,0 +1,8 @@ +--- +title: Example +--- + +[Google](www.google.com). [this is a 504 forever](httpstat.us/504) +[this is a 504 forever](httpstat.us/504) +[this is a 504 forever](httpstat.us/504) +[this should be excluded](https://myendpoint.com) From e84b7abd96ffe14f3d2ba14c3b004087c8bb4a5d Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 20:27:06 -0400 Subject: [PATCH 018/174] Remove bash-based GitHub action --- scripts/link-check-action.sh | 25 ------------------------- 1 file changed, 25 deletions(-) delete mode 100755 scripts/link-check-action.sh diff --git a/scripts/link-check-action.sh b/scripts/link-check-action.sh deleted file mode 100755 index d6477e4b23..0000000000 --- a/scripts/link-check-action.sh +++ /dev/null @@ -1,25 +0,0 @@ -#!/usr/bin/env bash -source ./scripts/utils.sh - -echo "Fetching origin/master to diff against" -git fetch origin master >/dev/null 2>&1 - -CHANGED_FILES="$(git diff origin/master HEAD --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" -EXIT_CODE=0 - -if [ -z "$CHANGED_FILES" ]; then - echo "No checkable files have changed." - exit 0 -fi - -echo -e "\nChecking links in changed files:" - -echo "$CHANGED_FILES" | while read -r CHANGED_FILE ; do - echo -n "$CHANGED_FILE:" - ./scripts/link-check.sh <($DIFF_COMMAND -U0 -- "$CHANGED_FILE" | grep '^\+') - if [ $? -ne 0 ] ; then - EXIT_CODE=1 - fi -done - -exit $EXIT_CODE From 75a5b0e78ef0ac0b344506687b9ed3643ff183b3 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 20:27:37 -0400 Subject: [PATCH 019/174] Add a JS-based link checker with CLI and GitHub Action runners --- package.json | 4 + scripts/link-check/action.js | 26 +++++ scripts/link-check/exclusions.js | 14 +++ scripts/link-check/formatting.js | 11 ++ scripts/link-check/index.js | 7 ++ scripts/link-check/link-check-git-diff.js | 109 +++++++++++++++++++ scripts/link-check/link-check.js | 60 +++++++++++ yarn.lock | 123 +++++++++++++++++++++- 8 files changed, 352 insertions(+), 2 deletions(-) create mode 100644 scripts/link-check/action.js create mode 100644 scripts/link-check/exclusions.js create mode 100644 scripts/link-check/formatting.js create mode 100644 scripts/link-check/index.js create mode 100644 scripts/link-check/link-check-git-diff.js create mode 100644 scripts/link-check/link-check.js diff --git a/package.json b/package.json index 7c29774823..d159e2c1d4 100644 --- a/package.json +++ b/package.json @@ -34,6 +34,8 @@ "node": ">=12.0.0" }, "dependencies": { + "@actions/core": "^1.2.4", + "@actions/github": "^4.0.0", "@hapi/wreck": "^17.0.0", "@octokit/graphql": "^4.3.1", "@reach/portal": "^0.10.0", @@ -56,9 +58,11 @@ "iso-url": "^0.4.7", "isomorphic-fetch": "^2.2.1", "lodash": "^4.17.19", + "micromatch": "^4.0.2", "moment": "^2.25.3", "nanoid": "^3.0.2", "node-cache": "^5.1.0", + "node-fetch": "^2.6.0", "perfect-scrollbar": "^1.5.0", "pretty-quick": "^2.0.1", "prismjs": "^1.20.0", diff --git a/scripts/link-check/action.js b/scripts/link-check/action.js new file mode 100644 index 0000000000..9ec37ca969 --- /dev/null +++ b/scripts/link-check/action.js @@ -0,0 +1,26 @@ +const core = require('@actions/core') +const { getFailingAddedLinks } = require('./link-check-git-diff.js') +const { formatErrors } = require('./formatting.js') + +try { + getFailingAddedLinks.then(failedChecks => { + // Return either a success message or a report of all failed checks + if (failedChecks) { + core.setOutput('summary', 'Some new links failed the check.') + core.setOutput( + 'details', + `The following links failed the link check:\n${formatErrors( + failedChecks + )}` + ) + core.setOutput('conclusion', 'failure') + } else { + core.setOutput('summary', 'All new links passed the check!') + core.setOutput('conclusion', 'success') + } + + core.setOutput('check', report) + }) +} catch (e) { + core.setFailed(`Link checker had an error! (${e.message})`) +} diff --git a/scripts/link-check/exclusions.js b/scripts/link-check/exclusions.js new file mode 100644 index 0000000000..974fc07979 --- /dev/null +++ b/scripts/link-check/exclusions.js @@ -0,0 +1,14 @@ +const fs = require('fs') +const path = require('path') +const micromatch = require('micromatch') +const excludeList = String( + fs.readFileSync(path.resolve('scripts', 'exclude-links.txt')) +) + .split(/[ \t\r\n]+/) + .filter(Boolean) +const isExcluded = subject => micromatch.isMatch(subject, excludeList) + +module.exports = { + excludeList, + isExcluded +} diff --git a/scripts/link-check/formatting.js b/scripts/link-check/formatting.js new file mode 100644 index 0000000000..8e01e630cd --- /dev/null +++ b/scripts/link-check/formatting.js @@ -0,0 +1,11 @@ +const formatErrors = errorsByFile => + errorsByFile + .map( + ({ filePath, links }) => + `* ${filePath}:\n${links + .map(({ link, result }) => ` - ${link} => ${result}`) + .join('\n')}` + ) + .join('\n') + +module.exports = formatErrors diff --git a/scripts/link-check/index.js b/scripts/link-check/index.js new file mode 100644 index 0000000000..405549b93a --- /dev/null +++ b/scripts/link-check/index.js @@ -0,0 +1,7 @@ +// CLI runner for link-check-git-diff +const { getCheckedAddedLinks } = require('./link-check-git-diff.js') +const formatLinks = require('./formatting.js') + +getCheckedAddedLinks().then(links => { + console.log(formatLinks(links)) +}) diff --git a/scripts/link-check/link-check-git-diff.js b/scripts/link-check/link-check-git-diff.js new file mode 100644 index 0000000000..6ae01e71c0 --- /dev/null +++ b/scripts/link-check/link-check-git-diff.js @@ -0,0 +1,109 @@ +const path = require('path') +const { exec } = require('child_process') + +const { uniq, flatten } = require('lodash') + +const linkCheck = require('./link-check.js') + +const DEFAULT_BASE_URL = 'https://dvc.org' + +const matchFirstGroups = (input, regex) => + Array.from(input.matchAll(regex), x => x[1]) + +const getGitDiff = async () => + new Promise((resolve, reject) => { + exec('git diff origin/master HEAD', (err, stdout) => + err ? reject(err) : resolve(stdout) + ) + }) + +const getAddedLines = async () => { + const splitOutput = (await getGitDiff()).split( + /^diff --git.* b\/(.*)\n(?:.*\n){4}/gm + ) + const processedOutputs = [] + for (let i = 1; i < splitOutput.length; i += 2) { + const additions = splitOutput[i + 1] + .split('\n') + .map(line => line.startsWith('+') && line) + .filter(Boolean) + + if (additions.length > 0) { + processedOutputs.push({ + filePath: splitOutput[i], + additions + }) + } + } + return processedOutputs +} + +const scrapeLinks = (filePath, content) => { + let matchedLinks = [] + const ext = path.extname(filePath) + + switch (ext) { + case '.md': + matchedLinks = matchedLinks.concat( + matchFirstGroups(content, /\[.*?\]\((.*?)\)/gm) + ) + break + case '.html': + matchedLinks = matchedLinks.concat( + matchFirstGroups(content, /href="(.*?)"/gm) + ) + default: + matchedLinks = + content.match(/https?:(\/\/)?(\w+\.)?(\w+)\.([\w\/\.]+)/gm) || [] + break + } + return matchedLinks +} + +const getAddedLinks = async () => + (await getAddedLines()) + .map(({ filePath, additions }) => { + const foundLinks = flatten( + additions.map(line => scrapeLinks(filePath, line)) + ) + if (foundLinks.length > 0) { + return { + filePath, + links: uniq(foundLinks) + } + } + }) + .filter(Boolean) + +const getCheckedAddedLinks = async (baseURL = DEFAULT_BASE_URL) => + Promise.all( + (await getAddedLinks()).map(async ({ filePath, links }) => ({ + filePath, + links: await Promise.all(links.map(link => linkCheck(link, baseURL))) + })) + ) + +const getFailingAddedLinks = async baseURL => { + const checkedLinksByFile = await getCheckedAddedLinks(baseURL) + + // Filter finished linkChecks to only errors + const errorsByFile = checkedLinksByFile + .map(({ filePath, links }) => { + const badLinks = links.filter(link => !link.ok) + return badLinks.length > 0 + ? { + filePath, + links: badLinks + } + : null + }) + .filter(Boolean) + + // Return errors if they exist, or null upon success (like a traditional callback) + return errorsByFile.length > 0 ? errorsByFile : null +} + +module.exports = { + getCheckedAddedLinks, + getFailingAddedLinks +} diff --git a/scripts/link-check/link-check.js b/scripts/link-check/link-check.js new file mode 100644 index 0000000000..333c759a3f --- /dev/null +++ b/scripts/link-check/link-check.js @@ -0,0 +1,60 @@ +const fetch = require('node-fetch') +const { isExcluded } = require('./exclusions.js') +const MAX_ATTEMPTS = 1 +const ATTEMPT_RETRY_DELAY = 1000 + +const getURL = (link, baseURL) => { + return new URL( + /^(https?:\/)?\//.test(link) ? link : `https://${link}`, + baseURL + ) +} + +const fetchWithRetries = async (href, attempt = 1) => { + const res = await fetch(href) + if (res.status === 504) { + if (attempt < MAX_ATTEMPTS) { + return new Promise(resolve => + setTimeout( + () => fetchWithRetries(href, attempt + 1).then(resolve), + ATTEMPT_RETRY_DELAY + ) + ) + } else { + return res + } + } else { + return res + } +} + +const memo = {} +const memoizedFetch = async href => { + const existing = memo[href] + if (existing) { + return existing + } else { + memo[href] = fetchWithRetries(href) + return memo[href] + } +} + +const buildLinkCheckObject = async (link, baseURL) => { + if (isExcluded(link)) { + return { + link, + result: 'excluded', + ok: true + } + } else { + const { href } = getURL(link, baseURL) + const { status, ok } = await memoizedFetch(href) + return { + link, + result: status, + ok + } + } +} + +module.exports = buildLinkCheckObject diff --git a/yarn.lock b/yarn.lock index 17245b2ff3..c2f18955b9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -11,6 +11,28 @@ deep-eql "^0.1.3" keypather "^1.10.2" +"@actions/core@^1.2.4": + version "1.2.4" + resolved "https://registry.yarnpkg.com/@actions/core/-/core-1.2.4.tgz#96179dbf9f8d951dd74b40a0dbd5c22555d186ab" + integrity sha512-YJCEq8BE3CdN8+7HPZ/4DxJjk/OkZV2FFIf+DlZTC/4iBlzYCD5yjRR6eiOS5llO11zbRltIRuKAjMKaWTE6cg== + +"@actions/github@^4.0.0": + version "4.0.0" + resolved "https://registry.yarnpkg.com/@actions/github/-/github-4.0.0.tgz#d520483151a2bf5d2dc9cd0f20f9ac3a2e458816" + integrity sha512-Ej/Y2E+VV6sR9X7pWL5F3VgEWrABaT292DRqRU6R4hnQjPtC/zD3nagxVdXWiRQvYDh8kHXo7IDmG42eJ/dOMA== + dependencies: + "@actions/http-client" "^1.0.8" + "@octokit/core" "^3.0.0" + "@octokit/plugin-paginate-rest" "^2.2.3" + "@octokit/plugin-rest-endpoint-methods" "^4.0.0" + +"@actions/http-client@^1.0.8": + version "1.0.8" + resolved "https://registry.yarnpkg.com/@actions/http-client/-/http-client-1.0.8.tgz#8bd76e8eca89dc8bcf619aa128eba85f7a39af45" + integrity sha512-G4JjJ6f9Hb3Zvejj+ewLLKLf99ZC+9v+yCxoYf9vSyH+WkzPLB2LuUtRMGNkooMqdugGBFStIKXOuvH1W+EctA== + dependencies: + tunnel "0.0.6" + "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.8.3": version "7.8.3" resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.8.3.tgz#33e25903d7481181534e12ec0a25f16b6fcf419e" @@ -1611,6 +1633,25 @@ "@nodelib/fs.scandir" "2.1.3" fastq "^1.6.0" +"@octokit/auth-token@^2.4.0": + version "2.4.2" + resolved "https://registry.yarnpkg.com/@octokit/auth-token/-/auth-token-2.4.2.tgz#10d0ae979b100fa6b72fa0e8e63e27e6d0dbff8a" + integrity sha512-jE/lE/IKIz2v1+/P0u4fJqv0kYwXOTujKemJMFr6FeopsxlIK3+wKDCJGnysg81XID5TgZQbIfuJ5J0lnTiuyQ== + dependencies: + "@octokit/types" "^5.0.0" + +"@octokit/core@^3.0.0": + version "3.1.1" + resolved "https://registry.yarnpkg.com/@octokit/core/-/core-3.1.1.tgz#1856745aa8fb154cf1544a2a1b82586c809c5e66" + integrity sha512-cQ2HGrtyNJ1IBxpTP1U5m/FkMAJvgw7d2j1q3c9P0XUuYilEgF6e4naTpsgm4iVcQeOnccZlw7XHRIUBy0ymcg== + dependencies: + "@octokit/auth-token" "^2.4.0" + "@octokit/graphql" "^4.3.1" + "@octokit/request" "^5.4.0" + "@octokit/types" "^5.0.0" + before-after-hook "^2.1.0" + universal-user-agent "^6.0.0" + "@octokit/endpoint@^6.0.1": version "6.0.1" resolved "https://registry.yarnpkg.com/@octokit/endpoint/-/endpoint-6.0.1.tgz#16d5c0e7a83e3a644d1ddbe8cded6c3d038d31d7" @@ -1629,6 +1670,21 @@ "@octokit/types" "^4.0.1" universal-user-agent "^5.0.0" +"@octokit/plugin-paginate-rest@^2.2.3": + version "2.3.0" + resolved "https://registry.yarnpkg.com/@octokit/plugin-paginate-rest/-/plugin-paginate-rest-2.3.0.tgz#7d1073e56cfd15d3f99dcfe81fa5d2b466f3a6f6" + integrity sha512-Ye2ZJreP0ZlqJQz8fz+hXvrEAEYK4ay7br1eDpWzr6j76VXs/gKqxFcH8qRzkB3fo/2xh4Vy9VtGii4ZDc9qlA== + dependencies: + "@octokit/types" "^5.2.0" + +"@octokit/plugin-rest-endpoint-methods@^4.0.0": + version "4.1.2" + resolved "https://registry.yarnpkg.com/@octokit/plugin-rest-endpoint-methods/-/plugin-rest-endpoint-methods-4.1.2.tgz#546a8f3e0b514f434a4ad4ef926005f1c81a5a5a" + integrity sha512-PTI7wpbGEZ2IR87TVh+TNWaLcgX/RsZQalFbQCq8XxYUrQ36RHyERrHSNXFy5gkWpspUAOYRSV707JJv6BhqJA== + dependencies: + "@octokit/types" "^5.1.1" + deprecation "^2.3.1" + "@octokit/request-error@^2.0.0": version "2.0.1" resolved "https://registry.yarnpkg.com/@octokit/request-error/-/request-error-2.0.1.tgz#49bd71e811daffd5bdd06ef514ca47b5039682d1" @@ -1652,6 +1708,20 @@ once "^1.4.0" universal-user-agent "^5.0.0" +"@octokit/request@^5.4.0": + version "5.4.7" + resolved "https://registry.yarnpkg.com/@octokit/request/-/request-5.4.7.tgz#fd703ee092e0463ceba49ff7a3e61cb4cf8a0fde" + integrity sha512-FN22xUDP0i0uF38YMbOfx6TotpcENP5W8yJM1e/LieGXn6IoRxDMnBf7tx5RKSW4xuUZ/1P04NFZy5iY3Rax1A== + dependencies: + "@octokit/endpoint" "^6.0.1" + "@octokit/request-error" "^2.0.0" + "@octokit/types" "^5.0.0" + deprecation "^2.0.0" + is-plain-object "^4.0.0" + node-fetch "^2.3.0" + once "^1.4.0" + universal-user-agent "^6.0.0" + "@octokit/types@^2.11.1": version "2.16.2" resolved "https://registry.yarnpkg.com/@octokit/types/-/types-2.16.2.tgz#4c5f8da3c6fecf3da1811aef678fda03edac35d2" @@ -1666,6 +1736,13 @@ dependencies: "@types/node" ">= 8" +"@octokit/types@^5.0.0", "@octokit/types@^5.1.1", "@octokit/types@^5.2.0": + version "5.2.0" + resolved "https://registry.yarnpkg.com/@octokit/types/-/types-5.2.0.tgz#d075dc23bf293f540739250b6879e2c1be2fc20c" + integrity sha512-XjOk9y4m8xTLIKPe1NFxNWBdzA2/z3PFFA/bwf4EoH6oS8hM0Y46mEa4Cb+KCyj/tFDznJFahzQ0Aj3o1FYq4A== + dependencies: + "@types/node" ">= 8" + "@pieh/friendly-errors-webpack-plugin@1.7.0-chalk-2": version "1.7.0-chalk-2" resolved "https://registry.yarnpkg.com/@pieh/friendly-errors-webpack-plugin/-/friendly-errors-webpack-plugin-1.7.0-chalk-2.tgz#2e9da9d3ade9d18d013333eb408c457d04eabac0" @@ -3297,6 +3374,11 @@ bcrypt-pbkdf@^1.0.0: dependencies: tweetnacl "^0.14.3" +before-after-hook@^2.1.0: + version "2.1.0" + resolved "https://registry.yarnpkg.com/before-after-hook/-/before-after-hook-2.1.0.tgz#b6c03487f44e24200dd30ca5e6a1979c5d2fb635" + integrity sha512-IWIbu7pMqyw3EAJHzzHbWa85b6oud/yfKYg5rqB5hNE8CeMi3nX+2C2sj0HswfblST86hpVEOAb9x34NZd6P7A== + better-assert@~1.0.0: version "1.0.2" resolved "https://registry.yarnpkg.com/better-assert/-/better-assert-1.0.2.tgz#40866b9e1b9e0b55b481894311e68faffaebc522" @@ -5255,7 +5337,7 @@ depd@~1.1.2: resolved "https://registry.yarnpkg.com/depd/-/depd-1.1.2.tgz#9bcd52e14c097763e749b274c4346ed2e560b5a9" integrity sha1-m81S4UwJd2PnSbJ0xDRu0uVgtak= -deprecation@^2.0.0: +deprecation@^2.0.0, deprecation@^2.3.1: version "2.3.1" resolved "https://registry.yarnpkg.com/deprecation/-/deprecation-2.3.1.tgz#6368cbdb40abf3373b525ac87e4a260c3a700919" integrity sha512-xmHIy4F3scKVwMsQ4WnVaS8bHOx0DmVwRywosKhaILI0ywMDWPtBSku2HNxRvF7jtwDRsoEwYQSfbxj8b7RlJQ== @@ -9529,6 +9611,11 @@ is-plain-object@^3.0.0: dependencies: isobject "^4.0.0" +is-plain-object@^4.0.0: + version "4.1.1" + resolved "https://registry.yarnpkg.com/is-plain-object/-/is-plain-object-4.1.1.tgz#1a14d6452cbd50790edc7fdaa0aed5a40a35ebb5" + integrity sha512-5Aw8LLVsDlZsETVMhoMXzqsXwQqr/0vlnBYzIXJbYo2F4yYlhLHs+Ez7Bod7IIQKWkJbJfxrWD7pA1Dw1TKrwA== + is-png@^1.0.0: version "1.1.0" resolved "https://registry.yarnpkg.com/is-png/-/is-png-1.1.0.tgz#d574b12bf275c0350455570b0e5b57ab062077ce" @@ -14180,7 +14267,7 @@ remark-mdx@^1.6.4: remark-parse "8.0.2" unified "9.0.0" -remark-parse@8.0.2, remark-parse@^8.0.0, remark-parse@^8.0.2: +remark-parse@8.0.2, remark-parse@^8.0.0: version "8.0.2" resolved "https://registry.yarnpkg.com/remark-parse/-/remark-parse-8.0.2.tgz#5999bc0b9c2e3edc038800a64ff103d0890b318b" integrity sha512-eMI6kMRjsAGpMXXBAywJwiwAse+KNpmt+BK55Oofy4KvBZEqUDj6mWbGLJZrujoPIPPxDXzn3T9baRlpsm2jnQ== @@ -14238,6 +14325,28 @@ remark-parse@^6.0.0, remark-parse@^6.0.3: vfile-location "^2.0.0" xtend "^4.0.1" +remark-parse@^8.0.2: + version "8.0.3" + resolved "https://registry.yarnpkg.com/remark-parse/-/remark-parse-8.0.3.tgz#9c62aa3b35b79a486454c690472906075f40c7e1" + integrity sha512-E1K9+QLGgggHxCQtLt++uXltxEprmWzNfg+MxpfHsZlrddKzZ/hZyWHDbK3/Ap8HJQqYJRXP+jHczdL6q6i85Q== + dependencies: + ccount "^1.0.0" + collapse-white-space "^1.0.2" + is-alphabetical "^1.0.0" + is-decimal "^1.0.0" + is-whitespace-character "^1.0.0" + is-word-character "^1.0.0" + markdown-escapes "^1.0.0" + parse-entities "^2.0.0" + repeat-string "^1.5.4" + state-toggle "^1.0.0" + trim "0.0.1" + trim-trailing-lines "^1.0.0" + unherit "^1.0.4" + unist-util-remove-position "^2.0.0" + vfile-location "^3.0.0" + xtend "^4.0.1" + remark-retext@^3.1.3: version "3.1.3" resolved "https://registry.yarnpkg.com/remark-retext/-/remark-retext-3.1.3.tgz#77173b1d9d13dab15ce5b38d996195fea522ee7f" @@ -16501,6 +16610,11 @@ tunnel-agent@^0.6.0: dependencies: safe-buffer "^5.0.1" +tunnel@0.0.6: + version "0.0.6" + resolved "https://registry.yarnpkg.com/tunnel/-/tunnel-0.0.6.tgz#72f1314b34a5b192db012324df2cc587ca47f92c" + integrity sha512-1h/Lnq9yajKY2PEbBadPXj3VxsDDu844OnaAo52UVmIzIvwwtBPIuNvkjuzBlTWpfJyUbG3ez0KSBibQkj4ojg== + tweetnacl@^0.14.3, tweetnacl@~0.14.0: version "0.14.5" resolved "https://registry.yarnpkg.com/tweetnacl/-/tweetnacl-0.14.5.tgz#5ae68177f192d4456269d108afa93ff8743f4f64" @@ -16888,6 +17002,11 @@ universal-user-agent@^5.0.0: dependencies: os-name "^3.1.0" +universal-user-agent@^6.0.0: + version "6.0.0" + resolved "https://registry.yarnpkg.com/universal-user-agent/-/universal-user-agent-6.0.0.tgz#3381f8503b251c0d9cd21bc1de939ec9df5480ee" + integrity sha512-isyNax3wXoKaulPDZWHQqbmIx1k2tb9fb3GGDBRxCscfYV2Ch7WxPArBsFEG8s/safwXTT7H4QGhaIkTp9447w== + universalify@^0.1.0: version "0.1.2" resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.1.2.tgz#b646f69be3942dabcecc9d6639c80dc105efaa66" From 1c9765eab975dd74275659d69261b4d54f763d5e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 20:52:44 -0400 Subject: [PATCH 020/174] Improve link checker - Change YML definition - Get baseURL from inputs in action.js - Get baseURL from env var in index.js - use `bash: true` for micromatch (makes single `*` act as globstar) - Only check links in `content` (configurable) - Show href in formatted links - Catch fetch exceptions and report codes (for completely nonexistent sites) --- .github/workflows/link-check.yml | 13 +++++++++---- scripts/link-check/action.js | 2 +- scripts/link-check/exclusions.js | 3 ++- scripts/link-check/formatting.js | 7 ++++++- scripts/link-check/index.js | 3 ++- scripts/link-check/link-check-git-diff.js | 3 +++ scripts/link-check/link-check.js | 20 +++++++++++++++----- 7 files changed, 38 insertions(+), 13 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index df00b434a5..647a926207 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,13 +13,18 @@ jobs: - name: Run the link checker id: check - run: "./scripts/link-check-action.sh" - env: - CHECK_LINKS_RELATIVE_URL: ${{ github.event.deployment_status.target_url }} + inputs: + baseURL: "${{ github.event.deployment_status.target_url }}" + runs: + using: 'node12' + main: 'scripts/link-check/action.js' - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check status: completed - conclusion: ${{ steps.check.conclusion }} + conclusion: ${{ steps.check.outputs.conclusion }} + output: + summary: ${{ steps.check.outputs.summary }} + text_description: ${{ steps.check.outputs.description }} diff --git a/scripts/link-check/action.js b/scripts/link-check/action.js index 9ec37ca969..eae9ef2119 100644 --- a/scripts/link-check/action.js +++ b/scripts/link-check/action.js @@ -3,7 +3,7 @@ const { getFailingAddedLinks } = require('./link-check-git-diff.js') const { formatErrors } = require('./formatting.js') try { - getFailingAddedLinks.then(failedChecks => { + getFailingAddedLinks(core.getInput('baseURL')).then(failedChecks => { // Return either a success message or a report of all failed checks if (failedChecks) { core.setOutput('summary', 'Some new links failed the check.') diff --git a/scripts/link-check/exclusions.js b/scripts/link-check/exclusions.js index 974fc07979..362986365d 100644 --- a/scripts/link-check/exclusions.js +++ b/scripts/link-check/exclusions.js @@ -6,7 +6,8 @@ const excludeList = String( ) .split(/[ \t\r\n]+/) .filter(Boolean) -const isExcluded = subject => micromatch.isMatch(subject, excludeList) +const isExcluded = subject => + micromatch.isMatch(subject, excludeList, { bash: true }) module.exports = { excludeList, diff --git a/scripts/link-check/formatting.js b/scripts/link-check/formatting.js index 8e01e630cd..c7e91f0653 100644 --- a/scripts/link-check/formatting.js +++ b/scripts/link-check/formatting.js @@ -3,7 +3,12 @@ const formatErrors = errorsByFile => .map( ({ filePath, links }) => `* ${filePath}:\n${links - .map(({ link, result }) => ` - ${link} => ${result}`) + .map( + ({ link, href, result }) => + ` - ${link}${ + href && href !== link ? ` (${href})` : '' + } => ${result}` + ) .join('\n')}` ) .join('\n') diff --git a/scripts/link-check/index.js b/scripts/link-check/index.js index 405549b93a..e6e09306f8 100644 --- a/scripts/link-check/index.js +++ b/scripts/link-check/index.js @@ -1,7 +1,8 @@ // CLI runner for link-check-git-diff const { getCheckedAddedLinks } = require('./link-check-git-diff.js') const formatLinks = require('./formatting.js') +const baseURL = process.env.CHECK_LINKS_RELATIVE_URL -getCheckedAddedLinks().then(links => { +getCheckedAddedLinks(baseURL).then(links => { console.log(formatLinks(links)) }) diff --git a/scripts/link-check/link-check-git-diff.js b/scripts/link-check/link-check-git-diff.js index 6ae01e71c0..0d4403e953 100644 --- a/scripts/link-check/link-check-git-diff.js +++ b/scripts/link-check/link-check-git-diff.js @@ -1,11 +1,13 @@ const path = require('path') const { exec } = require('child_process') +const mm = require('micromatch') const { uniq, flatten } = require('lodash') const linkCheck = require('./link-check.js') const DEFAULT_BASE_URL = 'https://dvc.org' +const INCLUDED_FILES = ['content/*'] const matchFirstGroups = (input, regex) => Array.from(input.matchAll(regex), x => x[1]) @@ -63,6 +65,7 @@ const scrapeLinks = (filePath, content) => { const getAddedLinks = async () => (await getAddedLines()) .map(({ filePath, additions }) => { + if (!mm.isMatch(filePath, INCLUDED_FILES, { bash: true })) return null const foundLinks = flatten( additions.map(line => scrapeLinks(filePath, line)) ) diff --git a/scripts/link-check/link-check.js b/scripts/link-check/link-check.js index 333c759a3f..97b1c912e2 100644 --- a/scripts/link-check/link-check.js +++ b/scripts/link-check/link-check.js @@ -48,11 +48,21 @@ const buildLinkCheckObject = async (link, baseURL) => { } } else { const { href } = getURL(link, baseURL) - const { status, ok } = await memoizedFetch(href) - return { - link, - result: status, - ok + try { + const { status, ok } = await memoizedFetch(href) + return { + link, + href, + result: status, + ok + } + } catch (e) { + return { + link, + href, + result: e.code, + ok: false + } } } } From 64581ff4c89ed7f4f6e1e67755625b90680417ab Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 21:23:53 -0400 Subject: [PATCH 021/174] Move action definition to its own file JS actions have to be this way, but it can still stay in the repo --- .github/workflows/link-check.yml | 4 +--- scripts/link-check/action.js | 2 -- scripts/link-check/action.yml | 18 ++++++++++++++++++ 3 files changed, 19 insertions(+), 5 deletions(-) create mode 100644 scripts/link-check/action.yml diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 647a926207..449274cf23 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,11 +13,9 @@ jobs: - name: Run the link checker id: check + uses: "./scripts/link-check/action.yml" inputs: baseURL: "${{ github.event.deployment_status.target_url }}" - runs: - using: 'node12' - main: 'scripts/link-check/action.js' - uses: LouisBrunner/checks-action@v0.1.0 with: diff --git a/scripts/link-check/action.js b/scripts/link-check/action.js index eae9ef2119..e69ddc3b27 100644 --- a/scripts/link-check/action.js +++ b/scripts/link-check/action.js @@ -18,8 +18,6 @@ try { core.setOutput('summary', 'All new links passed the check!') core.setOutput('conclusion', 'success') } - - core.setOutput('check', report) }) } catch (e) { core.setFailed(`Link checker had an error! (${e.message})`) diff --git a/scripts/link-check/action.yml b/scripts/link-check/action.yml new file mode 100644 index 0000000000..f2bf6b7de0 --- /dev/null +++ b/scripts/link-check/action.yml @@ -0,0 +1,18 @@ +name: 'Link Check' +description: + 'Check that links added to master by the current branch all respond properly' +inputs: + baseURL: + description: 'The base URL that relative links will be resolved with' + required: true + default: 'https://dvc.org' +outputs: + summary: + description: 'A one-line description of the test report' + details: + description: 'A multi-line report of all failed link checks, if any' + conclusion: + description: 'A GitHub Checks-compatible conclusion of the report' +runs: + using: 'node12' + main: 'scripts/link-check/action.js' From 478ba8a84b421b78b11a70de5b32d1821c125b00 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 21:43:23 -0400 Subject: [PATCH 022/174] Add fields to example content to fix required error --- content/blog/2020-07-27-example.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/content/blog/2020-07-27-example.md b/content/blog/2020-07-27-example.md index 0555fbaef1..24fa669643 100644 --- a/content/blog/2020-07-27-example.md +++ b/content/blog/2020-07-27-example.md @@ -1,5 +1,26 @@ --- title: Example +date: 2020-07-07 +description: | + Today we're launching Continuous Machine Learning (CML), a new open-source + project for CI/CD with ML. Let's bring the power of DevOps to ML or MLOps. + +descriptionLong: | + Today we're launching Continuous Machine Learning (CML), a new open-source + project for CI/CD with ML. Use it to automate parts of your ML workflow, + including model training and evaluation, comparing ML experiments across your + project history, and monitoring changing datasets. Let's bring the power of + DevOps to ML or MLOps. + +picture: 2020-07-07/cover.png +pictureComment: CML release +author: dmitry_petrov +commentsUrl: https://discuss.dvc.org/t/continuous-machine-learning-release/429 +tags: + - Release + - CI/CD for ML + - MLOps + - DataOps --- [Google](www.google.com). [this is a 504 forever](httpstat.us/504) From 8f1686f744fea43d3b962866773ecd7be6382e00 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 22:19:28 -0400 Subject: [PATCH 023/174] Fix workflow syntax (inputs -> with) --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 449274cf23..a41359fa58 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -14,7 +14,7 @@ jobs: - name: Run the link checker id: check uses: "./scripts/link-check/action.yml" - inputs: + with: baseURL: "${{ github.event.deployment_status.target_url }}" - uses: LouisBrunner/checks-action@v0.1.0 From 9e0effde8c5fdb1ebb5801cc1ba71077549e8db8 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 22:35:33 -0400 Subject: [PATCH 024/174] Fix output format for action Despite the example on the README, `output` should be a JSON string according to the text docs. --- .github/workflows/link-check.yml | 4 +--- scripts/link-check/action.js | 18 ++++++++++++------ scripts/link-check/action.yml | 7 +++---- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index a41359fa58..b694b14ad4 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -23,6 +23,4 @@ jobs: name: Link Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} - output: - summary: ${{ steps.check.outputs.summary }} - text_description: ${{ steps.check.outputs.description }} + output: ${{ steps.check.outputs.output }} diff --git a/scripts/link-check/action.js b/scripts/link-check/action.js index e69ddc3b27..6a385e3082 100644 --- a/scripts/link-check/action.js +++ b/scripts/link-check/action.js @@ -6,16 +6,22 @@ try { getFailingAddedLinks(core.getInput('baseURL')).then(failedChecks => { // Return either a success message or a report of all failed checks if (failedChecks) { - core.setOutput('summary', 'Some new links failed the check.') core.setOutput( - 'details', - `The following links failed the link check:\n${formatErrors( - failedChecks - )}` + 'output', + JSON.stringify({ + summary: 'Some new links failed the check.', + // eslint-disable-next-line @typescript-eslint/camelcase + text_description: `The following links failed the link check:\n${formatErrors( + failedChecks + )}` + }) ) core.setOutput('conclusion', 'failure') } else { - core.setOutput('summary', 'All new links passed the check!') + core.setOutput( + 'output', + JSON.stringify({ summary: 'All new links passed the check!' }) + ) core.setOutput('conclusion', 'success') } }) diff --git a/scripts/link-check/action.yml b/scripts/link-check/action.yml index f2bf6b7de0..b16a1daaea 100644 --- a/scripts/link-check/action.yml +++ b/scripts/link-check/action.yml @@ -7,10 +7,9 @@ inputs: required: true default: 'https://dvc.org' outputs: - summary: - description: 'A one-line description of the test report' - details: - description: 'A multi-line report of all failed link checks, if any' + output: + description: + 'A JSON string with the test output to be handed to the Check Run' conclusion: description: 'A GitHub Checks-compatible conclusion of the report' runs: From 2c8c1436330964d5f1c13e1c8a6e00a2ed1906c4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 22:45:41 -0400 Subject: [PATCH 025/174] Change invocation of local action to action.yml's parent directory --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index b694b14ad4..9729a5e280 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "./scripts/link-check/action.yml" + uses: "./scripts/link-check" with: baseURL: "${{ github.event.deployment_status.target_url }}" From f7010a9a45e0ab247692121bab8c47c756864e0b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 22:56:25 -0400 Subject: [PATCH 026/174] Change file links to be non-dot relative Seems GH Actions does a simple join to determine paths, so this should be the most correct way. --- .github/workflows/link-check.yml | 2 +- scripts/link-check/action.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 9729a5e280..5f18802e20 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "./scripts/link-check" + uses: "scripts/link-check" with: baseURL: "${{ github.event.deployment_status.target_url }}" diff --git a/scripts/link-check/action.yml b/scripts/link-check/action.yml index b16a1daaea..d4789a6989 100644 --- a/scripts/link-check/action.yml +++ b/scripts/link-check/action.yml @@ -14,4 +14,4 @@ outputs: description: 'A GitHub Checks-compatible conclusion of the report' runs: using: 'node12' - main: 'scripts/link-check/action.js' + main: 'action.js' From 2a501d61de11d4f5597b5a151319c823d573e366 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 23:06:11 -0400 Subject: [PATCH 027/174] Undo `uses` change I guess this way specifically designates it as local, despite the error messages looking odd with an unresolved dot in the path. --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 5f18802e20..9729a5e280 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "scripts/link-check" + uses: "./scripts/link-check" with: baseURL: "${{ github.event.deployment_status.target_url }}" From fdb4b9d8e7d1e3df673c5977b4d8a9a9bde49d24 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 23:48:33 -0400 Subject: [PATCH 028/174] Move Action to its own repo Considering the embedded deps requirement, it's best we just move this action to its own area to avoid complicating the original repo unnecessarily. --- .github/workflows/link-check.yml | 2 +- scripts/link-check/action.js | 30 ------ scripts/link-check/action.yml | 17 ---- scripts/link-check/exclusions.js | 15 --- scripts/link-check/formatting.js | 16 ---- scripts/link-check/index.js | 8 -- scripts/link-check/link-check-git-diff.js | 112 ---------------------- scripts/link-check/link-check.js | 70 -------------- 8 files changed, 1 insertion(+), 269 deletions(-) delete mode 100644 scripts/link-check/action.js delete mode 100644 scripts/link-check/action.yml delete mode 100644 scripts/link-check/exclusions.js delete mode 100644 scripts/link-check/formatting.js delete mode 100644 scripts/link-check/index.js delete mode 100644 scripts/link-check/link-check-git-diff.js delete mode 100644 scripts/link-check/link-check.js diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 9729a5e280..44675b6355 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "./scripts/link-check" + uses: "rogermparent/dvc-github-actions-link-checker" with: baseURL: "${{ github.event.deployment_status.target_url }}" diff --git a/scripts/link-check/action.js b/scripts/link-check/action.js deleted file mode 100644 index 6a385e3082..0000000000 --- a/scripts/link-check/action.js +++ /dev/null @@ -1,30 +0,0 @@ -const core = require('@actions/core') -const { getFailingAddedLinks } = require('./link-check-git-diff.js') -const { formatErrors } = require('./formatting.js') - -try { - getFailingAddedLinks(core.getInput('baseURL')).then(failedChecks => { - // Return either a success message or a report of all failed checks - if (failedChecks) { - core.setOutput( - 'output', - JSON.stringify({ - summary: 'Some new links failed the check.', - // eslint-disable-next-line @typescript-eslint/camelcase - text_description: `The following links failed the link check:\n${formatErrors( - failedChecks - )}` - }) - ) - core.setOutput('conclusion', 'failure') - } else { - core.setOutput( - 'output', - JSON.stringify({ summary: 'All new links passed the check!' }) - ) - core.setOutput('conclusion', 'success') - } - }) -} catch (e) { - core.setFailed(`Link checker had an error! (${e.message})`) -} diff --git a/scripts/link-check/action.yml b/scripts/link-check/action.yml deleted file mode 100644 index d4789a6989..0000000000 --- a/scripts/link-check/action.yml +++ /dev/null @@ -1,17 +0,0 @@ -name: 'Link Check' -description: - 'Check that links added to master by the current branch all respond properly' -inputs: - baseURL: - description: 'The base URL that relative links will be resolved with' - required: true - default: 'https://dvc.org' -outputs: - output: - description: - 'A JSON string with the test output to be handed to the Check Run' - conclusion: - description: 'A GitHub Checks-compatible conclusion of the report' -runs: - using: 'node12' - main: 'action.js' diff --git a/scripts/link-check/exclusions.js b/scripts/link-check/exclusions.js deleted file mode 100644 index 362986365d..0000000000 --- a/scripts/link-check/exclusions.js +++ /dev/null @@ -1,15 +0,0 @@ -const fs = require('fs') -const path = require('path') -const micromatch = require('micromatch') -const excludeList = String( - fs.readFileSync(path.resolve('scripts', 'exclude-links.txt')) -) - .split(/[ \t\r\n]+/) - .filter(Boolean) -const isExcluded = subject => - micromatch.isMatch(subject, excludeList, { bash: true }) - -module.exports = { - excludeList, - isExcluded -} diff --git a/scripts/link-check/formatting.js b/scripts/link-check/formatting.js deleted file mode 100644 index c7e91f0653..0000000000 --- a/scripts/link-check/formatting.js +++ /dev/null @@ -1,16 +0,0 @@ -const formatErrors = errorsByFile => - errorsByFile - .map( - ({ filePath, links }) => - `* ${filePath}:\n${links - .map( - ({ link, href, result }) => - ` - ${link}${ - href && href !== link ? ` (${href})` : '' - } => ${result}` - ) - .join('\n')}` - ) - .join('\n') - -module.exports = formatErrors diff --git a/scripts/link-check/index.js b/scripts/link-check/index.js deleted file mode 100644 index e6e09306f8..0000000000 --- a/scripts/link-check/index.js +++ /dev/null @@ -1,8 +0,0 @@ -// CLI runner for link-check-git-diff -const { getCheckedAddedLinks } = require('./link-check-git-diff.js') -const formatLinks = require('./formatting.js') -const baseURL = process.env.CHECK_LINKS_RELATIVE_URL - -getCheckedAddedLinks(baseURL).then(links => { - console.log(formatLinks(links)) -}) diff --git a/scripts/link-check/link-check-git-diff.js b/scripts/link-check/link-check-git-diff.js deleted file mode 100644 index 0d4403e953..0000000000 --- a/scripts/link-check/link-check-git-diff.js +++ /dev/null @@ -1,112 +0,0 @@ -const path = require('path') -const { exec } = require('child_process') -const mm = require('micromatch') - -const { uniq, flatten } = require('lodash') - -const linkCheck = require('./link-check.js') - -const DEFAULT_BASE_URL = 'https://dvc.org' -const INCLUDED_FILES = ['content/*'] - -const matchFirstGroups = (input, regex) => - Array.from(input.matchAll(regex), x => x[1]) - -const getGitDiff = async () => - new Promise((resolve, reject) => { - exec('git diff origin/master HEAD', (err, stdout) => - err ? reject(err) : resolve(stdout) - ) - }) - -const getAddedLines = async () => { - const splitOutput = (await getGitDiff()).split( - /^diff --git.* b\/(.*)\n(?:.*\n){4}/gm - ) - const processedOutputs = [] - for (let i = 1; i < splitOutput.length; i += 2) { - const additions = splitOutput[i + 1] - .split('\n') - .map(line => line.startsWith('+') && line) - .filter(Boolean) - - if (additions.length > 0) { - processedOutputs.push({ - filePath: splitOutput[i], - additions - }) - } - } - return processedOutputs -} - -const scrapeLinks = (filePath, content) => { - let matchedLinks = [] - const ext = path.extname(filePath) - - switch (ext) { - case '.md': - matchedLinks = matchedLinks.concat( - matchFirstGroups(content, /\[.*?\]\((.*?)\)/gm) - ) - break - case '.html': - matchedLinks = matchedLinks.concat( - matchFirstGroups(content, /href="(.*?)"/gm) - ) - default: - matchedLinks = - content.match(/https?:(\/\/)?(\w+\.)?(\w+)\.([\w\/\.]+)/gm) || [] - break - } - return matchedLinks -} - -const getAddedLinks = async () => - (await getAddedLines()) - .map(({ filePath, additions }) => { - if (!mm.isMatch(filePath, INCLUDED_FILES, { bash: true })) return null - const foundLinks = flatten( - additions.map(line => scrapeLinks(filePath, line)) - ) - if (foundLinks.length > 0) { - return { - filePath, - links: uniq(foundLinks) - } - } - }) - .filter(Boolean) - -const getCheckedAddedLinks = async (baseURL = DEFAULT_BASE_URL) => - Promise.all( - (await getAddedLinks()).map(async ({ filePath, links }) => ({ - filePath, - links: await Promise.all(links.map(link => linkCheck(link, baseURL))) - })) - ) - -const getFailingAddedLinks = async baseURL => { - const checkedLinksByFile = await getCheckedAddedLinks(baseURL) - - // Filter finished linkChecks to only errors - const errorsByFile = checkedLinksByFile - .map(({ filePath, links }) => { - const badLinks = links.filter(link => !link.ok) - return badLinks.length > 0 - ? { - filePath, - links: badLinks - } - : null - }) - .filter(Boolean) - - // Return errors if they exist, or null upon success (like a traditional callback) - return errorsByFile.length > 0 ? errorsByFile : null -} - -module.exports = { - getCheckedAddedLinks, - getFailingAddedLinks -} diff --git a/scripts/link-check/link-check.js b/scripts/link-check/link-check.js deleted file mode 100644 index 97b1c912e2..0000000000 --- a/scripts/link-check/link-check.js +++ /dev/null @@ -1,70 +0,0 @@ -const fetch = require('node-fetch') -const { isExcluded } = require('./exclusions.js') -const MAX_ATTEMPTS = 1 -const ATTEMPT_RETRY_DELAY = 1000 - -const getURL = (link, baseURL) => { - return new URL( - /^(https?:\/)?\//.test(link) ? link : `https://${link}`, - baseURL - ) -} - -const fetchWithRetries = async (href, attempt = 1) => { - const res = await fetch(href) - if (res.status === 504) { - if (attempt < MAX_ATTEMPTS) { - return new Promise(resolve => - setTimeout( - () => fetchWithRetries(href, attempt + 1).then(resolve), - ATTEMPT_RETRY_DELAY - ) - ) - } else { - return res - } - } else { - return res - } -} - -const memo = {} -const memoizedFetch = async href => { - const existing = memo[href] - if (existing) { - return existing - } else { - memo[href] = fetchWithRetries(href) - return memo[href] - } -} - -const buildLinkCheckObject = async (link, baseURL) => { - if (isExcluded(link)) { - return { - link, - result: 'excluded', - ok: true - } - } else { - const { href } = getURL(link, baseURL) - try { - const { status, ok } = await memoizedFetch(href) - return { - link, - href, - result: status, - ok - } - } catch (e) { - return { - link, - href, - result: e.code, - ok: false - } - } - } -} - -module.exports = buildLinkCheckObject From b7130efe64d06ccf19c4306b24d677ae903326ee Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 26 Jul 2020 23:49:50 -0400 Subject: [PATCH 029/174] Revert package.json to master With the action extracted to its own repo, we don't need these here. Also the incremental build flag didn't work so that can go too. --- package.json | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/package.json b/package.json index d159e2c1d4..e21f8753a6 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "scripts": { "develop": "gatsby develop", "dev": "gatsby develop", - "build": "GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES=true gatsby build --log-pages", + "build": "gatsby build", "start": "node ./src/server/index.js", "heroku-postbuild": "./scripts/deploy-with-s3.js", "test": "jest", @@ -34,8 +34,6 @@ "node": ">=12.0.0" }, "dependencies": { - "@actions/core": "^1.2.4", - "@actions/github": "^4.0.0", "@hapi/wreck": "^17.0.0", "@octokit/graphql": "^4.3.1", "@reach/portal": "^0.10.0", @@ -58,11 +56,9 @@ "iso-url": "^0.4.7", "isomorphic-fetch": "^2.2.1", "lodash": "^4.17.19", - "micromatch": "^4.0.2", "moment": "^2.25.3", "nanoid": "^3.0.2", "node-cache": "^5.1.0", - "node-fetch": "^2.6.0", "perfect-scrollbar": "^1.5.0", "pretty-quick": "^2.0.1", "prismjs": "^1.20.0", From a853c23a523fc9c44e3fd6fee44b5f20380ee80e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 00:05:25 -0400 Subject: [PATCH 030/174] Add tag because not having one is invalid --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 44675b6355..a503e10901 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "rogermparent/dvc-github-actions-link-checker" + uses: "rogermparent/dvc-github-actions-link-checker@beta1" with: baseURL: "${{ github.event.deployment_status.target_url }}" From d18039bfeaf8ef7eacc6c3b790a7b1ebd87ade12 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 00:25:36 -0400 Subject: [PATCH 031/174] Change tag to unnumbered "testing" --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index a503e10901..77e7e30160 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "rogermparent/dvc-github-actions-link-checker@beta1" + uses: "rogermparent/dvc-github-actions-link-checker@testing" with: baseURL: "${{ github.event.deployment_status.target_url }}" From 6738e3f66dabff687e094ac5438301f0c1e997e4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 01:08:52 -0400 Subject: [PATCH 032/174] Remove example content --- content/blog/2020-07-07-cml-release.md | 2 -- .../blog/2020-07-24-first-mlops-tutorial.md | 2 -- content/blog/2020-07-27-example.md | 29 ------------------- 3 files changed, 33 deletions(-) delete mode 100644 content/blog/2020-07-27-example.md diff --git a/content/blog/2020-07-07-cml-release.md b/content/blog/2020-07-07-cml-release.md index ce6dd957db..a678666291 100644 --- a/content/blog/2020-07-07-cml-release.md +++ b/content/blog/2020-07-07-cml-release.md @@ -25,8 +25,6 @@ tags: ## CI/CD for machine learning -[This link doesn't exist](https://example.com/link/that/surely/doesnotexist) - Today, the DVC team is releasing a new open-source project called Continuous Machine Learning, or CML (https://cml.dev) to mainstream the best engineering practices of CI/CD to AI and ML teams. CML helps to organize MLOps diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index 0a3e68a721..11c1f8bd00 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -25,8 +25,6 @@ DevOps practices (like continuous integration) as a regular fixture of machine learning and data science projects. But there are plenty of challenges ahead, and a big one is _literacy_. -[Relative broken link](/not/a/real/path) - So many data scientists, like developers, are self-taught. Data science degrees have only recently emerged on the scene, which means if you polled a handful of senior-level data scientists, there'd almost certainly be no universal training diff --git a/content/blog/2020-07-27-example.md b/content/blog/2020-07-27-example.md deleted file mode 100644 index 24fa669643..0000000000 --- a/content/blog/2020-07-27-example.md +++ /dev/null @@ -1,29 +0,0 @@ ---- -title: Example -date: 2020-07-07 -description: | - Today we're launching Continuous Machine Learning (CML), a new open-source - project for CI/CD with ML. Let's bring the power of DevOps to ML or MLOps. - -descriptionLong: | - Today we're launching Continuous Machine Learning (CML), a new open-source - project for CI/CD with ML. Use it to automate parts of your ML workflow, - including model training and evaluation, comparing ML experiments across your - project history, and monitoring changing datasets. Let's bring the power of - DevOps to ML or MLOps. - -picture: 2020-07-07/cover.png -pictureComment: CML release -author: dmitry_petrov -commentsUrl: https://discuss.dvc.org/t/continuous-machine-learning-release/429 -tags: - - Release - - CI/CD for ML - - MLOps - - DataOps ---- - -[Google](www.google.com). [this is a 504 forever](httpstat.us/504) -[this is a 504 forever](httpstat.us/504) -[this is a 504 forever](httpstat.us/504) -[this should be excluded](https://myendpoint.com) From 2d1601a210e9735c5e205e7b243f91ba9b512ca4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 01:33:36 -0400 Subject: [PATCH 033/174] Change `uses` tag to `rc1` instead of `testing` --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 77e7e30160..268eaf2cc3 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "rogermparent/dvc-github-actions-link-checker@testing" + uses: "rogermparent/dvc-github-actions-link-checker@rc1" with: baseURL: "${{ github.event.deployment_status.target_url }}" From 4c009f70deefb15739f817f85e4f770ec15c5363 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 01:41:00 -0400 Subject: [PATCH 034/174] Revert original shell script link checkers to master versions --- scripts/link-check.sh | 2 +- scripts/utils.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/link-check.sh b/scripts/link-check.sh index 229171c249..4db2374667 100755 --- a/scripts/link-check.sh +++ b/scripts/link-check.sh @@ -6,7 +6,7 @@ # link-check.sh [] set -euo pipefail -source ./scripts/utils.sh +source "$(dirname "$0")"/utils.sh checker(){ # expects list of urls errors=0 diff --git a/scripts/utils.sh b/scripts/utils.sh index 76f7f3c9af..85bd8efeb4 100644 --- a/scripts/utils.sh +++ b/scripts/utils.sh @@ -3,9 +3,9 @@ # Defines: # repo, base_url, exclude, user_agent, urlfinder() -repo="$(dirname "$(realpath "./scripts")")" +repo="$(dirname "$(realpath "$(dirname "$0")")")" base_url="${CHECK_LINKS_RELATIVE_URL:-https://dvc.org}" -exclude="${CHECK_LINKS_EXCLUDE_LIST:-./scripts/exclude-links.txt}" +exclude="${CHECK_LINKS_EXCLUDE_LIST:-$(dirname "$0")/exclude-links.txt}" [ -f "$exclude" ] && exclude="$(cat "$exclude")" user_agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:74.0) Gecko/20100101 Firefox/74.0" From e92b088992edca97d4249ae25d121812d033ffe2 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 01:43:38 -0400 Subject: [PATCH 035/174] Revert yarn.lock to master --- yarn.lock | 123 +----------------------------------------------------- 1 file changed, 2 insertions(+), 121 deletions(-) diff --git a/yarn.lock b/yarn.lock index c2f18955b9..17245b2ff3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -11,28 +11,6 @@ deep-eql "^0.1.3" keypather "^1.10.2" -"@actions/core@^1.2.4": - version "1.2.4" - resolved "https://registry.yarnpkg.com/@actions/core/-/core-1.2.4.tgz#96179dbf9f8d951dd74b40a0dbd5c22555d186ab" - integrity sha512-YJCEq8BE3CdN8+7HPZ/4DxJjk/OkZV2FFIf+DlZTC/4iBlzYCD5yjRR6eiOS5llO11zbRltIRuKAjMKaWTE6cg== - -"@actions/github@^4.0.0": - version "4.0.0" - resolved "https://registry.yarnpkg.com/@actions/github/-/github-4.0.0.tgz#d520483151a2bf5d2dc9cd0f20f9ac3a2e458816" - integrity sha512-Ej/Y2E+VV6sR9X7pWL5F3VgEWrABaT292DRqRU6R4hnQjPtC/zD3nagxVdXWiRQvYDh8kHXo7IDmG42eJ/dOMA== - dependencies: - "@actions/http-client" "^1.0.8" - "@octokit/core" "^3.0.0" - "@octokit/plugin-paginate-rest" "^2.2.3" - "@octokit/plugin-rest-endpoint-methods" "^4.0.0" - -"@actions/http-client@^1.0.8": - version "1.0.8" - resolved "https://registry.yarnpkg.com/@actions/http-client/-/http-client-1.0.8.tgz#8bd76e8eca89dc8bcf619aa128eba85f7a39af45" - integrity sha512-G4JjJ6f9Hb3Zvejj+ewLLKLf99ZC+9v+yCxoYf9vSyH+WkzPLB2LuUtRMGNkooMqdugGBFStIKXOuvH1W+EctA== - dependencies: - tunnel "0.0.6" - "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.8.3": version "7.8.3" resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.8.3.tgz#33e25903d7481181534e12ec0a25f16b6fcf419e" @@ -1633,25 +1611,6 @@ "@nodelib/fs.scandir" "2.1.3" fastq "^1.6.0" -"@octokit/auth-token@^2.4.0": - version "2.4.2" - resolved "https://registry.yarnpkg.com/@octokit/auth-token/-/auth-token-2.4.2.tgz#10d0ae979b100fa6b72fa0e8e63e27e6d0dbff8a" - integrity sha512-jE/lE/IKIz2v1+/P0u4fJqv0kYwXOTujKemJMFr6FeopsxlIK3+wKDCJGnysg81XID5TgZQbIfuJ5J0lnTiuyQ== - dependencies: - "@octokit/types" "^5.0.0" - -"@octokit/core@^3.0.0": - version "3.1.1" - resolved "https://registry.yarnpkg.com/@octokit/core/-/core-3.1.1.tgz#1856745aa8fb154cf1544a2a1b82586c809c5e66" - integrity sha512-cQ2HGrtyNJ1IBxpTP1U5m/FkMAJvgw7d2j1q3c9P0XUuYilEgF6e4naTpsgm4iVcQeOnccZlw7XHRIUBy0ymcg== - dependencies: - "@octokit/auth-token" "^2.4.0" - "@octokit/graphql" "^4.3.1" - "@octokit/request" "^5.4.0" - "@octokit/types" "^5.0.0" - before-after-hook "^2.1.0" - universal-user-agent "^6.0.0" - "@octokit/endpoint@^6.0.1": version "6.0.1" resolved "https://registry.yarnpkg.com/@octokit/endpoint/-/endpoint-6.0.1.tgz#16d5c0e7a83e3a644d1ddbe8cded6c3d038d31d7" @@ -1670,21 +1629,6 @@ "@octokit/types" "^4.0.1" universal-user-agent "^5.0.0" -"@octokit/plugin-paginate-rest@^2.2.3": - version "2.3.0" - resolved "https://registry.yarnpkg.com/@octokit/plugin-paginate-rest/-/plugin-paginate-rest-2.3.0.tgz#7d1073e56cfd15d3f99dcfe81fa5d2b466f3a6f6" - integrity sha512-Ye2ZJreP0ZlqJQz8fz+hXvrEAEYK4ay7br1eDpWzr6j76VXs/gKqxFcH8qRzkB3fo/2xh4Vy9VtGii4ZDc9qlA== - dependencies: - "@octokit/types" "^5.2.0" - -"@octokit/plugin-rest-endpoint-methods@^4.0.0": - version "4.1.2" - resolved "https://registry.yarnpkg.com/@octokit/plugin-rest-endpoint-methods/-/plugin-rest-endpoint-methods-4.1.2.tgz#546a8f3e0b514f434a4ad4ef926005f1c81a5a5a" - integrity sha512-PTI7wpbGEZ2IR87TVh+TNWaLcgX/RsZQalFbQCq8XxYUrQ36RHyERrHSNXFy5gkWpspUAOYRSV707JJv6BhqJA== - dependencies: - "@octokit/types" "^5.1.1" - deprecation "^2.3.1" - "@octokit/request-error@^2.0.0": version "2.0.1" resolved "https://registry.yarnpkg.com/@octokit/request-error/-/request-error-2.0.1.tgz#49bd71e811daffd5bdd06ef514ca47b5039682d1" @@ -1708,20 +1652,6 @@ once "^1.4.0" universal-user-agent "^5.0.0" -"@octokit/request@^5.4.0": - version "5.4.7" - resolved "https://registry.yarnpkg.com/@octokit/request/-/request-5.4.7.tgz#fd703ee092e0463ceba49ff7a3e61cb4cf8a0fde" - integrity sha512-FN22xUDP0i0uF38YMbOfx6TotpcENP5W8yJM1e/LieGXn6IoRxDMnBf7tx5RKSW4xuUZ/1P04NFZy5iY3Rax1A== - dependencies: - "@octokit/endpoint" "^6.0.1" - "@octokit/request-error" "^2.0.0" - "@octokit/types" "^5.0.0" - deprecation "^2.0.0" - is-plain-object "^4.0.0" - node-fetch "^2.3.0" - once "^1.4.0" - universal-user-agent "^6.0.0" - "@octokit/types@^2.11.1": version "2.16.2" resolved "https://registry.yarnpkg.com/@octokit/types/-/types-2.16.2.tgz#4c5f8da3c6fecf3da1811aef678fda03edac35d2" @@ -1736,13 +1666,6 @@ dependencies: "@types/node" ">= 8" -"@octokit/types@^5.0.0", "@octokit/types@^5.1.1", "@octokit/types@^5.2.0": - version "5.2.0" - resolved "https://registry.yarnpkg.com/@octokit/types/-/types-5.2.0.tgz#d075dc23bf293f540739250b6879e2c1be2fc20c" - integrity sha512-XjOk9y4m8xTLIKPe1NFxNWBdzA2/z3PFFA/bwf4EoH6oS8hM0Y46mEa4Cb+KCyj/tFDznJFahzQ0Aj3o1FYq4A== - dependencies: - "@types/node" ">= 8" - "@pieh/friendly-errors-webpack-plugin@1.7.0-chalk-2": version "1.7.0-chalk-2" resolved "https://registry.yarnpkg.com/@pieh/friendly-errors-webpack-plugin/-/friendly-errors-webpack-plugin-1.7.0-chalk-2.tgz#2e9da9d3ade9d18d013333eb408c457d04eabac0" @@ -3374,11 +3297,6 @@ bcrypt-pbkdf@^1.0.0: dependencies: tweetnacl "^0.14.3" -before-after-hook@^2.1.0: - version "2.1.0" - resolved "https://registry.yarnpkg.com/before-after-hook/-/before-after-hook-2.1.0.tgz#b6c03487f44e24200dd30ca5e6a1979c5d2fb635" - integrity sha512-IWIbu7pMqyw3EAJHzzHbWa85b6oud/yfKYg5rqB5hNE8CeMi3nX+2C2sj0HswfblST86hpVEOAb9x34NZd6P7A== - better-assert@~1.0.0: version "1.0.2" resolved "https://registry.yarnpkg.com/better-assert/-/better-assert-1.0.2.tgz#40866b9e1b9e0b55b481894311e68faffaebc522" @@ -5337,7 +5255,7 @@ depd@~1.1.2: resolved "https://registry.yarnpkg.com/depd/-/depd-1.1.2.tgz#9bcd52e14c097763e749b274c4346ed2e560b5a9" integrity sha1-m81S4UwJd2PnSbJ0xDRu0uVgtak= -deprecation@^2.0.0, deprecation@^2.3.1: +deprecation@^2.0.0: version "2.3.1" resolved "https://registry.yarnpkg.com/deprecation/-/deprecation-2.3.1.tgz#6368cbdb40abf3373b525ac87e4a260c3a700919" integrity sha512-xmHIy4F3scKVwMsQ4WnVaS8bHOx0DmVwRywosKhaILI0ywMDWPtBSku2HNxRvF7jtwDRsoEwYQSfbxj8b7RlJQ== @@ -9611,11 +9529,6 @@ is-plain-object@^3.0.0: dependencies: isobject "^4.0.0" -is-plain-object@^4.0.0: - version "4.1.1" - resolved "https://registry.yarnpkg.com/is-plain-object/-/is-plain-object-4.1.1.tgz#1a14d6452cbd50790edc7fdaa0aed5a40a35ebb5" - integrity sha512-5Aw8LLVsDlZsETVMhoMXzqsXwQqr/0vlnBYzIXJbYo2F4yYlhLHs+Ez7Bod7IIQKWkJbJfxrWD7pA1Dw1TKrwA== - is-png@^1.0.0: version "1.1.0" resolved "https://registry.yarnpkg.com/is-png/-/is-png-1.1.0.tgz#d574b12bf275c0350455570b0e5b57ab062077ce" @@ -14267,7 +14180,7 @@ remark-mdx@^1.6.4: remark-parse "8.0.2" unified "9.0.0" -remark-parse@8.0.2, remark-parse@^8.0.0: +remark-parse@8.0.2, remark-parse@^8.0.0, remark-parse@^8.0.2: version "8.0.2" resolved "https://registry.yarnpkg.com/remark-parse/-/remark-parse-8.0.2.tgz#5999bc0b9c2e3edc038800a64ff103d0890b318b" integrity sha512-eMI6kMRjsAGpMXXBAywJwiwAse+KNpmt+BK55Oofy4KvBZEqUDj6mWbGLJZrujoPIPPxDXzn3T9baRlpsm2jnQ== @@ -14325,28 +14238,6 @@ remark-parse@^6.0.0, remark-parse@^6.0.3: vfile-location "^2.0.0" xtend "^4.0.1" -remark-parse@^8.0.2: - version "8.0.3" - resolved "https://registry.yarnpkg.com/remark-parse/-/remark-parse-8.0.3.tgz#9c62aa3b35b79a486454c690472906075f40c7e1" - integrity sha512-E1K9+QLGgggHxCQtLt++uXltxEprmWzNfg+MxpfHsZlrddKzZ/hZyWHDbK3/Ap8HJQqYJRXP+jHczdL6q6i85Q== - dependencies: - ccount "^1.0.0" - collapse-white-space "^1.0.2" - is-alphabetical "^1.0.0" - is-decimal "^1.0.0" - is-whitespace-character "^1.0.0" - is-word-character "^1.0.0" - markdown-escapes "^1.0.0" - parse-entities "^2.0.0" - repeat-string "^1.5.4" - state-toggle "^1.0.0" - trim "0.0.1" - trim-trailing-lines "^1.0.0" - unherit "^1.0.4" - unist-util-remove-position "^2.0.0" - vfile-location "^3.0.0" - xtend "^4.0.1" - remark-retext@^3.1.3: version "3.1.3" resolved "https://registry.yarnpkg.com/remark-retext/-/remark-retext-3.1.3.tgz#77173b1d9d13dab15ce5b38d996195fea522ee7f" @@ -16610,11 +16501,6 @@ tunnel-agent@^0.6.0: dependencies: safe-buffer "^5.0.1" -tunnel@0.0.6: - version "0.0.6" - resolved "https://registry.yarnpkg.com/tunnel/-/tunnel-0.0.6.tgz#72f1314b34a5b192db012324df2cc587ca47f92c" - integrity sha512-1h/Lnq9yajKY2PEbBadPXj3VxsDDu844OnaAo52UVmIzIvwwtBPIuNvkjuzBlTWpfJyUbG3ez0KSBibQkj4ojg== - tweetnacl@^0.14.3, tweetnacl@~0.14.0: version "0.14.5" resolved "https://registry.yarnpkg.com/tweetnacl/-/tweetnacl-0.14.5.tgz#5ae68177f192d4456269d108afa93ff8743f4f64" @@ -17002,11 +16888,6 @@ universal-user-agent@^5.0.0: dependencies: os-name "^3.1.0" -universal-user-agent@^6.0.0: - version "6.0.0" - resolved "https://registry.yarnpkg.com/universal-user-agent/-/universal-user-agent-6.0.0.tgz#3381f8503b251c0d9cd21bc1de939ec9df5480ee" - integrity sha512-isyNax3wXoKaulPDZWHQqbmIx1k2tb9fb3GGDBRxCscfYV2Ch7WxPArBsFEG8s/safwXTT7H4QGhaIkTp9447w== - universalify@^0.1.0: version "0.1.2" resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.1.2.tgz#b646f69be3942dabcecc9d6639c80dc105efaa66" From e64aea627472fb343f84858679073aeca37f8592 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 02:08:21 -0400 Subject: [PATCH 036/174] Add example towarddatascience link to test 405 behavior --- content/blog/2020-07-24-first-mlops-tutorial.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index 11c1f8bd00..cfec63b988 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -19,6 +19,8 @@ tags: - CML --- +[AUC value](https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5) + Earlier this month, we launched [CML](https;//cml.dev), our latest open-source project in the MLOps space. We think it's a step towards establishing powerful DevOps practices (like continuous integration) as a regular fixture of machine From f647e71e052f567553114fa6a34b417d3a4455f0 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 02:16:08 -0400 Subject: [PATCH 037/174] Make a more comprehensive example set --- content/blog/2020-07-24-first-mlops-tutorial.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index cfec63b988..d41cf40fdf 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -19,7 +19,12 @@ tags: - CML --- -[AUC value](https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5) +[working absolute](https://www.google.com) +[broken absolute on existing site](https://example.com/not/a/real/page) +[non-existent site](https://thisisnotarealsiteandihopenobodyregistersit.us) +[good relative](/doc) [broken relative](/a/page/that/doesnt/exist) +[TDS 405 test](https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5) +[casual link with no protocol](google.com) [excluded](https://myendpoint.com) Earlier this month, we launched [CML](https;//cml.dev), our latest open-source project in the MLOps space. We think it's a step towards establishing powerful From 143694cc9c365d7583ff955eac6fad35ccb90114 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 02:27:00 -0400 Subject: [PATCH 038/174] Add duplicate test link --- content/blog/2020-07-24-first-mlops-tutorial.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index d41cf40fdf..05ac21f11c 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -25,6 +25,7 @@ tags: [good relative](/doc) [broken relative](/a/page/that/doesnt/exist) [TDS 405 test](https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5) [casual link with no protocol](google.com) [excluded](https://myendpoint.com) +[broken absolute on existing site 2](https://example.com/not/a/real/page) Earlier this month, we launched [CML](https;//cml.dev), our latest open-source project in the MLOps space. We think it's a step towards establishing powerful From 42c5129578102ebc9a4a0cd05d82846d3301f233 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 02:57:57 -0400 Subject: [PATCH 039/174] Update action to rc2 for full reports every time --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 268eaf2cc3..cda74e444e 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "rogermparent/dvc-github-actions-link-checker@rc1" + uses: "rogermparent/dvc-github-actions-link-checker@rc2" with: baseURL: "${{ github.event.deployment_status.target_url }}" From 47f59b34bb5da57f80346590e917be0488854e4b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 03:26:33 -0400 Subject: [PATCH 040/174] Update workflow to use instead of --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index cda74e444e..9485f0c704 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -15,7 +15,7 @@ jobs: id: check uses: "rogermparent/dvc-github-actions-link-checker@rc2" with: - baseURL: "${{ github.event.deployment_status.target_url }}" + baseURL: "${{ github.event.deployment_status.url }}" - uses: LouisBrunner/checks-action@v0.1.0 with: From a54049f78eed82af82b4164ef32b4969923517d9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 03:49:06 -0400 Subject: [PATCH 041/174] Fix deployment url target variable again --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 9485f0c704..84f9263f78 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -15,7 +15,7 @@ jobs: id: check uses: "rogermparent/dvc-github-actions-link-checker@rc2" with: - baseURL: "${{ github.event.deployment_status.url }}" + baseURL: "${{ github.event.deployment.url }}" - uses: LouisBrunner/checks-action@v0.1.0 with: From 94924121b7ef650f326da526e2b1cc4efdbd73e7 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 04:28:26 -0400 Subject: [PATCH 042/174] Add yet another change to deploy URL access This time, though, I actually checked the V3 API! I think this will be the big one. --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 84f9263f78..1080789664 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -15,7 +15,7 @@ jobs: id: check uses: "rogermparent/dvc-github-actions-link-checker@rc2" with: - baseURL: "${{ github.event.deployment.url }}" + baseURL: "${{ github.event.deployment.payload.web_url }}" - uses: LouisBrunner/checks-action@v0.1.0 with: From 10c6797ae27f11e954f4ccc61610bbddf8c70d8a Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 04:43:21 -0400 Subject: [PATCH 043/174] Remove towardsdatascience from link exclusions --- scripts/exclude-links.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 785f34e15c..84681f2b9f 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -34,7 +34,5 @@ https://www.youtube.com/embed/$ http://user@example.com/path http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject -https://towardsdatascience.com/why-git-and-how-to-use-git-as-a-data-scientist-4fa2d3bdc197 -https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5 https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 From ad7db7fc35d29b65b0a45e0132b92e7c7bc252e3 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 27 Jul 2020 04:50:33 -0400 Subject: [PATCH 044/174] Return content to normal --- content/blog/2020-07-24-first-mlops-tutorial.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index 05ac21f11c..11c1f8bd00 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -19,14 +19,6 @@ tags: - CML --- -[working absolute](https://www.google.com) -[broken absolute on existing site](https://example.com/not/a/real/page) -[non-existent site](https://thisisnotarealsiteandihopenobodyregistersit.us) -[good relative](/doc) [broken relative](/a/page/that/doesnt/exist) -[TDS 405 test](https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5) -[casual link with no protocol](google.com) [excluded](https://myendpoint.com) -[broken absolute on existing site 2](https://example.com/not/a/real/page) - Earlier this month, we launched [CML](https;//cml.dev), our latest open-source project in the MLOps space. We think it's a step towards establishing powerful DevOps practices (like continuous integration) as a regular fixture of machine From 86176eb826d65bc71bd4081d02f9c83ed4e6c7aa Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 13:50:35 -0400 Subject: [PATCH 045/174] Remove old link check scripts --- scripts/exclude-links-check.sh | 17 ------------ scripts/link-check-git-all.sh | 16 ----------- scripts/link-check-git-diff.sh | 20 -------------- scripts/link-check.sh | 50 ---------------------------------- scripts/utils.sh | 23 ---------------- 5 files changed, 126 deletions(-) delete mode 100755 scripts/exclude-links-check.sh delete mode 100755 scripts/link-check-git-all.sh delete mode 100755 scripts/link-check-git-diff.sh delete mode 100755 scripts/link-check.sh delete mode 100644 scripts/utils.sh diff --git a/scripts/exclude-links-check.sh b/scripts/exclude-links-check.sh deleted file mode 100755 index bf18ba9d74..0000000000 --- a/scripts/exclude-links-check.sh +++ /dev/null @@ -1,17 +0,0 @@ -#!/usr/bin/env bash -# Checks that `exclude-links.txt` contains only used links. -set -euo pipefail - -source "$(dirname "$0")"/utils.sh - -missing="$( - urlfinder "$base_url" $(git ls-files '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js') \ - | sed 's/#.*//g' | sort -u \ - | comm -13 - <(echo "$exclude" | sort -u) -)" - -if [[ -n "$missing" ]]; then - echo "ERROR:Exclusions not found in codebase:" >&2 - echo "$missing" | sed 's/^/ /' >&2 - exit 1 -fi diff --git a/scripts/link-check-git-all.sh b/scripts/link-check-git-all.sh deleted file mode 100755 index d4231395d4..0000000000 --- a/scripts/link-check-git-all.sh +++ /dev/null @@ -1,16 +0,0 @@ -#!/usr/bin/env bash -set -euo pipefail - -source "$(dirname "$0")"/utils.sh -pushd "$repo" - -# can't do git ls-files since some may be untracked -( - find .github/ content/docs/ src/ \ - -name '*.css' -o -name '*.js' -o -name '*.jsx' -o -name '*.md' -o -name '*.tsx' -o \ - -name '*.ts' -o -name '*.json' - ls *.css *.js *.jsx *.md *.tsx *.ts *.json 2>/dev/null || : -) | grep -Ev '(package-lock\.json|redirects-list\.json|\.test\.js)$' \ - | xargs -n1 -P8 "$(dirname "$0")"/link-check.sh - -popd diff --git a/scripts/link-check-git-diff.sh b/scripts/link-check-git-diff.sh deleted file mode 100755 index 5376aeae7d..0000000000 --- a/scripts/link-check-git-diff.sh +++ /dev/null @@ -1,20 +0,0 @@ -#!/usr/bin/env bash -set -euo pipefail - -source "$(dirname "$0")"/utils.sh -pushd "$repo" - -differ="git diff $(git merge-base HEAD origin/master)" -changed="$($differ --name-only -- '*.css' '*.js' '*.jsx' '*.md' '*.tsx' '*.ts' '*.json' ':!redirects-list.json' ':!*.test.js')" - -[ -z "$changed" ] && exit 0 - -echo "$changed" | while read -r file ; do - # check whole file - # "$(dirname "$0")"/link-check.sh "$file" - # check just changed lines - echo -n "$file:" - "$(dirname "$0")"/link-check.sh <($differ -U0 -- "$file" | grep '^\+') -done - -popd diff --git a/scripts/link-check.sh b/scripts/link-check.sh deleted file mode 100755 index 4db2374667..0000000000 --- a/scripts/link-check.sh +++ /dev/null @@ -1,50 +0,0 @@ -#!/usr/bin/env bash -# Check HTTP status codes of links in the given files. -# Success: 2xx, Errors: 4xx/5xx, Warnings: anything else. -# Redirects (3xx) are followed. -# Usage: -# link-check.sh [] -set -euo pipefail - -source "$(dirname "$0")"/utils.sh - -checker(){ # expects list of urls - errors=0 - for url in "$@"; do - status="$(curl -IL -A "$user_agent" -w '%{http_code}' -so /dev/null "$url")" - case "$status" in - 2??) - # success - ;; - 429) - # too many requests: treat as success - ;; - 999) - # linkedin denied code: treat as success - ;; - [45]??) - echo - echo " ERROR:$status:$url" >&2 - errors=$(($errors + 1)) - ;; - *) - echo - echo " WARNING:$status:$url" >&2 - ;; - esac - done - return $errors -} - -fails=0 -for file in "$@"; do - echo -n "$file:" - prev=$fails - checker $(urlfinder "$base_url" "$file" | sed 's/#.*//g' | sort -u \ - | comm -23 - <(echo "$exclude" | sort -u)) \ - || fails=$(($fails + 1)) - [ $prev -eq $fails ] && echo OK -done - -[ $fails -eq 0 ] || echo -e "ERROR:$fails failures\n---" >&2 -exit $fails diff --git a/scripts/utils.sh b/scripts/utils.sh deleted file mode 100644 index 85bd8efeb4..0000000000 --- a/scripts/utils.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash -# Common utility functions and helpers for link-check. -# Defines: -# repo, base_url, exclude, user_agent, urlfinder() - -repo="$(dirname "$(realpath "$(dirname "$0")")")" -base_url="${CHECK_LINKS_RELATIVE_URL:-https://dvc.org}" -exclude="${CHECK_LINKS_EXCLUDE_LIST:-$(dirname "$0")/exclude-links.txt}" -[ -f "$exclude" ] && exclude="$(cat "$exclude")" -user_agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:74.0) Gecko/20100101 Firefox/74.0" - -urlfinder(){ # expects ... - base_url="$1" - content="$(cat "${@:2}")" # read once (could be file descriptors) - # explicit links not in markdown - echo "$content" | pcregrep -o '(?{}"'"'"'`]+' - # explicit links in markdown - echo "$content" | pcregrep -o '(?<=\])\(https?://[^[\]\s]+\)' | pcregrep -o '\((?:[^)(]*(?R)?)*+\)' | pcregrep -o '(?<=\().*(?=\))' - # relative links in markdown - echo "$content" | sed -nE 's/.*]\((\/[^)[:space:]]+).*/\1/p' | xargs -n1 -II echo ${base_url}I - # relative links in html - echo "$content" | sed -nE 's/.*href=["'"'"'](\/[^"'"'"']+)["'"'"'].*/\1/p' | xargs -n1 -II echo ${base_url}I -} From 921b17032ef99c3b0b0a57f00a534b02a6fd3f12 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 19:27:12 -0400 Subject: [PATCH 046/174] Add link checker CLI package --- package.json | 1 + yarn.lock | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/package.json b/package.json index e21f8753a6..3cb72b52a6 100644 --- a/package.json +++ b/package.json @@ -103,6 +103,7 @@ "babel-jest": "^26.0.1", "babel-plugin-transform-define": "^2.0.0", "babel-plugin-transform-object-assign": "^6.22.0", + "dvc-github-actions-link-checker": "^0.0.4", "eslint": "^6.8.0", "eslint-config-prettier": "^6.10.1", "eslint-plugin-json": "^2.1.1", diff --git a/yarn.lock b/yarn.lock index 17245b2ff3..1054887edd 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5617,6 +5617,15 @@ duplexify@^3.4.2, duplexify@^3.6.0: readable-stream "^2.0.0" stream-shift "^1.0.0" +dvc-github-actions-link-checker@^0.0.4: + version "0.0.4" + resolved "https://registry.yarnpkg.com/dvc-github-actions-link-checker/-/dvc-github-actions-link-checker-0.0.4.tgz#4141b19ae00d5ad92891fcba0e37e695da8db436" + integrity sha512-QvWRnmSglt47Jtqxf70KQxXGPrO8pkflh9Xe/aRfJNJ4PYeAQyd1nbBn3Hzza6aehBVEgFIa0lrhdfeQ9n8v5A== + dependencies: + lodash "^4.17.19" + micromatch "^4.0.2" + node-fetch "^2.6.0" + ease-component@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/ease-component/-/ease-component-1.0.0.tgz#b375726db0b5b04595b77440396fec7daa5d77c9" From a09583b4332a941b975a4922ca5f40d5b3aac199 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 19:29:30 -0400 Subject: [PATCH 047/174] Remove old link check scripts and add new one to Husky pre-commit --- package.json | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 3cb72b52a6..bd36e01ef7 100644 --- a/package.json +++ b/package.json @@ -15,10 +15,7 @@ "format-all": "prettier --write '**/*.{js,jsx,md,tsx,ts,json}'", "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", - "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "./scripts/link-check-git-all.sh", - "link-check-diff": "./scripts/link-check-git-diff.sh", - "link-check-exclude": "./scripts/exclude-links-check.sh" + "lint-css": "stylelint \"src/**/*.css\"" }, "repository": { "type": "git", @@ -158,7 +155,7 @@ }, "husky": { "hooks": { - "pre-commit": "yarn format-staged && yarn lint-staged" + "pre-commit": "yarn format-staged && yarn lint-staged && yarn run link-check-git-diff" } }, "lint-staged": { From d1837e941150a2ffee0c98be3637fdc77e93b3d5 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 19:38:38 -0400 Subject: [PATCH 048/174] Update CLI package --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index bd36e01ef7..51c622dae1 100644 --- a/package.json +++ b/package.json @@ -100,7 +100,7 @@ "babel-jest": "^26.0.1", "babel-plugin-transform-define": "^2.0.0", "babel-plugin-transform-object-assign": "^6.22.0", - "dvc-github-actions-link-checker": "^0.0.4", + "dvc-github-actions-link-checker": "^0.0.5", "eslint": "^6.8.0", "eslint-config-prettier": "^6.10.1", "eslint-plugin-json": "^2.1.1", diff --git a/yarn.lock b/yarn.lock index 1054887edd..c5d095f1d2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5617,10 +5617,10 @@ duplexify@^3.4.2, duplexify@^3.6.0: readable-stream "^2.0.0" stream-shift "^1.0.0" -dvc-github-actions-link-checker@^0.0.4: - version "0.0.4" - resolved "https://registry.yarnpkg.com/dvc-github-actions-link-checker/-/dvc-github-actions-link-checker-0.0.4.tgz#4141b19ae00d5ad92891fcba0e37e695da8db436" - integrity sha512-QvWRnmSglt47Jtqxf70KQxXGPrO8pkflh9Xe/aRfJNJ4PYeAQyd1nbBn3Hzza6aehBVEgFIa0lrhdfeQ9n8v5A== +dvc-github-actions-link-checker@^0.0.5: + version "0.0.5" + resolved "https://registry.yarnpkg.com/dvc-github-actions-link-checker/-/dvc-github-actions-link-checker-0.0.5.tgz#cad2d8b8bf8e56105092bc2fa16c6fd653c5b458" + integrity sha512-dgZeHOUe4aKcyZTlOtm3KrERJK3eIY4HLBF3NoFfOdgAs8OsGPgJr9oVP2pi4UsS+8VBVFEMJnOoxKgAioXG9w== dependencies: lodash "^4.17.19" micromatch "^4.0.2" From aa83a61a3a5a88cb37bbe98328bc4287f6c7c9f7 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 21:59:07 -0400 Subject: [PATCH 049/174] Upgrade to latest link checker This version uses exit code 0 always by default, so it doesn't block CI. The behavior can be overridden with an env var. --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 51c622dae1..a920ddc55e 100644 --- a/package.json +++ b/package.json @@ -100,7 +100,7 @@ "babel-jest": "^26.0.1", "babel-plugin-transform-define": "^2.0.0", "babel-plugin-transform-object-assign": "^6.22.0", - "dvc-github-actions-link-checker": "^0.0.5", + "dvc-github-actions-link-checker": "^0.0.8", "eslint": "^6.8.0", "eslint-config-prettier": "^6.10.1", "eslint-plugin-json": "^2.1.1", diff --git a/yarn.lock b/yarn.lock index c5d095f1d2..e1d1818eb2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5617,10 +5617,10 @@ duplexify@^3.4.2, duplexify@^3.6.0: readable-stream "^2.0.0" stream-shift "^1.0.0" -dvc-github-actions-link-checker@^0.0.5: - version "0.0.5" - resolved "https://registry.yarnpkg.com/dvc-github-actions-link-checker/-/dvc-github-actions-link-checker-0.0.5.tgz#cad2d8b8bf8e56105092bc2fa16c6fd653c5b458" - integrity sha512-dgZeHOUe4aKcyZTlOtm3KrERJK3eIY4HLBF3NoFfOdgAs8OsGPgJr9oVP2pi4UsS+8VBVFEMJnOoxKgAioXG9w== +dvc-github-actions-link-checker@^0.0.8: + version "0.0.8" + resolved "https://registry.yarnpkg.com/dvc-github-actions-link-checker/-/dvc-github-actions-link-checker-0.0.8.tgz#47471bdcd5e178b5b3a807636596001a78f2a660" + integrity sha512-SZKGuKE2/RcYUrQRguipAMC3WN4hKvwL1EjJOW13NZx+2Ceo0CpFk/eW/tI1ZdlsKs1UVAgoXa22Rifjvrc6ag== dependencies: lodash "^4.17.19" micromatch "^4.0.2" From a74cc0308a0ac2ff361a3f32f3b0f513239637eb Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 22:04:11 -0400 Subject: [PATCH 050/174] Point `uses` to new link checker action dist repo --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 1080789664..3ed41d3bbd 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "rogermparent/dvc-github-actions-link-checker@rc2" + uses: "rogermparent/dvc-github-actions-link-checker.dist@master" with: baseURL: "${{ github.event.deployment.payload.web_url }}" From 5872abd0773441782c7910de662db34dc5fcfb57 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 22:13:39 -0400 Subject: [PATCH 051/174] Remove old link-check invocations from circleci config --- .circleci/config.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ed5267d10b..357038c54a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -58,8 +58,6 @@ jobs: - run: yarn lint-css - run: yarn lint-ts - run: yarn format-check - - run: yarn link-check-diff - - run: yarn link-check-exclude test_full: <<: *defaults @@ -69,8 +67,6 @@ jobs: - run: yarn lint-css - run: yarn lint-ts - run: yarn format-check - - run: yarn link-check - - run: yarn link-check-exclude workflows: version: 2 From 45c466ba237aea77158dbbf5152ef7bb28d83f69 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 29 Jul 2020 22:20:49 -0400 Subject: [PATCH 052/174] Remove interpolation workarounds from previous implementation --- scripts/exclude-links.txt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 84681f2b9f..8b2a57d738 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -1,12 +1,9 @@ http://127.0.0.1:10000/devstoreaccount1; http://localhost:8000/ http://millionsongdataset.com/pages/getting-dataset/ -https://$ http://s3-external-1.amazonaws.com/bucket/path https://accounts.google.com/o/oauth2/auth -https://api.cloudflare.com/client/v4/zones/$ https://circleci.com/gh/iterative/dvc.org -https://discuss.$ https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA https://dvc.org/img/.gif https://dvc.org/uploads/images/2020-02-10/image.png @@ -17,8 +14,6 @@ https://example.com/path/to/dir https://example.com/path/to/file https://github.com/example/project.git https://github.com/example/registry -https://github.com/iterative/dvc.org/blob/master/content$ -https://github.com/iterative/dvc/releases/download/$ https://github.com/user/proj https://marketplace.visualstudio.com/items?itemName=stkb.rewrap https://myendpoint.com @@ -30,7 +25,6 @@ https://s3.eu.cloud-object-storage.appdomain.cloud https://sweedom.us10.list-manage.com/subscribe/post?u=a08bf93caae4063c4e6a351f6&id=24c0ecc49a https://www.meetup.com/San-Francisco-Machine-Learning-Meetup/events/264846847/ https://www.reddit.com/r/MachineLearning/comments/bx0apm/d_how_do_you_manage_your_machine_learning/ -https://www.youtube.com/embed/$ http://user@example.com/path http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject From 6a197afe66bebf59ce13cc38c59c7f2836839c51 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 30 Jul 2020 20:11:46 -0400 Subject: [PATCH 053/174] Change action repo --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 3ed41d3bbd..7b6e5a901f 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "rogermparent/dvc-github-actions-link-checker.dist@master" + uses: "iterative/dvc.org-link-check-diff.action@master" with: baseURL: "${{ github.event.deployment.payload.web_url }}" From 36e86db29bdd5e6a77e61c5bbd7437f88f1bdb96 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 01:27:46 -0400 Subject: [PATCH 054/174] Change action repo and use generalized inputs --- .github/workflows/link-check.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 7b6e5a901f..3ccf1764e0 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,9 +13,10 @@ jobs: - name: Run the link checker id: check - uses: "iterative/dvc.org-link-check-diff.action@master" + uses: "iterative/link-check-git-diff.action@master" with: - baseURL: "${{ github.event.deployment.payload.web_url }}" + rootURL: "${{ github.event.deployment.payload.web_url }}" + exclusionsFile: "./scripts/exclude-links.txt" - uses: LouisBrunner/checks-action@v0.1.0 with: From eeeba0c573ccebdb5cf0ce5054aa83c24338eb7e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 02:32:23 -0400 Subject: [PATCH 055/174] Use generalized script and add some quick test data just want to be absolutely sure things work with the action I should make some jest tests or something too, this is a little obnoxious. --- .github/workflows/link-check.yml | 1 + content/blog/2020-07-27-shtab-completion-release.md | 4 ++++ package.json | 5 +++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 3ccf1764e0..41ea33573f 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -17,6 +17,7 @@ jobs: with: rootURL: "${{ github.event.deployment.payload.web_url }}" exclusionsFile: "./scripts/exclude-links.txt" + fileFilter: "content/*" - uses: LouisBrunner/checks-action@v0.1.0 with: diff --git a/content/blog/2020-07-27-shtab-completion-release.md b/content/blog/2020-07-27-shtab-completion-release.md index 8316392a43..365d857b2e 100644 --- a/content/blog/2020-07-27-shtab-completion-release.md +++ b/content/blog/2020-07-27-shtab-completion-release.md @@ -25,6 +25,10 @@ tags: - Completion --- +[Broken](https://notareeeealsite.com) +[404](https://google.com/asdfasdffffsdfasdfasdf) +[Excluded](https://example.com/file.csv) + Command line tools are powerful. Things like [`make`] have manual pages spanning, well, [pages](https://www.gnu.org/software/make/manual/make.html#Options-Summary), diff --git a/package.json b/package.json index a920ddc55e..acb3a5575b 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,8 @@ "format-all": "prettier --write '**/*.{js,jsx,md,tsx,ts,json}'", "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", - "lint-css": "stylelint \"src/**/*.css\"" + "lint-css": "stylelint \"src/**/*.css\"", + "link-check": "LINK_CHECK_EXCLUSIONS_FILE='./scripts/exclude-links.txt' LINK_CHECK_FILE_FILTER='content/*' yarn run link-check-git-diff" }, "repository": { "type": "git", @@ -155,7 +156,7 @@ }, "husky": { "hooks": { - "pre-commit": "yarn format-staged && yarn lint-staged && yarn run link-check-git-diff" + "pre-commit": "yarn format-staged && yarn lint-staged && yarn run link-check" } }, "lint-staged": { From aec7eb2ae8d6ae67acbab5e6b8b5d8ab8331eb8b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 02:35:35 -0400 Subject: [PATCH 056/174] Add new package --- package.json | 1 + yarn.lock | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/package.json b/package.json index acb3a5575b..2bca0f76d1 100644 --- a/package.json +++ b/package.json @@ -53,6 +53,7 @@ "github-markdown-css": "^4.0.0", "iso-url": "^0.4.7", "isomorphic-fetch": "^2.2.1", + "link-check-git-diff": "^0.0.9", "lodash": "^4.17.19", "moment": "^2.25.3", "nanoid": "^3.0.2", diff --git a/yarn.lock b/yarn.lock index e1d1818eb2..3a778444f9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10526,6 +10526,15 @@ lines-and-columns@^1.1.6: resolved "https://registry.yarnpkg.com/lines-and-columns/-/lines-and-columns-1.1.6.tgz#1c00c743b433cd0a4e80758f7b64a57440d9ff00" integrity sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA= +link-check-git-diff@^0.0.9: + version "0.0.9" + resolved "https://registry.yarnpkg.com/link-check-git-diff/-/link-check-git-diff-0.0.9.tgz#760f8aa6189240dd7ebb2cb022f3452c1b0bff66" + integrity sha512-G7/p1uJBJXxxW/6mPWIw9qRvrjpA2jLpDguaYVvtJitGF/u864hGk2oMPeuSPHrxlU/UL7Bb8gHMkMnbIgvbCg== + dependencies: + lodash "^4.17.19" + micromatch "^4.0.2" + node-fetch "^2.6.0" + lint-staged@^10.1.2: version "10.2.6" resolved "https://registry.yarnpkg.com/lint-staged/-/lint-staged-10.2.6.tgz#7d9658bd89dee946a859cbfc6e09566a9fb50b53" From 1ff2493a085dc42172a9f31c397da22006871513 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 02:52:13 -0400 Subject: [PATCH 057/174] Upgrade link checker --- package.json | 4 ++-- yarn.lock | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 2bca0f76d1..934156186a 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "LINK_CHECK_EXCLUSIONS_FILE='./scripts/exclude-links.txt' LINK_CHECK_FILE_FILTER='content/*' yarn run link-check-git-diff" + "link-check": "LINK_CHECK_EXCLUSION_FILE='./scripts/exclude-links.txt' LINK_CHECK_FILE_FILTER='content/*' yarn run link-check-git-diff" }, "repository": { "type": "git", @@ -53,7 +53,7 @@ "github-markdown-css": "^4.0.0", "iso-url": "^0.4.7", "isomorphic-fetch": "^2.2.1", - "link-check-git-diff": "^0.0.9", + "link-check-git-diff": "^0.0.11", "lodash": "^4.17.19", "moment": "^2.25.3", "nanoid": "^3.0.2", diff --git a/yarn.lock b/yarn.lock index 3a778444f9..e259092643 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10526,10 +10526,10 @@ lines-and-columns@^1.1.6: resolved "https://registry.yarnpkg.com/lines-and-columns/-/lines-and-columns-1.1.6.tgz#1c00c743b433cd0a4e80758f7b64a57440d9ff00" integrity sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA= -link-check-git-diff@^0.0.9: - version "0.0.9" - resolved "https://registry.yarnpkg.com/link-check-git-diff/-/link-check-git-diff-0.0.9.tgz#760f8aa6189240dd7ebb2cb022f3452c1b0bff66" - integrity sha512-G7/p1uJBJXxxW/6mPWIw9qRvrjpA2jLpDguaYVvtJitGF/u864hGk2oMPeuSPHrxlU/UL7Bb8gHMkMnbIgvbCg== +link-check-git-diff@^0.0.11: + version "0.0.11" + resolved "https://registry.yarnpkg.com/link-check-git-diff/-/link-check-git-diff-0.0.11.tgz#a2511fe56b7f36a4b2938f96334af0a72ca6673c" + integrity sha512-ItaNB6sEOy73fPs9t35D/JBAuBZvffEY7CcsUQWNWn183CBjRT9bQ3ngpWUPoYYLpiCqX5WWx/w8f8h4EQYeXw== dependencies: lodash "^4.17.19" micromatch "^4.0.2" From 9d5099389e8e6cc873553ed4fa1374d2c7dc5a1d Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 03:02:55 -0400 Subject: [PATCH 058/174] Adjust for input name change in link check package --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 41ea33573f..5452145947 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -16,7 +16,7 @@ jobs: uses: "iterative/link-check-git-diff.action@master" with: rootURL: "${{ github.event.deployment.payload.web_url }}" - exclusionsFile: "./scripts/exclude-links.txt" + exclusionFile: "./scripts/exclude-links.txt" fileFilter: "content/*" - uses: LouisBrunner/checks-action@v0.1.0 From 51e81f8a842fbcc990bde2451fef393c0093b73c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 03:53:17 -0400 Subject: [PATCH 059/174] Add more comprehensive examples --- content/blog/2020-07-27-shtab-completion-release.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/content/blog/2020-07-27-shtab-completion-release.md b/content/blog/2020-07-27-shtab-completion-release.md index 365d857b2e..0a8db0b60b 100644 --- a/content/blog/2020-07-27-shtab-completion-release.md +++ b/content/blog/2020-07-27-shtab-completion-release.md @@ -27,7 +27,8 @@ tags: [Broken](https://notareeeealsite.com) [404](https://google.com/asdfasdffffsdfasdfasdf) -[Excluded](https://example.com/file.csv) +[Excluded](https://example.com/file.csv) [200](https://google.com) +[Local 200](/doc) [Local 404](/thisisjustnotapageman) Command line tools are powerful. Things like [`make`] have manual pages spanning, well, From a90e42b4b8035d8a8498e444000bbcc1e79d7332 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 03:57:17 -0400 Subject: [PATCH 060/174] Upgrade link checker --- package.json | 4 ++-- yarn.lock | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 934156186a..39e5545e2a 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "LINK_CHECK_EXCLUSION_FILE='./scripts/exclude-links.txt' LINK_CHECK_FILE_FILTER='content/*' yarn run link-check-git-diff" + "link-check": "LINK_CHECK_EXCLUSION_FILE='./scripts/exclude-links.txt' LINK_CHECK_FILE_FILTER='content/*' LINK_CHECK_ROOT_URL='https://dvc.org' yarn run link-check-git-diff" }, "repository": { "type": "git", @@ -53,7 +53,7 @@ "github-markdown-css": "^4.0.0", "iso-url": "^0.4.7", "isomorphic-fetch": "^2.2.1", - "link-check-git-diff": "^0.0.11", + "link-check-git-diff": "^0.0.12", "lodash": "^4.17.19", "moment": "^2.25.3", "nanoid": "^3.0.2", diff --git a/yarn.lock b/yarn.lock index e259092643..27147d6a1c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10526,10 +10526,10 @@ lines-and-columns@^1.1.6: resolved "https://registry.yarnpkg.com/lines-and-columns/-/lines-and-columns-1.1.6.tgz#1c00c743b433cd0a4e80758f7b64a57440d9ff00" integrity sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA= -link-check-git-diff@^0.0.11: - version "0.0.11" - resolved "https://registry.yarnpkg.com/link-check-git-diff/-/link-check-git-diff-0.0.11.tgz#a2511fe56b7f36a4b2938f96334af0a72ca6673c" - integrity sha512-ItaNB6sEOy73fPs9t35D/JBAuBZvffEY7CcsUQWNWn183CBjRT9bQ3ngpWUPoYYLpiCqX5WWx/w8f8h4EQYeXw== +link-check-git-diff@^0.0.12: + version "0.0.12" + resolved "https://registry.yarnpkg.com/link-check-git-diff/-/link-check-git-diff-0.0.12.tgz#164b28d184f0e3826e091754833b5a414c581aac" + integrity sha512-BEaEWrqkgQjJYgD/2bim/S2FTazu9rF1sUfv+vaEMtpcrmpg4bxFG8QNnSp3hlMzabmBQ8I6Izusx4cotxS6cw== dependencies: lodash "^4.17.19" micromatch "^4.0.2" From 55a905f87bfea6ba801747fa32bf4c31823df501 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 1 Aug 2020 04:27:28 -0400 Subject: [PATCH 061/174] Actually reset content --- content/blog/2020-07-27-shtab-completion-release.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/content/blog/2020-07-27-shtab-completion-release.md b/content/blog/2020-07-27-shtab-completion-release.md index 0a8db0b60b..8316392a43 100644 --- a/content/blog/2020-07-27-shtab-completion-release.md +++ b/content/blog/2020-07-27-shtab-completion-release.md @@ -25,11 +25,6 @@ tags: - Completion --- -[Broken](https://notareeeealsite.com) -[404](https://google.com/asdfasdffffsdfasdfasdf) -[Excluded](https://example.com/file.csv) [200](https://google.com) -[Local 200](/doc) [Local 404](/thisisjustnotapageman) - Command line tools are powerful. Things like [`make`] have manual pages spanning, well, [pages](https://www.gnu.org/software/make/manual/make.html#Options-Summary), From 4f36b7402a9bfc7582e705e1fcb3bbd51f2bee44 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 14 Aug 2020 17:22:49 -0400 Subject: [PATCH 062/174] Convert repeat exclusions to globs and add linkedin/in Linkedin's /in pages respond with code 999 no matter what while delivering a minimal JS application. It seems this means /in profiles must be excluded, as the routes don't respond like regular pages. --- scripts/exclude-links.txt | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 8b2a57d738..fe1da173e3 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -1,5 +1,5 @@ -http://127.0.0.1:10000/devstoreaccount1; -http://localhost:8000/ +**127.0.0.1** +http://localhost:8000** http://millionsongdataset.com/pages/getting-dataset/ http://s3-external-1.amazonaws.com/bucket/path https://accounts.google.com/o/oauth2/auth @@ -7,13 +7,8 @@ https://circleci.com/gh/iterative/dvc.org https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA https://dvc.org/img/.gif https://dvc.org/uploads/images/2020-02-10/image.png -https://example.com/data.txt -https://example.com/file.csv -https://example.com/path/to/data.csv -https://example.com/path/to/dir -https://example.com/path/to/file -https://github.com/example/project.git -https://github.com/example/registry +https://example.com** +https://github.com/example** https://github.com/user/proj https://marketplace.visualstudio.com/items?itemName=stkb.rewrap https://myendpoint.com @@ -29,4 +24,4 @@ http://user@example.com/path http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 - +**linkedin.com/in/** From 999dc2be7639ecbc83350214172fd4a61fad1fcc Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 16 Aug 2020 23:22:42 -0400 Subject: [PATCH 063/174] Switch to new rewritten link-check --- .github/workflows/link-check.yml | 6 +- .../2020-08-10-august-20-dvc-heartbeat.md | 6 ++ package.json | 4 +- yarn.lock | 80 ++++++++++++++++--- 4 files changed, 82 insertions(+), 14 deletions(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index 5452145947..b0175ad50c 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,11 +13,11 @@ jobs: - name: Run the link checker id: check - uses: "iterative/link-check-git-diff.action@master" + uses: "iterative/link-check.action@master" with: rootURL: "${{ github.event.deployment.payload.web_url }}" - exclusionFile: "./scripts/exclude-links.txt" - fileFilter: "content/*" + linkExcludePatternFiles: "./scripts/exclude-links.txt" + fileIncludePatterns: "**" - uses: LouisBrunner/checks-action@v0.1.0 with: diff --git a/content/blog/2020-08-10-august-20-dvc-heartbeat.md b/content/blog/2020-08-10-august-20-dvc-heartbeat.md index ebe64dffa2..14bcb336cc 100644 --- a/content/blog/2020-08-10-august-20-dvc-heartbeat.md +++ b/content/blog/2020-08-10-august-20-dvc-heartbeat.md @@ -20,6 +20,12 @@ tags: - Meetup --- +[Google](https://www.google.com) + +[Blog](/blog) + +[Fail](/itsabadlink.com) + Welcome to our August roundup of cool news, new releases, and recommended reading in the MLOps world! diff --git a/package.json b/package.json index d1a028294f..9b484200e7 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "LINK_CHECK_EXCLUSION_FILE='./scripts/exclude-links.txt' LINK_CHECK_FILE_FILTER='content/*' LINK_CHECK_ROOT_URL='https://dvc.org' yarn run link-check-git-diff" + "link-check": "repo-link-check --rootURL='https://www.dvc.org' --fileIncludePattern='**' --linkExcludeFile='scripts/exclude-links.txt' --always-exit-zero" }, "repository": { "type": "git", @@ -53,7 +53,6 @@ "github-markdown-css": "^4.0.0", "iso-url": "^0.4.7", "isomorphic-fetch": "^2.2.1", - "link-check-git-diff": "^0.0.12", "lodash": "^4.17.19", "moment": "^2.25.3", "nanoid": "^3.0.2", @@ -74,6 +73,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", + "repo-link-check": "^0.0.4", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index 9a162e5c3b..faf2327941 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2314,6 +2314,17 @@ eslint-scope "^5.0.0" eslint-utils "^2.0.0" +"@typescript-eslint/experimental-utils@3.9.0": + version "3.9.0" + resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-3.9.0.tgz#3171d8ddba0bf02a8c2034188593630914fcf5ee" + integrity sha512-/vSHUDYizSOhrOJdjYxPNGfb4a3ibO8zd4nUKo/QBFOmxosT3cVUV7KIg8Dwi6TXlr667G7YPqFK9+VSZOorNA== + dependencies: + "@types/json-schema" "^7.0.3" + "@typescript-eslint/types" "3.9.0" + "@typescript-eslint/typescript-estree" "3.9.0" + eslint-scope "^5.0.0" + eslint-utils "^2.0.0" + "@typescript-eslint/parser@^2.24.0", "@typescript-eslint/parser@^2.27.0": version "2.34.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-2.34.0.tgz#50252630ca319685420e9a39ca05fe185a256bc8" @@ -2324,6 +2335,22 @@ "@typescript-eslint/typescript-estree" "2.34.0" eslint-visitor-keys "^1.1.0" +"@typescript-eslint/parser@^3.9.0": + version "3.9.0" + resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-3.9.0.tgz#344978a265d9a5c7c8f13e62c78172a4374dabea" + integrity sha512-rDHOKb6uW2jZkHQniUQVZkixQrfsZGUCNWWbKWep4A5hGhN5dLHMUCNAWnC4tXRlHedXkTDptIpxs6e4Pz8UfA== + dependencies: + "@types/eslint-visitor-keys" "^1.0.0" + "@typescript-eslint/experimental-utils" "3.9.0" + "@typescript-eslint/types" "3.9.0" + "@typescript-eslint/typescript-estree" "3.9.0" + eslint-visitor-keys "^1.1.0" + +"@typescript-eslint/types@3.9.0": + version "3.9.0" + resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-3.9.0.tgz#be9d0aa451e1bf3ce99f2e6920659e5b2e6bfe18" + integrity sha512-rb6LDr+dk9RVVXO/NJE8dT1pGlso3voNdEIN8ugm4CWM5w5GimbThCMiMl4da1t5u3YwPWEwOnKAULCZgBtBHg== + "@typescript-eslint/typescript-estree@2.34.0": version "2.34.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-2.34.0.tgz#14aeb6353b39ef0732cc7f1b8285294937cf37d5" @@ -2337,6 +2364,27 @@ semver "^7.3.2" tsutils "^3.17.1" +"@typescript-eslint/typescript-estree@3.9.0": + version "3.9.0" + resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-3.9.0.tgz#c6abbb50fa0d715cab46fef67ca6378bf2eaca13" + integrity sha512-N+158NKgN4rOmWVfvKOMoMFV5n8XxAliaKkArm/sOypzQ0bUL8MSnOEBW3VFIeffb/K5ce/cAV0yYhR7U4ALAA== + dependencies: + "@typescript-eslint/types" "3.9.0" + "@typescript-eslint/visitor-keys" "3.9.0" + debug "^4.1.1" + glob "^7.1.6" + is-glob "^4.0.1" + lodash "^4.17.15" + semver "^7.3.2" + tsutils "^3.17.1" + +"@typescript-eslint/visitor-keys@3.9.0": + version "3.9.0" + resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-3.9.0.tgz#44de8e1b1df67adaf3b94d6b60b80f8faebc8dd3" + integrity sha512-O1qeoGqDbu0EZUC/MZ6F1WHTIzcBVhGqDj3LhTnj65WUA548RXVxUHbYhAW9bZWfb2rnX9QsbbP5nmeJ5Z4+ng== + dependencies: + eslint-visitor-keys "^1.1.0" + "@urql/core@^1.11.0": version "1.11.8" resolved "https://registry.yarnpkg.com/@urql/core/-/core-1.11.8.tgz#6a3186ac84d6b08752585f42e8ec81539338d7a9" @@ -6540,6 +6588,18 @@ fast-glob@^3.0.3, fast-glob@^3.1.1: micromatch "^4.0.2" picomatch "^2.2.1" +fast-glob@^3.2.4: + version "3.2.4" + resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.4.tgz#d20aefbf99579383e7f3cc66529158c9b98554d3" + integrity sha512-kr/Oo6PX51265qeuCYsyGypiO5uJFgBS0jksyG7FUeCyQzNwYnzrNIMR1NXfkZXsMYXYLRAHgISHBz8gQcxKHQ== + dependencies: + "@nodelib/fs.stat" "^2.0.2" + "@nodelib/fs.walk" "^1.2.3" + glob-parent "^5.1.0" + merge2 "^1.3.0" + micromatch "^4.0.2" + picomatch "^2.2.1" + fast-json-stable-stringify@^2.0.0: version "2.1.0" resolved "https://registry.yarnpkg.com/fast-json-stable-stringify/-/fast-json-stable-stringify-2.1.0.tgz#874bf69c6f404c2b5d99c481341399fd55892633" @@ -10526,15 +10586,6 @@ lines-and-columns@^1.1.6: resolved "https://registry.yarnpkg.com/lines-and-columns/-/lines-and-columns-1.1.6.tgz#1c00c743b433cd0a4e80758f7b64a57440d9ff00" integrity sha1-HADHQ7QzzQpOgHWPe2SldEDZ/wA= -link-check-git-diff@^0.0.12: - version "0.0.12" - resolved "https://registry.yarnpkg.com/link-check-git-diff/-/link-check-git-diff-0.0.12.tgz#164b28d184f0e3826e091754833b5a414c581aac" - integrity sha512-BEaEWrqkgQjJYgD/2bim/S2FTazu9rF1sUfv+vaEMtpcrmpg4bxFG8QNnSp3hlMzabmBQ8I6Izusx4cotxS6cw== - dependencies: - lodash "^4.17.19" - micromatch "^4.0.2" - node-fetch "^2.6.0" - lint-staged@^10.1.2: version "10.2.6" resolved "https://registry.yarnpkg.com/lint-staged/-/lint-staged-10.2.6.tgz#7d9658bd89dee946a859cbfc6e09566a9fb50b53" @@ -14394,6 +14445,17 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== +repo-link-check@^0.0.4: + version "0.0.4" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.4.tgz#8f8705b9fc21ee5fe2a701a091f76976860a9f8c" + integrity sha512-afAMUxfkoOCBpQJQ7qiL8tGIR/psip3U1PQF1l4OjrjNJD6JO+IlwvG9mhtuocIaHfuCQD+x1zcuAl8JWr2kUg== + dependencies: + "@typescript-eslint/parser" "^3.9.0" + fast-glob "^3.2.4" + micromatch "^4.0.2" + minimist "^1.2.5" + node-fetch "^2.6.0" + request-promise-core@1.1.3: version "1.1.3" resolved "https://registry.yarnpkg.com/request-promise-core/-/request-promise-core-1.1.3.tgz#e9a3c081b51380dfea677336061fea879a829ee9" From 7f66b976e8c81adbf8b4c8e1e223ebe0c4055edf Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 17 Aug 2020 00:36:40 -0400 Subject: [PATCH 064/174] Upgrade repo-link-check --- package.json | 2 +- yarn.lock | 57 ++++------------------------------------------------ 2 files changed, 5 insertions(+), 54 deletions(-) diff --git a/package.json b/package.json index 9b484200e7..6037baa582 100644 --- a/package.json +++ b/package.json @@ -73,7 +73,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.4", + "repo-link-check": "^0.0.5", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index faf2327941..a7e94c7b63 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2314,17 +2314,6 @@ eslint-scope "^5.0.0" eslint-utils "^2.0.0" -"@typescript-eslint/experimental-utils@3.9.0": - version "3.9.0" - resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-3.9.0.tgz#3171d8ddba0bf02a8c2034188593630914fcf5ee" - integrity sha512-/vSHUDYizSOhrOJdjYxPNGfb4a3ibO8zd4nUKo/QBFOmxosT3cVUV7KIg8Dwi6TXlr667G7YPqFK9+VSZOorNA== - dependencies: - "@types/json-schema" "^7.0.3" - "@typescript-eslint/types" "3.9.0" - "@typescript-eslint/typescript-estree" "3.9.0" - eslint-scope "^5.0.0" - eslint-utils "^2.0.0" - "@typescript-eslint/parser@^2.24.0", "@typescript-eslint/parser@^2.27.0": version "2.34.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-2.34.0.tgz#50252630ca319685420e9a39ca05fe185a256bc8" @@ -2335,22 +2324,6 @@ "@typescript-eslint/typescript-estree" "2.34.0" eslint-visitor-keys "^1.1.0" -"@typescript-eslint/parser@^3.9.0": - version "3.9.0" - resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-3.9.0.tgz#344978a265d9a5c7c8f13e62c78172a4374dabea" - integrity sha512-rDHOKb6uW2jZkHQniUQVZkixQrfsZGUCNWWbKWep4A5hGhN5dLHMUCNAWnC4tXRlHedXkTDptIpxs6e4Pz8UfA== - dependencies: - "@types/eslint-visitor-keys" "^1.0.0" - "@typescript-eslint/experimental-utils" "3.9.0" - "@typescript-eslint/types" "3.9.0" - "@typescript-eslint/typescript-estree" "3.9.0" - eslint-visitor-keys "^1.1.0" - -"@typescript-eslint/types@3.9.0": - version "3.9.0" - resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-3.9.0.tgz#be9d0aa451e1bf3ce99f2e6920659e5b2e6bfe18" - integrity sha512-rb6LDr+dk9RVVXO/NJE8dT1pGlso3voNdEIN8ugm4CWM5w5GimbThCMiMl4da1t5u3YwPWEwOnKAULCZgBtBHg== - "@typescript-eslint/typescript-estree@2.34.0": version "2.34.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-2.34.0.tgz#14aeb6353b39ef0732cc7f1b8285294937cf37d5" @@ -2364,27 +2337,6 @@ semver "^7.3.2" tsutils "^3.17.1" -"@typescript-eslint/typescript-estree@3.9.0": - version "3.9.0" - resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-3.9.0.tgz#c6abbb50fa0d715cab46fef67ca6378bf2eaca13" - integrity sha512-N+158NKgN4rOmWVfvKOMoMFV5n8XxAliaKkArm/sOypzQ0bUL8MSnOEBW3VFIeffb/K5ce/cAV0yYhR7U4ALAA== - dependencies: - "@typescript-eslint/types" "3.9.0" - "@typescript-eslint/visitor-keys" "3.9.0" - debug "^4.1.1" - glob "^7.1.6" - is-glob "^4.0.1" - lodash "^4.17.15" - semver "^7.3.2" - tsutils "^3.17.1" - -"@typescript-eslint/visitor-keys@3.9.0": - version "3.9.0" - resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-3.9.0.tgz#44de8e1b1df67adaf3b94d6b60b80f8faebc8dd3" - integrity sha512-O1qeoGqDbu0EZUC/MZ6F1WHTIzcBVhGqDj3LhTnj65WUA548RXVxUHbYhAW9bZWfb2rnX9QsbbP5nmeJ5Z4+ng== - dependencies: - eslint-visitor-keys "^1.1.0" - "@urql/core@^1.11.0": version "1.11.8" resolved "https://registry.yarnpkg.com/@urql/core/-/core-1.11.8.tgz#6a3186ac84d6b08752585f42e8ec81539338d7a9" @@ -14445,12 +14397,11 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.4: - version "0.0.4" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.4.tgz#8f8705b9fc21ee5fe2a701a091f76976860a9f8c" - integrity sha512-afAMUxfkoOCBpQJQ7qiL8tGIR/psip3U1PQF1l4OjrjNJD6JO+IlwvG9mhtuocIaHfuCQD+x1zcuAl8JWr2kUg== +repo-link-check@^0.0.5: + version "0.0.5" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.5.tgz#a5bd47157c358b67b2c8393d79f14a56ca9b001f" + integrity sha512-raAF7/79BdnjMvM1Zj5U8i1tY/1iRHF08368sF78ITvBHYQUH0XZvBZWPOM+JnERtHVSmSZN03+h9bY7nuRSIQ== dependencies: - "@typescript-eslint/parser" "^3.9.0" fast-glob "^3.2.4" micromatch "^4.0.2" minimist "^1.2.5" From 50c088644e37bffd815da4e4745df3a17a09b6fc Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 17 Aug 2020 14:28:36 -0400 Subject: [PATCH 065/174] Use updated/fixed link checker and add specific files to invocation --- content/blog/2020-08-10-august-20-dvc-heartbeat.md | 3 +++ package.json | 4 ++-- yarn.lock | 8 ++++---- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/content/blog/2020-08-10-august-20-dvc-heartbeat.md b/content/blog/2020-08-10-august-20-dvc-heartbeat.md index 14bcb336cc..0c71205d96 100644 --- a/content/blog/2020-08-10-august-20-dvc-heartbeat.md +++ b/content/blog/2020-08-10-august-20-dvc-heartbeat.md @@ -26,6 +26,9 @@ tags: [Fail](/itsabadlink.com) +[linkedin in page that always gives 999](https://www.linkedin.com/in/shouldbefiltered) +[linkedin home which is fine and not selected by the glob](https://www.linkedin.com) + Welcome to our August roundup of cool news, new releases, and recommended reading in the MLOps world! diff --git a/package.json b/package.json index 6037baa582..0a413f329a 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check --rootURL='https://www.dvc.org' --fileIncludePattern='**' --linkExcludeFile='scripts/exclude-links.txt' --always-exit-zero" + "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero" }, "repository": { "type": "git", @@ -73,7 +73,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.5", + "repo-link-check": "^0.0.6", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index a7e94c7b63..98551b4fa4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14397,10 +14397,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.5: - version "0.0.5" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.5.tgz#a5bd47157c358b67b2c8393d79f14a56ca9b001f" - integrity sha512-raAF7/79BdnjMvM1Zj5U8i1tY/1iRHF08368sF78ITvBHYQUH0XZvBZWPOM+JnERtHVSmSZN03+h9bY7nuRSIQ== +repo-link-check@^0.0.6: + version "0.0.6" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.6.tgz#39cf9270def4a096352502b2c8315603e43e4023" + integrity sha512-+MlbKc57BmzeN0hoy2VGWmfYe11IWp6oK4rEPfS1nZ4fzq9mDA2gJXyRkVM9OzWWt1gX+TaXOMrOHMaS+FGW0Q== dependencies: fast-glob "^3.2.4" micromatch "^4.0.2" From a1159a254a2f2af7f5f0c06b7377492850a83b0b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 17 Aug 2020 19:44:35 -0400 Subject: [PATCH 066/174] Update CLI package and add link-check-all script --- package.json | 5 +++-- scripts/exclude-links.txt | 2 ++ yarn.lock | 14 ++++++++++---- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 0a413f329a..56f4150a17 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,8 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero" + "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero", + "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero --source=filesystem" }, "repository": { "type": "git", @@ -73,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.6", + "repo-link-check": "^0.0.9", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index fe1da173e3..7ea24f0bd5 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -25,3 +25,5 @@ http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 **linkedin.com/in/** +link +/img/.gif diff --git a/yarn.lock b/yarn.lock index 98551b4fa4..fa21cfe7eb 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3480,6 +3480,11 @@ boolbase@^1.0.0, boolbase@~1.0.0: resolved "https://registry.yarnpkg.com/boolbase/-/boolbase-1.0.0.tgz#68dff5fbe60c51eb37725ea9e3ed310dcc1e776e" integrity sha1-aN/1++YMUes3cl6p4+0xDcwed24= +bottleneck@^2.19.5: + version "2.19.5" + resolved "https://registry.yarnpkg.com/bottleneck/-/bottleneck-2.19.5.tgz#5df0b90f59fd47656ebe63c78a98419205cadd91" + integrity sha512-VHiNCbI1lKdl44tGrhNfU3lup0Tj/ZBMJB5/2ZbNXRCPuRCO7ed2mgcK4r17y+KB2EfuYuRaVlwNbAeaWGSpbw== + bowser@^1.7.3: version "1.9.4" resolved "https://registry.yarnpkg.com/bowser/-/bowser-1.9.4.tgz#890c58a2813a9d3243704334fa81b96a5c150c9a" @@ -14397,11 +14402,12 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.6: - version "0.0.6" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.6.tgz#39cf9270def4a096352502b2c8315603e43e4023" - integrity sha512-+MlbKc57BmzeN0hoy2VGWmfYe11IWp6oK4rEPfS1nZ4fzq9mDA2gJXyRkVM9OzWWt1gX+TaXOMrOHMaS+FGW0Q== +repo-link-check@^0.0.9: + version "0.0.9" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.9.tgz#5f9b9204b077ffd6e34b61917b085701e762ff2d" + integrity sha512-cz5zKihgktmooOL4TO2L4CiRVkFW4lQlyTsIe58o7huQ8JwMj1yCXw6gdxqW/EC/aoR1at/QK6Qw/wQ46KbEcg== dependencies: + bottleneck "^2.19.5" fast-glob "^3.2.4" micromatch "^4.0.2" minimist "^1.2.5" From f8e81b79d7400a8d8ad4d4e823d91830d7f1e342 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 14:16:27 -0400 Subject: [PATCH 067/174] Change millionsongdataset exclusion to match existing link --- scripts/exclude-links.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 7ea24f0bd5..28a137467a 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -1,6 +1,6 @@ **127.0.0.1** http://localhost:8000** -http://millionsongdataset.com/pages/getting-dataset/ +http://millionsongdataset.com/pages/getting-dataset/#subset http://s3-external-1.amazonaws.com/bucket/path https://accounts.google.com/o/oauth2/auth https://circleci.com/gh/iterative/dvc.org From 28d95c18a312ab6442c83a902de2bbc270d849f6 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 14:34:25 -0400 Subject: [PATCH 068/174] Update link checker and report unused patterns on link-check-all --- package.json | 4 ++-- yarn.lock | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 56f4150a17..11102ccd04 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero", - "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero --source=filesystem" + "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero --source=filesystem --report-unused-patterns" }, "repository": { "type": "git", @@ -74,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.9", + "repo-link-check": "^0.0.10", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index fa21cfe7eb..5cd17907fb 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.9: - version "0.0.9" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.9.tgz#5f9b9204b077ffd6e34b61917b085701e762ff2d" - integrity sha512-cz5zKihgktmooOL4TO2L4CiRVkFW4lQlyTsIe58o7huQ8JwMj1yCXw6gdxqW/EC/aoR1at/QK6Qw/wQ46KbEcg== +repo-link-check@^0.0.10: + version "0.0.10" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.10.tgz#51d1fc4c02c3559427e6f376a0b9f150546f7641" + integrity sha512-72TfnBNkccy5HvzHZzxZ7pTfUsKN2qzVfeRoticxqSSlHZPb4GcbKpUW+xE51gBGIsNSCtKSnFNvEcNG4BeVvQ== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From a4eef6cae121d3f13abe316033d7cf8e9fc4a362 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 14:34:58 -0400 Subject: [PATCH 069/174] Remove test links --- content/blog/2020-08-10-august-20-dvc-heartbeat.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/content/blog/2020-08-10-august-20-dvc-heartbeat.md b/content/blog/2020-08-10-august-20-dvc-heartbeat.md index 0c71205d96..ebe64dffa2 100644 --- a/content/blog/2020-08-10-august-20-dvc-heartbeat.md +++ b/content/blog/2020-08-10-august-20-dvc-heartbeat.md @@ -20,15 +20,6 @@ tags: - Meetup --- -[Google](https://www.google.com) - -[Blog](/blog) - -[Fail](/itsabadlink.com) - -[linkedin in page that always gives 999](https://www.linkedin.com/in/shouldbefiltered) -[linkedin home which is fine and not selected by the glob](https://www.linkedin.com) - Welcome to our August roundup of cool news, new releases, and recommended reading in the MLOps world! From 955670093da1f0513df3f96997002cc37fe725a7 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 17:16:23 -0400 Subject: [PATCH 070/174] Filter out malformed URLs and tweak regex to only hit http/s --- package.json | 6 +++--- yarn.lock | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 11102ccd04..de44caa049 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,8 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero", - "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --file-exclude-pattern='content/docs/user-guide/contributing/blog.md' --always-exit-zero --source=filesystem --report-unused-patterns" + "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-pattern='**/*.test.js' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero", + "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-pattern='**/*.test.js' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero --source=filesystem --report-unused-patterns" }, "repository": { "type": "git", @@ -74,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.10", + "repo-link-check": "^0.0.13", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index 5cd17907fb..b264fe7b0e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.10: - version "0.0.10" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.10.tgz#51d1fc4c02c3559427e6f376a0b9f150546f7641" - integrity sha512-72TfnBNkccy5HvzHZzxZ7pTfUsKN2qzVfeRoticxqSSlHZPb4GcbKpUW+xE51gBGIsNSCtKSnFNvEcNG4BeVvQ== +repo-link-check@^0.0.13: + version "0.0.13" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.13.tgz#3d24bf603bbb20eb0f8c57b0ff71b403b35cdf7c" + integrity sha512-eyLBmwMaFViDxb8mRX7mb0kAHZiUNpAMrNTTMt+Kdm7u7ixOdN4UjXBdmz+p2pjGsF+rRx/FKaZ28m6gFt8ujw== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From a6c70ab6ea86af89b49719a3bcfb2d6261779549 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 19:01:57 -0400 Subject: [PATCH 071/174] Add a file exclusion file to link check --- package.json | 4 ++-- scripts/exclude-files.txt | 3 +++ scripts/exclude-links.txt | 2 ++ 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 scripts/exclude-files.txt diff --git a/package.json b/package.json index de44caa049..8e3c090105 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,8 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-pattern='**/*.test.js' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero", - "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-pattern='**/*.test.js' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero --source=filesystem --report-unused-patterns" + "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-file='./scripts/exclude-files.txt' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero", + "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-file='./scripts/exclude-files.txt' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero --source=filesystem --report-unused-patterns" }, "repository": { "type": "git", diff --git a/scripts/exclude-files.txt b/scripts/exclude-files.txt new file mode 100644 index 0000000000..f34ee929db --- /dev/null +++ b/scripts/exclude-files.txt @@ -0,0 +1,3 @@ +src/consts.js +**/*.test.js +src/server/**/* diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 28a137467a..033daac62f 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -27,3 +27,5 @@ https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebo **linkedin.com/in/** link /img/.gif +/uploads/images/2020-02-10/image.png +https://portal.aws.amazon.com/gp/aws/developer/registration/index.html From 12335a4b3b4cb90e901e57de8e3a1501576dea2b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 21:57:28 -0400 Subject: [PATCH 072/174] Add patterns to action workflow --- .github/workflows/link-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index b0175ad50c..e55e91fa61 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -17,7 +17,8 @@ jobs: with: rootURL: "${{ github.event.deployment.payload.web_url }}" linkExcludePatternFiles: "./scripts/exclude-links.txt" - fileIncludePatterns: "**" + fileExcludePatternFiles: "./scripts/exclude-files.txt" + fileIncludePatterns: "{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}" - uses: LouisBrunner/checks-action@v0.1.0 with: From ba0d675d0c61729a479c204bacd07fc41c7fc6bd Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 21:58:01 -0400 Subject: [PATCH 073/174] Update link check --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 8e3c090105..f4c1bda297 100644 --- a/package.json +++ b/package.json @@ -74,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.13", + "repo-link-check": "^0.0.14", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index b264fe7b0e..b8a81a205f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.13: - version "0.0.13" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.13.tgz#3d24bf603bbb20eb0f8c57b0ff71b403b35cdf7c" - integrity sha512-eyLBmwMaFViDxb8mRX7mb0kAHZiUNpAMrNTTMt+Kdm7u7ixOdN4UjXBdmz+p2pjGsF+rRx/FKaZ28m6gFt8ujw== +repo-link-check@^0.0.14: + version "0.0.14" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.14.tgz#ac4e1355af1b9aae3ca39701242f7a0884cc512f" + integrity sha512-Lzb79wu2lvfIDQoorkR6n9eHcIgc3lfXR0GsTfEhj4A4pSc5cNKoWtVmFBtnzmabEJYTJuLPyfhMZUxH0gg9lw== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From a8594297f4039c18c31b2bdc5c6d08cabc5a3ea3 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 21:58:29 -0400 Subject: [PATCH 074/174] Add GH workflows and component partial to exceptions --- scripts/exclude-files.txt | 1 + scripts/exclude-links.txt | 1 + 2 files changed, 2 insertions(+) diff --git a/scripts/exclude-files.txt b/scripts/exclude-files.txt index f34ee929db..e4161f4314 100644 --- a/scripts/exclude-files.txt +++ b/scripts/exclude-files.txt @@ -1,3 +1,4 @@ src/consts.js **/*.test.js src/server/**/* +.github/workflows/**/* diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 033daac62f..ccfe27bfb4 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -29,3 +29,4 @@ link /img/.gif /uploads/images/2020-02-10/image.png https://portal.aws.amazon.com/gp/aws/developer/registration/index.html +https://github.com/iterative/dvc/releases/download/ From ec12e40f00973f1857fa74158216e515c100cd9a Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 18 Aug 2020 21:59:19 -0400 Subject: [PATCH 075/174] Clean up broken links in content The images in devops for data scientists are odd- they work on the site, but don't actually point to real file path and break the link checker. I felt changing them to a real path like other posts would be a better solution than relying on an inconsistent usage of magic paths. The GitHub link 404'ed because the paths were capitalized at "GitHub", while the real path was a case sensitive "github". Also a link to CML had a semicolon instead of a colon. --- .../blog/2020-07-16-devops-for-data-scientists.md | 12 ++++++------ content/blog/2020-07-24-first-mlops-tutorial.md | 2 +- ...07-cml-self-hosted-runners-on-demand-with-gpus.md | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/content/blog/2020-07-16-devops-for-data-scientists.md b/content/blog/2020-07-16-devops-for-data-scientists.md index 078bf8be92..3dfe74c1db 100644 --- a/content/blog/2020-07-16-devops-for-data-scientists.md +++ b/content/blog/2020-07-16-devops-for-data-scientists.md @@ -127,7 +127,7 @@ Git refresher? When a feature branch passes the automated tests, it becomes a candidate to be merged into the master branch. -![](/static/uploads/2020-07-16/basic_ci_system.png) _Here's what continuous +![](/uploads/images/2020-07-16/basic_ci_system.png) _Here's what continuous integration looks like in software development._ With this setup, we have automation — code changes trigger an automatic build @@ -145,7 +145,7 @@ matrix or loss plot. So pass/fail tests won’t cut it for feedback. Understandi if a model is improved requires some domain knowledge about the problem at hand, so test results need to be reported in an efficient and human-interpretable way. -![](/static/uploads/2020-07-16/ci_for_data_system.png) _Here's what continuous +![](/uploads/images/2020-07-16/ci_for_data_system.png) _Here's what continuous integration might look like in a machine learning project. Inspected by Data Science Doggy._ @@ -183,7 +183,7 @@ $ git push origin experiment 4. GitHub returns a notification if the functions ran successfully or not. -![](/static/uploads/2020-07-16/run_notification.png) _Find this in the Actions +![](/uploads/images/2020-07-16/run_notification.png) _Find this in the Actions tab of your GitHub repository._ That’s it! What’s really neat here is that you’re using GitHub’s computers to @@ -225,7 +225,7 @@ As we alluded to earlier, automatic training is pretty cool and all, but it’s important to have the results in a format that’s easy to understand. Currently, GitHub Actions gives you access to the runner’s logs, which are plain text. -![](/static/uploads/2020-07-16/github_actions_log.png) _An example printout from +![](/uploads/images/2020-07-16/github_actions_log.png) _An example printout from a GitHub Actions log._ But understanding your model’s performance is tricky. Models and data are high @@ -243,7 +243,7 @@ we’ve built some functions to give more detailed reports than a pass/fail notification. CML helps you put images and tables in the reports, like this confusion matrix generated by SciKit-learn: -![](/static/uploads/2020-07-16/cml_basic_report.png) _This report appears when +![](/uploads/images/2020-07-16/cml_basic_report.png) _This report appears when you make a Pull Request in GitHub!_ To make this report, our GitHub Action executed a Python model training script, @@ -315,7 +315,7 @@ For example, I made a project using GitHub Actions to deploy an [EC2 GPU and then train a neural style transfer model](https://github.com/iterative/cml_cloud_case). Here’s my CML report: -![](/static/uploads/2020-07-16/cloud_report.png) _Training in the cloud! +![](/uploads/images/2020-07-16/cloud_report.png) _Training in the cloud! Weeeeeee!_ You can also use your own Docker containers, so you can closely emulate the diff --git a/content/blog/2020-07-24-first-mlops-tutorial.md b/content/blog/2020-07-24-first-mlops-tutorial.md index 11c1f8bd00..2555e717c3 100644 --- a/content/blog/2020-07-24-first-mlops-tutorial.md +++ b/content/blog/2020-07-24-first-mlops-tutorial.md @@ -19,7 +19,7 @@ tags: - CML --- -Earlier this month, we launched [CML](https;//cml.dev), our latest open-source +Earlier this month, we launched [CML](https://cml.dev), our latest open-source project in the MLOps space. We think it's a step towards establishing powerful DevOps practices (like continuous integration) as a regular fixture of machine learning and data science projects. But there are plenty of challenges ahead, diff --git a/content/blog/2020-08-07-cml-self-hosted-runners-on-demand-with-gpus.md b/content/blog/2020-08-07-cml-self-hosted-runners-on-demand-with-gpus.md index c00adb406d..3b15a31ae9 100644 --- a/content/blog/2020-08-07-cml-self-hosted-runners-on-demand-with-gpus.md +++ b/content/blog/2020-08-07-cml-self-hosted-runners-on-demand-with-gpus.md @@ -45,7 +45,7 @@ Here are some benefits of using CML with a self-hosted runner: 3. **Security.** If your repo is public your runners could be accesed by anyone that could add - [scripts that exploits your machine](https://docs.GitHub.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security-with-public-repositories). + [scripts that exploits your machine](https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security-with-public-repositories). With the containerised runner you are restricting the access to your real machine. @@ -163,7 +163,7 @@ running with CML. There are still some limitations to be solved at this stage: - GitHub Actions - [can’t run a workflow longer than 72 hours](https://docs.GitHub.com/en/actions/getting-started-with-GitHub-actions/about-GitHub-actions#usage-limits). + [can’t run a workflow longer than 72 hours](https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits). - Self-hosted runners [don’t behave well when they disconnect from the repo](https://GitLab.com/GitLab-org/GitLab/-/issues/229851#note_390371734), From f3265e952f72b34a773b63dc5650270bb728cd92 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 00:26:53 -0400 Subject: [PATCH 076/174] Upgrade link checker --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index f4c1bda297..79b05e4744 100644 --- a/package.json +++ b/package.json @@ -74,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.14", + "repo-link-check": "^0.0.15", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index b8a81a205f..ddab92bd02 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.14: - version "0.0.14" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.14.tgz#ac4e1355af1b9aae3ca39701242f7a0884cc512f" - integrity sha512-Lzb79wu2lvfIDQoorkR6n9eHcIgc3lfXR0GsTfEhj4A4pSc5cNKoWtVmFBtnzmabEJYTJuLPyfhMZUxH0gg9lw== +repo-link-check@^0.0.15: + version "0.0.15" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.15.tgz#9ab075cd8260d9941c693e75351f145313d88ab5" + integrity sha512-1bpeHS0/RhDhhvfgWieogWJBVspj1PoU4jaHX2zihep6HyLctXMJd3G4xt1SS5BiqbxEjVIGeOSHw5ixkypkJw== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From c1d2ad335da0d8fde6a0c5e02018707d4d502fc7 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 13:39:55 -0400 Subject: [PATCH 077/174] Upgrade link-check and use new shorthand CLI flags in scripts --- package.json | 6 +++--- yarn.lock | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 79b05e4744..b80f16cae6 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,8 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-file='./scripts/exclude-files.txt' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero", - "link-check-all": "repo-link-check --rootURL='https://www.dvc.org' --file-exclude-file='./scripts/exclude-files.txt' --file-include-pattern='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --link-exclude-file='./scripts/exclude-links.txt' --always-exit-zero --source=filesystem --report-unused-patterns" + "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -z", + "link-check-all": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -z -s=filesystem -u" }, "repository": { "type": "git", @@ -74,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.15", + "repo-link-check": "^0.0.16", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index ddab92bd02..8cc9835aae 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.15: - version "0.0.15" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.15.tgz#9ab075cd8260d9941c693e75351f145313d88ab5" - integrity sha512-1bpeHS0/RhDhhvfgWieogWJBVspj1PoU4jaHX2zihep6HyLctXMJd3G4xt1SS5BiqbxEjVIGeOSHw5ixkypkJw== +repo-link-check@^0.0.16: + version "0.0.16" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.16.tgz#aacb21449f0947d4cfa55c8bd738f0fe65e384db" + integrity sha512-HWJF5oeMM9GAS/wtQbm5oaZH3Q5xwrnHOE21d2uA4sc3qqdB3WWM0tYGgZ1O4t/QZO5c02x9uyC62QNXgS+itA== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From cd3185019f27a7dd8b298c88122f3fac9d839805 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 18:46:50 -0400 Subject: [PATCH 078/174] Move to static version of link check action --- .github/workflows/link-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check.yml index e55e91fa61..69d01dae13 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link checker id: check - uses: "iterative/link-check.action@master" + uses: "iterative/link-check.action@v0.1.3" with: rootURL: "${{ github.event.deployment.payload.web_url }}" linkExcludePatternFiles: "./scripts/exclude-links.txt" From d380035e30a3c1bbadb4f4205a0e687e336b209c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 18:47:47 -0400 Subject: [PATCH 079/174] Upgrade link checker CLI --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index b80f16cae6..95de6a57c7 100644 --- a/package.json +++ b/package.json @@ -74,7 +74,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.0.16", + "repo-link-check": "^0.1.3", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index 8cc9835aae..860fdd0673 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.0.16: - version "0.0.16" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.0.16.tgz#aacb21449f0947d4cfa55c8bd738f0fe65e384db" - integrity sha512-HWJF5oeMM9GAS/wtQbm5oaZH3Q5xwrnHOE21d2uA4sc3qqdB3WWM0tYGgZ1O4t/QZO5c02x9uyC62QNXgS+itA== +repo-link-check@^0.1.3: + version "0.1.3" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.1.3.tgz#cbbff932aeac42cc31f68897f487ed373b74a9a8" + integrity sha512-+H5TEEjeXSlVvQVEoRx81dJW51YyGnMeAvwec31lnMVmUBO6QSZjDjR1dBy1FX7zohdNdOlzpMP7LP7V4A69Gg== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From 628ec1f8e0d882938080971f3000e287987d2d62 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 22:49:21 -0400 Subject: [PATCH 080/174] Emulate the previous package.json scripts and re-add them to circleCI --- .circleci/config.yml | 3 +++ package.json | 9 +++++---- yarn.lock | 8 ++++---- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 357038c54a..dc1656bc7f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -58,6 +58,7 @@ jobs: - run: yarn lint-css - run: yarn lint-ts - run: yarn format-check + - run: yarn link-check-exclude test_full: <<: *defaults @@ -67,6 +68,8 @@ jobs: - run: yarn lint-css - run: yarn lint-ts - run: yarn format-check + - run: yarn link-check + - run: yarn link-check-exclude workflows: version: 2 diff --git a/package.json b/package.json index 95de6a57c7..087e7adfc3 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,9 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -z", - "link-check-all": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -z -s=filesystem -u" + "link-check-diff": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", + "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", + "link-check-exclude": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" }, "repository": { "type": "git", @@ -74,7 +75,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.1.3", + "repo-link-check": "^0.1.4", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", @@ -158,7 +159,7 @@ }, "husky": { "hooks": { - "pre-commit": "yarn format-staged && yarn lint-staged && yarn run link-check" + "pre-commit": "yarn format-staged && yarn lint-staged && yarn link-check-diff -z" } }, "lint-staged": { diff --git a/yarn.lock b/yarn.lock index 860fdd0673..d0d4c99246 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14402,10 +14402,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.1.3: - version "0.1.3" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.1.3.tgz#cbbff932aeac42cc31f68897f487ed373b74a9a8" - integrity sha512-+H5TEEjeXSlVvQVEoRx81dJW51YyGnMeAvwec31lnMVmUBO6QSZjDjR1dBy1FX7zohdNdOlzpMP7LP7V4A69Gg== +repo-link-check@^0.1.4: + version "0.1.4" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.1.4.tgz#fd34cf3c695a48c9527ffa87fbd11d01c2f63c5f" + integrity sha512-hezH75OOz/kdlLb0AqASFx+rM8cVv+Mc+9Xwx6eifzCZfkxfmfkYYpLfAdlwNrrImsw+/x1qUqp3h1W+g5mFUg== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From 7926b688b2f732dee061c9ffff3498c112a9f3c7 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 23:20:06 -0400 Subject: [PATCH 081/174] Add script for link checking the local dev server --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 087e7adfc3..86388c71b8 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,9 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check-diff": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", + "link-check-diff": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", + "link-check-dev-server": "repo-link-check -r='http://localhost:3000' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", "link-check-exclude": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" }, "repository": { From e90cba9b2dc9674851026dbf45927281d4480190 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 23:23:36 -0400 Subject: [PATCH 082/174] Remove link check from pre-commit hook Currently, the wait for it is pretty poor DX. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 86388c71b8..742cdf134a 100644 --- a/package.json +++ b/package.json @@ -160,7 +160,7 @@ }, "husky": { "hooks": { - "pre-commit": "yarn format-staged && yarn lint-staged && yarn link-check-diff -z" + "pre-commit": "yarn format-staged && yarn lint-staged" } }, "lint-staged": { From 0d15093c6e69aea53259d95b8ab8927ceeed9340 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 23:46:33 -0400 Subject: [PATCH 083/174] Bump version to test for a cache issue --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index dc1656bc7f..01f38989fe 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -72,7 +72,7 @@ jobs: - run: yarn link-check-exclude workflows: - version: 2 + version: 3 commit: jobs: From 40648abf9992ad1741c94a7de4d9793eca794d46 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 19 Aug 2020 23:47:35 -0400 Subject: [PATCH 084/174] Remove unused patterns from exclude-links --- scripts/exclude-links.txt | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index ccfe27bfb4..efd6c53e46 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -1,27 +1,10 @@ -**127.0.0.1** http://localhost:8000** http://millionsongdataset.com/pages/getting-dataset/#subset -http://s3-external-1.amazonaws.com/bucket/path -https://accounts.google.com/o/oauth2/auth -https://circleci.com/gh/iterative/dvc.org -https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA -https://dvc.org/img/.gif -https://dvc.org/uploads/images/2020-02-10/image.png -https://example.com** -https://github.com/example** -https://github.com/user/proj https://marketplace.visualstudio.com/items?itemName=stkb.rewrap -https://myendpoint.com -https://object-storage.example.com -https://remote.dvc.org/dataset-registry -https://remote.dvc.org/dataset-registry/a3/04afb96060aad90176268345e10355 https://remote.dvc.org/get-started -https://s3.eu.cloud-object-storage.appdomain.cloud https://sweedom.us10.list-manage.com/subscribe/post?u=a08bf93caae4063c4e6a351f6&id=24c0ecc49a https://www.meetup.com/San-Francisco-Machine-Learning-Meetup/events/264846847/ https://www.reddit.com/r/MachineLearning/comments/bx0apm/d_how_do_you_manage_your_machine_learning/ -http://user@example.com/path -http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 **linkedin.com/in/** From cc6ea5c1ae7975b8e29c347f80a7c71e3efbcf05 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 20 Aug 2020 00:03:46 -0400 Subject: [PATCH 085/174] Remove pcregrep installation from circleCI With the old link checkers gone, nothing uses it. --- .circleci/config.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 01f38989fe..903adc9efb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -28,12 +28,6 @@ commands: git reset --hard origin/master git checkout - - - run: - name: apt dependencies - command: | - sudo apt-get update - sudo apt-get install pcregrep - # Download cached dependencies. - restore_cache: keys: From 9e67bfd853ab871cdd0553e647aa4fdd430f0593 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 20 Aug 2020 00:42:04 -0400 Subject: [PATCH 086/174] revert cache version test and try solving with npx --- .circleci/config.yml | 2 +- package.json | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 903adc9efb..3ee9b940c7 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -66,7 +66,7 @@ jobs: - run: yarn link-check-exclude workflows: - version: 3 + version: 2 commit: jobs: diff --git a/package.json b/package.json index 742cdf134a..e13793fc2e 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", - "link-check-diff": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", - "link-check-dev-server": "repo-link-check -r='http://localhost:3000' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", - "link-check-exclude": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" + "link-check": "npx repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", + "link-check-diff": "npx repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", + "link-check-dev-server": "npx repo-link-check -r='http://localhost:3000' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", + "link-check-exclude": "npx repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" }, "repository": { "type": "git", From 60674eb2a992ffca9d2592f7265e0f390ce1ec89 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 20 Aug 2020 01:03:58 -0400 Subject: [PATCH 087/174] Remove npx from scripts --- package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index e13793fc2e..742cdf134a 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "npx repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", - "link-check-diff": "npx repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", - "link-check-dev-server": "npx repo-link-check -r='http://localhost:3000' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", - "link-check-exclude": "npx repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" + "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", + "link-check-diff": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", + "link-check-dev-server": "repo-link-check -r='http://localhost:3000' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", + "link-check-exclude": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" }, "repository": { "type": "git", From c5006202a81aaa1b06bcc574e9e512b006be3dcb Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 20 Aug 2020 01:06:03 -0400 Subject: [PATCH 088/174] Remove other steps for testing --- .circleci/config.yml | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3ee9b940c7..37c9edf7db 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -18,31 +18,8 @@ commands: install: steps: - checkout - - # CircleCI breaks master branch which affects format check below. See - # https://discuss.circleci.com/t/checkout-script-adds-commits-to-master-from-circle-branch/14194 - - run: - name: restore master - command: | - git checkout master - git reset --hard origin/master - git checkout - - - # Download cached dependencies. - - restore_cache: - keys: - - v2-dependencies-{{ checksum "yarn.lock" }} - # Fallback to using the latest cache if no exact match is found. - - v2-dependencies- - - run: yarn - # Upload dependencies cache. - - save_cache: - paths: - - node_modules - key: v2-dependencies-{{ checksum "yarn.lock" }} - jobs: test: <<: *defaults From 1a115655813795102cf7599b97aef2ff0b5ed772 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 20 Aug 2020 01:14:31 -0400 Subject: [PATCH 089/174] Revert "Remove other steps for testing" This reverts commit c5006202a81aaa1b06bcc574e9e512b006be3dcb. --- .circleci/config.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 37c9edf7db..3ee9b940c7 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -18,8 +18,31 @@ commands: install: steps: - checkout + + # CircleCI breaks master branch which affects format check below. See + # https://discuss.circleci.com/t/checkout-script-adds-commits-to-master-from-circle-branch/14194 + - run: + name: restore master + command: | + git checkout master + git reset --hard origin/master + git checkout - + + # Download cached dependencies. + - restore_cache: + keys: + - v2-dependencies-{{ checksum "yarn.lock" }} + # Fallback to using the latest cache if no exact match is found. + - v2-dependencies- + - run: yarn + # Upload dependencies cache. + - save_cache: + paths: + - node_modules + key: v2-dependencies-{{ checksum "yarn.lock" }} + jobs: test: <<: *defaults From e06c9e5f4f8852f8041dbdf991d9452662a50cac Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 00:56:57 -0400 Subject: [PATCH 090/174] Switch back to master, use JSON config, and introduce exclude check --- .../{link-check.yml => link-check-deploy.yml} | 6 ++--- .github/workflows/link-check-exclude.yml | 26 +++++++++++++++++++ .linkcheckrc.json | 8 ++++++ package.json | 8 +++--- 4 files changed, 40 insertions(+), 8 deletions(-) rename .github/workflows/{link-check.yml => link-check-deploy.yml} (69%) create mode 100644 .github/workflows/link-check-exclude.yml create mode 100644 .linkcheckrc.json diff --git a/.github/workflows/link-check.yml b/.github/workflows/link-check-deploy.yml similarity index 69% rename from .github/workflows/link-check.yml rename to .github/workflows/link-check-deploy.yml index 69d01dae13..514ddfdc54 100644 --- a/.github/workflows/link-check.yml +++ b/.github/workflows/link-check-deploy.yml @@ -13,12 +13,10 @@ jobs: - name: Run the link checker id: check - uses: "iterative/link-check.action@v0.1.3" + uses: "iterative/link-check.action@master" with: + configFile: "./.linkcheckrc.yml" rootURL: "${{ github.event.deployment.payload.web_url }}" - linkExcludePatternFiles: "./scripts/exclude-links.txt" - fileExcludePatternFiles: "./scripts/exclude-files.txt" - fileIncludePatterns: "{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}" - uses: LouisBrunner/checks-action@v0.1.0 with: diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml new file mode 100644 index 0000000000..16fecbe72b --- /dev/null +++ b/.github/workflows/link-check-exclude.yml @@ -0,0 +1,26 @@ +name: DVC Link Check +on: deployment + +jobs: + run: + name: Link Check Exclude + runs-on: ubuntu-latest + + steps: + + - uses: actions/checkout@v2 + + - name: Check that all patterns are used. + id: check + uses: "iterative/link-check.action@master" + with: + configFile: "./.linkcheckrc.yml" + reportUnusedPatterns: "only" + + - uses: LouisBrunner/checks-action@v0.1.0 + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Exclude + status: completed + conclusion: ${{ steps.check.outputs.conclusion }} + output: ${{ steps.check.outputs.output }} diff --git a/.linkcheckrc.json b/.linkcheckrc.json new file mode 100644 index 0000000000..5e8452f67a --- /dev/null +++ b/.linkcheckrc.json @@ -0,0 +1,8 @@ +{ + "rootURL": "https://dvc.org", + "fileIncludePatterns": [ + "{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}" + ], + "fileExcludePatternFiles": ["./scripts/exclude-files.txt"], + "linkExcludePatternFiles": ["./scripts/exclude-links.txt"] +} diff --git a/package.json b/package.json index 742cdf134a..2b313b15b1 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u", - "link-check-diff": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", - "link-check-dev-server": "repo-link-check -r='http://localhost:3000' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt'", - "link-check-exclude": "repo-link-check -r='https://www.dvc.org' --fi='{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' --fef='./scripts/exclude-files.txt' --lef='./scripts/exclude-links.txt' -s=filesystem -u='only'" + "link-check": "repo-link-check -c='./.linkcheckrc.json' -s='filesystem' -u", + "link-check-diff": "repo-link-check -c='./.linkcheckrc.json'", + "link-check-dev-server": "repo-link-check -c='./.linkcheckrc.json' -r='http://localhost:3000'", + "link-check-exclude": "repo-link-check -c='./.linkcheckrc.json' -s='filesystem' -u='only'" }, "repository": { "type": "git", From 0505292bfb7d3004ec2f56588787b97b03edd44f Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 01:08:13 -0400 Subject: [PATCH 091/174] Fix config file path --- .github/workflows/link-check-deploy.yml | 2 +- .github/workflows/link-check-exclude.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 514ddfdc54..e88a2dabf5 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -15,7 +15,7 @@ jobs: id: check uses: "iterative/link-check.action@master" with: - configFile: "./.linkcheckrc.yml" + configFile: "./.linkcheckrc.json" rootURL: "${{ github.event.deployment.payload.web_url }}" - uses: LouisBrunner/checks-action@v0.1.0 diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml index 16fecbe72b..f7c9b7e403 100644 --- a/.github/workflows/link-check-exclude.yml +++ b/.github/workflows/link-check-exclude.yml @@ -14,7 +14,7 @@ jobs: id: check uses: "iterative/link-check.action@master" with: - configFile: "./.linkcheckrc.yml" + configFile: "./.linkcheckrc.json" reportUnusedPatterns: "only" - uses: LouisBrunner/checks-action@v0.1.0 From 5a722be988fbf013de71c9656b859f61b48829c4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 01:24:37 -0400 Subject: [PATCH 092/174] Rename script checks to better reflect their purpose --- .github/workflows/link-check-deploy.yml | 6 +++--- .github/workflows/link-check-exclude.yml | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index e88a2dabf5..c6b12d759e 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -3,7 +3,7 @@ on: deployment_status jobs: run: - name: Run Link Checker + name: Link Check Deploy runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' @@ -11,7 +11,7 @@ jobs: - uses: actions/checkout@v2 - - name: Run the link checker + - name: Run the link check script id: check uses: "iterative/link-check.action@master" with: @@ -21,7 +21,7 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check + name: Link Check Deploy status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml index f7c9b7e403..7905c9d1aa 100644 --- a/.github/workflows/link-check-exclude.yml +++ b/.github/workflows/link-check-exclude.yml @@ -10,10 +10,11 @@ jobs: - uses: actions/checkout@v2 - - name: Check that all patterns are used. + - name: Run the link check script id: check uses: "iterative/link-check.action@master" with: + source: "filesystem" configFile: "./.linkcheckrc.json" reportUnusedPatterns: "only" From a98def47f3b45eb99f415cdb7eef8bad3b083a15 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 02:37:05 -0400 Subject: [PATCH 093/174] Change top level names on scripts --- .github/workflows/link-check-deploy.yml | 2 +- .github/workflows/link-check-exclude.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index c6b12d759e..92fde585c0 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,4 +1,4 @@ -name: DVC Link Check +name: Link Check Deploy on: deployment_status jobs: diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml index 7905c9d1aa..89ea565798 100644 --- a/.github/workflows/link-check-exclude.yml +++ b/.github/workflows/link-check-exclude.yml @@ -1,4 +1,4 @@ -name: DVC Link Check +name: Link Check Exclude on: deployment jobs: From 7b745c409453b71040bf7fbae8a796c5b7696679 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 02:47:26 -0400 Subject: [PATCH 094/174] Add master's exclusion links for testing --- scripts/exclude-links.txt | 41 +++++++++++++++++++++++++++++++-------- 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index efd6c53e46..785f34e15c 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -1,15 +1,40 @@ -http://localhost:8000** -http://millionsongdataset.com/pages/getting-dataset/#subset +http://127.0.0.1:10000/devstoreaccount1; +http://localhost:8000/ +http://millionsongdataset.com/pages/getting-dataset/ +https://$ +http://s3-external-1.amazonaws.com/bucket/path +https://accounts.google.com/o/oauth2/auth +https://api.cloudflare.com/client/v4/zones/$ +https://circleci.com/gh/iterative/dvc.org +https://discuss.$ +https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA +https://dvc.org/img/.gif +https://dvc.org/uploads/images/2020-02-10/image.png +https://example.com/data.txt +https://example.com/file.csv +https://example.com/path/to/data.csv +https://example.com/path/to/dir +https://example.com/path/to/file +https://github.com/example/project.git +https://github.com/example/registry +https://github.com/iterative/dvc.org/blob/master/content$ +https://github.com/iterative/dvc/releases/download/$ +https://github.com/user/proj https://marketplace.visualstudio.com/items?itemName=stkb.rewrap +https://myendpoint.com +https://object-storage.example.com +https://remote.dvc.org/dataset-registry +https://remote.dvc.org/dataset-registry/a3/04afb96060aad90176268345e10355 https://remote.dvc.org/get-started +https://s3.eu.cloud-object-storage.appdomain.cloud https://sweedom.us10.list-manage.com/subscribe/post?u=a08bf93caae4063c4e6a351f6&id=24c0ecc49a https://www.meetup.com/San-Francisco-Machine-Learning-Meetup/events/264846847/ https://www.reddit.com/r/MachineLearning/comments/bx0apm/d_how_do_you_manage_your_machine_learning/ +https://www.youtube.com/embed/$ +http://user@example.com/path +http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject +https://towardsdatascience.com/why-git-and-how-to-use-git-as-a-data-scientist-4fa2d3bdc197 +https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5 https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 -**linkedin.com/in/** -link -/img/.gif -/uploads/images/2020-02-10/image.png -https://portal.aws.amazon.com/gp/aws/developer/registration/index.html -https://github.com/iterative/dvc/releases/download/ + From e7d7695780e691308dfca6dfd03cf72b5875c388 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 18:19:06 -0400 Subject: [PATCH 095/174] Re-remove unused patterns --- scripts/exclude-links.txt | 41 ++++++++------------------------------- 1 file changed, 8 insertions(+), 33 deletions(-) diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 785f34e15c..efd6c53e46 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -1,40 +1,15 @@ -http://127.0.0.1:10000/devstoreaccount1; -http://localhost:8000/ -http://millionsongdataset.com/pages/getting-dataset/ -https://$ -http://s3-external-1.amazonaws.com/bucket/path -https://accounts.google.com/o/oauth2/auth -https://api.cloudflare.com/client/v4/zones/$ -https://circleci.com/gh/iterative/dvc.org -https://discuss.$ -https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA -https://dvc.org/img/.gif -https://dvc.org/uploads/images/2020-02-10/image.png -https://example.com/data.txt -https://example.com/file.csv -https://example.com/path/to/data.csv -https://example.com/path/to/dir -https://example.com/path/to/file -https://github.com/example/project.git -https://github.com/example/registry -https://github.com/iterative/dvc.org/blob/master/content$ -https://github.com/iterative/dvc/releases/download/$ -https://github.com/user/proj +http://localhost:8000** +http://millionsongdataset.com/pages/getting-dataset/#subset https://marketplace.visualstudio.com/items?itemName=stkb.rewrap -https://myendpoint.com -https://object-storage.example.com -https://remote.dvc.org/dataset-registry -https://remote.dvc.org/dataset-registry/a3/04afb96060aad90176268345e10355 https://remote.dvc.org/get-started -https://s3.eu.cloud-object-storage.appdomain.cloud https://sweedom.us10.list-manage.com/subscribe/post?u=a08bf93caae4063c4e6a351f6&id=24c0ecc49a https://www.meetup.com/San-Francisco-Machine-Learning-Meetup/events/264846847/ https://www.reddit.com/r/MachineLearning/comments/bx0apm/d_how_do_you_manage_your_machine_learning/ -https://www.youtube.com/embed/$ -http://user@example.com/path -http://www.reddit.com/r/MachineLearning https://github.com/elle/myproject -https://towardsdatascience.com/why-git-and-how-to-use-git-as-a-data-scientist-4fa2d3bdc197 -https://towardsdatascience.com/understanding-auc-roc-curve-68b2303cc9c5 https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 - +**linkedin.com/in/** +link +/img/.gif +/uploads/images/2020-02-10/image.png +https://portal.aws.amazon.com/gp/aws/developer/registration/index.html +https://github.com/iterative/dvc/releases/download/ From b7d7c431934f0868eaa9a56741eea107b5b6e7c0 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 18:35:41 -0400 Subject: [PATCH 096/174] Add daily check action and remove CircleCI link checks Also rename different steps for clarity, at least to know what ends up where. --- .circleci/config.yml | 3 --- .github/workflows/link-check-all.yml | 28 +++++++++++++++++++++++++ .github/workflows/link-check-deploy.yml | 4 ++-- 3 files changed, 30 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/link-check-all.yml diff --git a/.circleci/config.yml b/.circleci/config.yml index 3ee9b940c7..fcb289117e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -52,7 +52,6 @@ jobs: - run: yarn lint-css - run: yarn lint-ts - run: yarn format-check - - run: yarn link-check-exclude test_full: <<: *defaults @@ -62,8 +61,6 @@ jobs: - run: yarn lint-css - run: yarn lint-ts - run: yarn format-check - - run: yarn link-check - - run: yarn link-check-exclude workflows: version: 2 diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml new file mode 100644 index 0000000000..dd93428c67 --- /dev/null +++ b/.github/workflows/link-check-all.yml @@ -0,0 +1,28 @@ +name: Link Check All +on: + schedule: + - cron: '0 0 * * *' + +jobs: + run: + name: Link Check All Job + runs-on: ubuntu-latest + + steps: + + - uses: actions/checkout@v2 + + - name: Run the link check script + id: check + uses: "iterative/link-check.action@master" + with: + source: "filesystem" + configFile: "./.linkcheckrc.json" + + - uses: LouisBrunner/checks-action@v0.1.0 + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check All Check + status: completed + conclusion: ${{ steps.check.outputs.conclusion }} + output: ${{ steps.check.outputs.output }} diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 92fde585c0..b404fd21e8 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -3,7 +3,7 @@ on: deployment_status jobs: run: - name: Link Check Deploy + name: Link Check Deploy Job runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' @@ -21,7 +21,7 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + name: Link Check Deploy Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} From 5c7c66fea53b94efc8ca07ab834d6e873636cbb0 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 21 Aug 2020 23:54:16 -0400 Subject: [PATCH 097/174] Rename exclude job in the same way as the others --- .github/workflows/link-check-exclude.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml index 89ea565798..b69a6b0fb7 100644 --- a/.github/workflows/link-check-exclude.yml +++ b/.github/workflows/link-check-exclude.yml @@ -3,7 +3,7 @@ on: deployment jobs: run: - name: Link Check Exclude + name: Link Check Exclude Job runs-on: ubuntu-latest steps: @@ -21,7 +21,7 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Exclude + name: Link Check Exclude Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} From 0182072dca628d7450f2712bf2ef2a448d2649c6 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 14:11:48 -0400 Subject: [PATCH 098/174] Add workflow_dispatch to the triggers for the full check --- .github/workflows/link-check-all.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index dd93428c67..89d7316a7c 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,5 +1,6 @@ name: Link Check All on: + workflow_dispatch: schedule: - cron: '0 0 * * *' From e5690285ae315f7d978b635946fe51382e205916 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 14:38:00 -0400 Subject: [PATCH 099/174] Add deployment to full check triggers for testing --- .github/workflows/link-check-all.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 89d7316a7c..3c35c4f181 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,5 +1,6 @@ name: Link Check All on: + deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' From 62d1b706ba2d17f7f2c9b33a3509d098c6a59c1c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 15:33:05 -0400 Subject: [PATCH 100/174] Make obvious fixes to dead links from the full check --- content/authors/marcel_rd.md | 4 ++-- content/blog/2020-01-17-january-20-dvc-heartbeat.md | 2 +- content/blog/2020-04-30-gsod-ideas-2020.md | 2 +- .../blog/2020-05-08-dvc-ambassador-program-announcement.md | 2 +- content/blog/2020-06-08-june-20-dvc-heartbeat.md | 2 +- scripts/exclude-links.txt | 1 + 6 files changed, 7 insertions(+), 6 deletions(-) diff --git a/content/authors/marcel_rd.md b/content/authors/marcel_rd.md index 95ae8898f5..66ddada930 100644 --- a/content/authors/marcel_rd.md +++ b/content/authors/marcel_rd.md @@ -5,7 +5,7 @@ links: - https://twitter.com/mribeirodantas --- -Early Stage Researcher at [Institut Curie](https://intstitut-curie.org) with +Early Stage Researcher at [Institut Curie](https://institut-curie.org/) with over 10 years of experience in the field of biomedical engineering and health informatics. Areas of interest include Causal Inference, Artificial Intelligence, and Data Science. Degrees in Computer and Automation Engineering @@ -13,4 +13,4 @@ Intelligence, and Data Science. Degrees in Computer and Automation Engineering Ph.D. at EDITE (Sorbonne Université). Twitter: [@mribeirodantas](https://twitter.com/mribeirodantas) Website: -[mribeirodantas.me](https://mribeirodantas.me) +[mribeirodantas.me](http://mribeirodantas.me) diff --git a/content/blog/2020-01-17-january-20-dvc-heartbeat.md b/content/blog/2020-01-17-january-20-dvc-heartbeat.md index 1cee3dab2d..ea11f3a2f8 100644 --- a/content/blog/2020-01-17-january-20-dvc-heartbeat.md +++ b/content/blog/2020-01-17-january-20-dvc-heartbeat.md @@ -37,7 +37,7 @@ biggest contributors, [Vít Novotný](https://github.com/witiko), and ![](/uploads/images/2020-01-17/odd_with_deevee.png)_Vera (center, flashing a peace sign) thanked us with this lovely picture of DeeVee and her team, -[Odd Industries](https://odd.co/en/). They are making some extremely neat tools +[Odd Industries](https://odd.co). They are making some extremely neat tools for construction teams using computer vision._ **We were at PyData LA!** Our fearless leader diff --git a/content/blog/2020-04-30-gsod-ideas-2020.md b/content/blog/2020-04-30-gsod-ideas-2020.md index f948c9286f..651be89089 100644 --- a/content/blog/2020-04-30-gsod-ideas-2020.md +++ b/content/blog/2020-04-30-gsod-ideas-2020.md @@ -190,7 +190,7 @@ technical writer, [Jorge](https://github.com/jorgeorpinel). ![](/uploads/images/2020-04-30/Discord_user_video_tutorials.png) _Video tutorials are a common request by users in our [chat](https://dvc.org/chat)._ - **Mentor**: [Elle](https://github.com/andronovhopf) + **Mentor**: [Elle](https://github.com/elleobrien) _Difficulty rating:_ Beginner-Medium

diff --git a/content/blog/2020-05-08-dvc-ambassador-program-announcement.md b/content/blog/2020-05-08-dvc-ambassador-program-announcement.md index 1358cde119..0ddd5fa1e7 100644 --- a/content/blog/2020-05-08-dvc-ambassador-program-announcement.md +++ b/content/blog/2020-05-08-dvc-ambassador-program-announcement.md @@ -179,7 +179,7 @@ a goldmine for ways to pitch in. For example: ![](/uploads/images/2020-01-17/odd_with_deevee.png 'Vera and team =500')_Vera (center, flashing a peace sign) thanked us with this lovely picture of DeeVee -and her team, [Odd Industries](https://odd.co/en/)._ +and her team, [Odd Industries](https://odd.co)._ If any of this sounds fun to you, please be in touch over [email](mailto:info@dvc.org) (and you can also reach us on diff --git a/content/blog/2020-06-08-june-20-dvc-heartbeat.md b/content/blog/2020-06-08-june-20-dvc-heartbeat.md index d81fc6a61f..22ca76dedd 100644 --- a/content/blog/2020-06-08-june-20-dvc-heartbeat.md +++ b/content/blog/2020-06-08-june-20-dvc-heartbeat.md @@ -79,7 +79,7 @@ platform. It's awesome to know our approach is resonating with teams at the intersection of ML and software development. Thanks, ThoughtWorks! Last up in company news: you might recall that in early May, we hosted an online -meetup. [Marcel Ribeiro-Dantas](mribeirodantas.me) hosted guest talks from +meetup. [Marcel Ribeiro-Dantas](http://mribeirodantas.me) hosted guest talks from [Elizabeth Hutton](https://github.com/ehutt) and [Dean Pleban](https://twitter.com/DeanPlbn)- we heard about constructing a new COVID-19 dataset, using DVC with transformer language models, and building diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 8f0f623302..1bc23cc8f2 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -13,3 +13,4 @@ link /uploads/images/2020-02-10/image.png https://portal.aws.amazon.com/gp/aws/developer/registration/index.html https://github.com/iterative/dvc/releases/download/ +https://www.kaggle.com/kurianbenoy/introduction-to-data-version-control-dvc From a197faa22ee9636253bf274e2cb1fa6aff947edd Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 15:47:33 -0400 Subject: [PATCH 101/174] Fix formatting --- content/blog/2020-01-17-january-20-dvc-heartbeat.md | 4 ++-- content/blog/2020-06-08-june-20-dvc-heartbeat.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/content/blog/2020-01-17-january-20-dvc-heartbeat.md b/content/blog/2020-01-17-january-20-dvc-heartbeat.md index ea11f3a2f8..b6c99c1c36 100644 --- a/content/blog/2020-01-17-january-20-dvc-heartbeat.md +++ b/content/blog/2020-01-17-january-20-dvc-heartbeat.md @@ -37,8 +37,8 @@ biggest contributors, [Vít Novotný](https://github.com/witiko), and ![](/uploads/images/2020-01-17/odd_with_deevee.png)_Vera (center, flashing a peace sign) thanked us with this lovely picture of DeeVee and her team, -[Odd Industries](https://odd.co). They are making some extremely neat tools -for construction teams using computer vision._ +[Odd Industries](https://odd.co). They are making some extremely neat tools for +construction teams using computer vision._ **We were at PyData LA!** Our fearless leader [Dmitry gave a talk](https://www.youtube.com/watch?v=7Wsd6V0k4Oc) and we set up diff --git a/content/blog/2020-06-08-june-20-dvc-heartbeat.md b/content/blog/2020-06-08-june-20-dvc-heartbeat.md index 22ca76dedd..4e3ebf043c 100644 --- a/content/blog/2020-06-08-june-20-dvc-heartbeat.md +++ b/content/blog/2020-06-08-june-20-dvc-heartbeat.md @@ -79,8 +79,8 @@ platform. It's awesome to know our approach is resonating with teams at the intersection of ML and software development. Thanks, ThoughtWorks! Last up in company news: you might recall that in early May, we hosted an online -meetup. [Marcel Ribeiro-Dantas](http://mribeirodantas.me) hosted guest talks from -[Elizabeth Hutton](https://github.com/ehutt) and +meetup. [Marcel Ribeiro-Dantas](http://mribeirodantas.me) hosted guest talks +from [Elizabeth Hutton](https://github.com/ehutt) and [Dean Pleban](https://twitter.com/DeanPlbn)- we heard about constructing a new COVID-19 dataset, using DVC with transformer language models, and building custom cloud infrastructure for MLOps. There's also Q&A with the DVC team, where From 72d594bca0864b01b83edb7c6d3354b358a22ff4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 17:14:43 -0400 Subject: [PATCH 102/174] Add custom link check bottlenecks for GitHub and Wikipedia Both sites are more aggressive than normal about 429s Wikipedia specifically, which even throws them with 1000ms minTime --- .linkcheckrc.json | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.linkcheckrc.json b/.linkcheckrc.json index 5e8452f67a..a17486e0d1 100644 --- a/.linkcheckrc.json +++ b/.linkcheckrc.json @@ -4,5 +4,15 @@ "{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}" ], "fileExcludePatternFiles": ["./scripts/exclude-files.txt"], - "linkExcludePatternFiles": ["./scripts/exclude-links.txt"] + "linkExcludePatternFiles": ["./scripts/exclude-links.txt"], + "bottlenecks": { + "*.wikipedia.org": { + "minTime": 2000, + "maxConcurrent": 1 + }, + "*.github.com": { + "minTime": 1000, + "maxConcurrent": 1 + } + } } From d43f7c8bb1461a474a908823784d5c0dc44bcb7a Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 17:22:26 -0400 Subject: [PATCH 103/174] Remove link-check-all deploy trigger after successful test --- .github/workflows/link-check-all.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 3c35c4f181..89d7316a7c 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,6 +1,5 @@ name: Link Check All on: - deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' From e89d601109b0af43c4fc4dced240130434e1d1fa Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 24 Aug 2020 17:30:07 -0400 Subject: [PATCH 104/174] Pin link check action version to tag instead of master just a best practice thing --- .github/workflows/link-check-all.yml | 2 +- .github/workflows/link-check-deploy.yml | 2 +- .github/workflows/link-check-exclude.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 89d7316a7c..25956035f1 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -15,7 +15,7 @@ jobs: - name: Run the link check script id: check - uses: "iterative/link-check.action@master" + uses: "iterative/link-check.action@v0.3.0" with: source: "filesystem" configFile: "./.linkcheckrc.json" diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index b404fd21e8..94ab7e2120 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link check script id: check - uses: "iterative/link-check.action@master" + uses: "iterative/link-check.action@v0.3.0" with: configFile: "./.linkcheckrc.json" rootURL: "${{ github.event.deployment.payload.web_url }}" diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml index b69a6b0fb7..6f60f297a4 100644 --- a/.github/workflows/link-check-exclude.yml +++ b/.github/workflows/link-check-exclude.yml @@ -12,7 +12,7 @@ jobs: - name: Run the link check script id: check - uses: "iterative/link-check.action@master" + uses: "iterative/link-check.action@v0.3.0" with: source: "filesystem" configFile: "./.linkcheckrc.json" From e80238ee90b7ab097f48902ec266af2007b04efb Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 2 Sep 2020 14:33:46 -0400 Subject: [PATCH 105/174] Change invocation style of link-check scripts --- package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index c636c43161..9eb2ed7d2c 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -c='./.linkcheckrc.json' -s='filesystem' -u", - "link-check-diff": "repo-link-check -c='./.linkcheckrc.json'", - "link-check-dev-server": "repo-link-check -c='./.linkcheckrc.json' -r='http://localhost:3000'", - "link-check-exclude": "repo-link-check -c='./.linkcheckrc.json' -s='filesystem' -u='only'" + "link-check": "repo-link-check -c ./.linkcheckrc.json -s filesystem -u", + "link-check-diff": "repo-link-check -c ./.linkcheckrc.json", + "link-check-dev-server": "repo-link-check -c ./.linkcheckrc.json -r http://localhost:3000", + "link-check-exclude": "repo-link-check -c ./.linkcheckrc.json -s filesystem -u only" }, "repository": { "type": "git", From 360be7a979709e67815a1901e554ab35add4949f Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 2 Sep 2020 20:04:51 -0400 Subject: [PATCH 106/174] Overhaul check definitions This combines the exclude check into the full check, and rolls the exclusion check into it. It also adapts the definitions to the configurable outputs feature. --- .github/workflows/link-check-all.yml | 14 ++++-------- .github/workflows/link-check-deploy.yml | 3 ++- .github/workflows/link-check-exclude.yml | 27 ------------------------ 3 files changed, 6 insertions(+), 38 deletions(-) delete mode 100644 .github/workflows/link-check-exclude.yml diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 25956035f1..9f3184bdc9 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -14,16 +14,10 @@ jobs: - uses: actions/checkout@v2 - name: Run the link check script - id: check - uses: "iterative/link-check.action@v0.3.0" + uses: "iterative/link-check.action@v0.4" with: source: "filesystem" configFile: "./.linkcheckrc.json" - - - uses: LouisBrunner/checks-action@v0.1.0 - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check All Check - status: completed - conclusion: ${{ steps.check.outputs.conclusion }} - output: ${{ steps.check.outputs.output }} + reportUnusedPatterns: true + output: >- + ["consoleLog", "exitCode"] diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 94ab7e2120..79789be8ee 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -13,10 +13,11 @@ jobs: - name: Run the link check script id: check - uses: "iterative/link-check.action@v0.3.0" + uses: "iterative/link-check.action@v0.4" with: configFile: "./.linkcheckrc.json" rootURL: "${{ github.event.deployment.payload.web_url }}" + output: checkOutput - uses: LouisBrunner/checks-action@v0.1.0 with: diff --git a/.github/workflows/link-check-exclude.yml b/.github/workflows/link-check-exclude.yml deleted file mode 100644 index 6f60f297a4..0000000000 --- a/.github/workflows/link-check-exclude.yml +++ /dev/null @@ -1,27 +0,0 @@ -name: Link Check Exclude -on: deployment - -jobs: - run: - name: Link Check Exclude Job - runs-on: ubuntu-latest - - steps: - - - uses: actions/checkout@v2 - - - name: Run the link check script - id: check - uses: "iterative/link-check.action@v0.3.0" - with: - source: "filesystem" - configFile: "./.linkcheckrc.json" - reportUnusedPatterns: "only" - - - uses: LouisBrunner/checks-action@v0.1.0 - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Exclude Check - status: completed - conclusion: ${{ steps.check.outputs.conclusion }} - output: ${{ steps.check.outputs.output }} From b9beb080aaab61f8989922269c125e35c40a879d Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 2 Sep 2020 21:21:30 -0400 Subject: [PATCH 107/174] Update repo-link-check and add deployment test to all check --- .github/workflows/link-check-all.yml | 1 + package.json | 2 +- scripts/exclude-links.txt | 1 - yarn.lock | 8 ++++---- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 9f3184bdc9..375794f3d3 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,5 +1,6 @@ name: Link Check All on: + deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' diff --git a/package.json b/package.json index 9eb2ed7d2c..f028af1d4d 100644 --- a/package.json +++ b/package.json @@ -76,7 +76,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.2.1", + "repo-link-check": "^0.4.1", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/scripts/exclude-links.txt b/scripts/exclude-links.txt index 5820162c08..647db43627 100644 --- a/scripts/exclude-links.txt +++ b/scripts/exclude-links.txt @@ -14,5 +14,4 @@ link https://portal.aws.amazon.com/gp/aws/developer/registration/index.html https://github.com/iterative/dvc/releases/download/ https://www.kaggle.com/kurianbenoy/introduction-to-data-version-control-dvc -https://asset.cml.dev https://timheuer.com/blog/skipping-ci-github-actions-workflows/ diff --git a/yarn.lock b/yarn.lock index 9941668ba0..344571feaf 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14407,10 +14407,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.2.1: - version "0.2.1" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.2.1.tgz#a197fe1e1219e93af11a0e4e43358168e1f1bc7e" - integrity sha512-ekfFEnXdIue+kGOP4nFggVhoHaRU0aPY8v1jE1Fqnq94bUrb4NhyGWJ0Cuhnz78pVaC66LRAERlzH2bGVNCDQA== +repo-link-check@^0.4.1: + version "0.4.1" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.4.1.tgz#96a0a4d2d5ee9ca5ad9008e04e34e34cb78e06ef" + integrity sha512-7DbvtlYuqdZxgESULEviwJu3WIueLeoiDJEHjnwqeNcPfoJmHwk2hjUiXL1OHbda5R9IDLImiYm1w7gaNWl5uw== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From 0426fb2678dcb7d2d77ca7f4f0c363cbb8a497e5 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 2 Sep 2020 22:31:29 -0400 Subject: [PATCH 108/174] Remove on-deploy from full check and fix output setting for deploy --- .github/workflows/link-check-all.yml | 1 - .github/workflows/link-check-deploy.yml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 375794f3d3..9f3184bdc9 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,6 +1,5 @@ name: Link Check All on: - deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 79789be8ee..77768b2420 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -17,7 +17,7 @@ jobs: with: configFile: "./.linkcheckrc.json" rootURL: "${{ github.event.deployment.payload.web_url }}" - output: checkOutput + output: checkAction - uses: LouisBrunner/checks-action@v0.1.0 with: From b9adb44bda9d2f0cb6635b562ccea84abb01113b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 00:18:34 -0400 Subject: [PATCH 109/174] Add a workflow to queue up the deployment link check --- .github/workflows/queue-deploy-check.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/workflows/queue-deploy-check.yml diff --git a/.github/workflows/queue-deploy-check.yml b/.github/workflows/queue-deploy-check.yml new file mode 100644 index 0000000000..d1e60d9f59 --- /dev/null +++ b/.github/workflows/queue-deploy-check.yml @@ -0,0 +1,15 @@ +name: Queue Link Check Deploy +on: deployment + +jobs: + run: + name: Link Check Deploy + runs-on: ubuntu-latest + + steps: + + - uses: LouisBrunner/checks-action@v0.1.0 + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy Check + status: in_progress From eb6dab18c92108cd97bbc5b09ca4bdf58d13a3c5 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 00:22:44 -0400 Subject: [PATCH 110/174] Add conclusion to deploy check initializer I forgot it's required --- .github/workflows/queue-deploy-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/queue-deploy-check.yml b/.github/workflows/queue-deploy-check.yml index d1e60d9f59..8881393c84 100644 --- a/.github/workflows/queue-deploy-check.yml +++ b/.github/workflows/queue-deploy-check.yml @@ -13,3 +13,4 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check Deploy Check status: in_progress + conclusion: neutral From df54b1ee5ede131521274349f86f07ac7d4b8e9d Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 00:24:24 -0400 Subject: [PATCH 111/174] Rename deploy checks to be unified --- .github/workflows/link-check-deploy.yml | 2 +- .github/workflows/queue-deploy-check.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 77768b2420..1bdac57ed9 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -3,7 +3,7 @@ on: deployment_status jobs: run: - name: Link Check Deploy Job + name: Link Check Deploy runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' diff --git a/.github/workflows/queue-deploy-check.yml b/.github/workflows/queue-deploy-check.yml index 8881393c84..4eeb689dce 100644 --- a/.github/workflows/queue-deploy-check.yml +++ b/.github/workflows/queue-deploy-check.yml @@ -1,4 +1,4 @@ -name: Queue Link Check Deploy +name: Link Check Deploy on: deployment jobs: From 956dac8d9c11166fcf8022303862b0f97dc22892 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 19:50:40 -0400 Subject: [PATCH 112/174] Rename deploy check to match initializer Hopefully this will collapse the two, but probably not. --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 1bdac57ed9..31831b31e0 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -22,7 +22,7 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy Check + name: Link Check Deploy status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} From 787d286a216a6771949a690a92d4d0e0a7a53b7c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 20:43:52 -0400 Subject: [PATCH 113/174] Point check action to master --- .github/workflows/link-check-all.yml | 2 +- .../{queue-deploy-check.yml => link-check-deploy-init.yml} | 0 .github/workflows/link-check-deploy.yml | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename .github/workflows/{queue-deploy-check.yml => link-check-deploy-init.yml} (100%) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 9f3184bdc9..d2da214b90 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -14,7 +14,7 @@ jobs: - uses: actions/checkout@v2 - name: Run the link check script - uses: "iterative/link-check.action@v0.4" + uses: "iterative/link-check.action@master" with: source: "filesystem" configFile: "./.linkcheckrc.json" diff --git a/.github/workflows/queue-deploy-check.yml b/.github/workflows/link-check-deploy-init.yml similarity index 100% rename from .github/workflows/queue-deploy-check.yml rename to .github/workflows/link-check-deploy-init.yml diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 31831b31e0..5cafd893a1 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -13,7 +13,7 @@ jobs: - name: Run the link check script id: check - uses: "iterative/link-check.action@v0.4" + uses: "iterative/link-check.action@master" with: configFile: "./.linkcheckrc.json" rootURL: "${{ github.event.deployment.payload.web_url }}" From 83a0e17a47c28511b170f57acf8de1f89124f197 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 20:53:24 -0400 Subject: [PATCH 114/174] Rename again The last ones weren't unified --- .github/workflows/link-check-deploy-init.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index 4eeb689dce..deabd574ce 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -11,6 +11,6 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy Check + name: Link Check Deploy status: in_progress conclusion: neutral From f773625082c3404a522203aaaf801fe55368f7ef Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 23:23:56 -0400 Subject: [PATCH 115/174] Remove name in an attempt to hide initializer --- .github/workflows/link-check-deploy-init.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index deabd574ce..a5b7cad26c 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -3,11 +3,8 @@ on: deployment jobs: run: - name: Link Check Deploy runs-on: ubuntu-latest - steps: - - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} From f4e2ddf1a6cd521d8d78e2ff62776eebbcda6bcf Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 23:35:00 -0400 Subject: [PATCH 116/174] Rename jobs to underscores in an attempt to hide them. --- .github/workflows/link-check-deploy-init.yml | 2 +- .github/workflows/link-check-deploy.yml | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index a5b7cad26c..6f0abf687e 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -2,7 +2,7 @@ name: Link Check Deploy on: deployment jobs: - run: + _: runs-on: ubuntu-latest steps: - uses: LouisBrunner/checks-action@v0.1.0 diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 5cafd893a1..b3c6feed07 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -2,8 +2,7 @@ name: Link Check Deploy on: deployment_status jobs: - run: - name: Link Check Deploy + _: runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' From 9ef0fe608321b8da11a98a5b9af09b68c69438f9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 23:41:35 -0400 Subject: [PATCH 117/174] Accept we can't hide the initialization and rename accordingly --- .github/workflows/link-check-all.yml | 4 ++-- .github/workflows/link-check-deploy-init.yml | 3 ++- .github/workflows/link-check-deploy.yml | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index d2da214b90..b4f49306d9 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -6,14 +6,14 @@ on: jobs: run: - name: Link Check All Job + name: Link Check All runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Run the link check script + - name: Run Link Check uses: "iterative/link-check.action@master" with: source: "filesystem" diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index 6f0abf687e..cc2b97af9c 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -2,7 +2,8 @@ name: Link Check Deploy on: deployment jobs: - _: + run: + name: Initialize runs-on: ubuntu-latest steps: - uses: LouisBrunner/checks-action@v0.1.0 diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index b3c6feed07..e035860cdb 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -2,7 +2,8 @@ name: Link Check Deploy on: deployment_status jobs: - _: + run: + name: Check runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' From 36d334e19a4b7693be858da4a49467736ddbbc3c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 23:50:52 -0400 Subject: [PATCH 118/174] Move link check config file --- .linkcheckrc.json => config/link-check.json | 0 package.json | 8 ++++---- 2 files changed, 4 insertions(+), 4 deletions(-) rename .linkcheckrc.json => config/link-check.json (100%) diff --git a/.linkcheckrc.json b/config/link-check.json similarity index 100% rename from .linkcheckrc.json rename to config/link-check.json diff --git a/package.json b/package.json index f028af1d4d..d2057e075c 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -c ./.linkcheckrc.json -s filesystem -u", - "link-check-diff": "repo-link-check -c ./.linkcheckrc.json", - "link-check-dev-server": "repo-link-check -c ./.linkcheckrc.json -r http://localhost:3000", - "link-check-exclude": "repo-link-check -c ./.linkcheckrc.json -s filesystem -u only" + "link-check": "repo-link-check -c ./config/link-check.json -s filesystem -u", + "link-check-diff": "repo-link-check -c ./config/link-check.json", + "link-check-dev-server": "repo-link-check -c ./config/link-check.json -r http://localhost:3000", + "link-check-exclude": "repo-link-check -c ./config/link-check.json -s filesystem -u only" }, "repository": { "type": "git", From 57190acba33b32875a0fe8a1758ec5546ccf35cd Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 23:51:28 -0400 Subject: [PATCH 119/174] Rename the actual check to look nicer --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index e035860cdb..24387a2d59 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -22,7 +22,7 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + name: Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} From b2804ac04158b9d236a24edb1a5004d7179a3896 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 3 Sep 2020 23:56:41 -0400 Subject: [PATCH 120/174] Rename and move config files to config subdirectory --- config/{link-check.json => link-check/config.json} | 4 ++-- .../link-check/excluded-files.txt | 0 .../link-check/excluded-links.txt | 0 package.json | 8 ++++---- 4 files changed, 6 insertions(+), 6 deletions(-) rename config/{link-check.json => link-check/config.json} (67%) rename scripts/exclude-files.txt => config/link-check/excluded-files.txt (100%) rename scripts/exclude-links.txt => config/link-check/excluded-links.txt (100%) diff --git a/config/link-check.json b/config/link-check/config.json similarity index 67% rename from config/link-check.json rename to config/link-check/config.json index a17486e0d1..364234cc89 100644 --- a/config/link-check.json +++ b/config/link-check/config.json @@ -3,8 +3,8 @@ "fileIncludePatterns": [ "{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}" ], - "fileExcludePatternFiles": ["./scripts/exclude-files.txt"], - "linkExcludePatternFiles": ["./scripts/exclude-links.txt"], + "fileExcludePatternFiles": ["./config/link-check/excluded-files.txt"], + "linkExcludePatternFiles": ["./config/link-check/excluded-links.txt"], "bottlenecks": { "*.wikipedia.org": { "minTime": 2000, diff --git a/scripts/exclude-files.txt b/config/link-check/excluded-files.txt similarity index 100% rename from scripts/exclude-files.txt rename to config/link-check/excluded-files.txt diff --git a/scripts/exclude-links.txt b/config/link-check/excluded-links.txt similarity index 100% rename from scripts/exclude-links.txt rename to config/link-check/excluded-links.txt diff --git a/package.json b/package.json index d2057e075c..ec6a1c7a76 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -c ./config/link-check.json -s filesystem -u", - "link-check-diff": "repo-link-check -c ./config/link-check.json", - "link-check-dev-server": "repo-link-check -c ./config/link-check.json -r http://localhost:3000", - "link-check-exclude": "repo-link-check -c ./config/link-check.json -s filesystem -u only" + "link-check": "repo-link-check -c ./config/link-check/config.json -s filesystem -u", + "link-check-diff": "repo-link-check -c ./config/link-check/config.json", + "link-check-dev-server": "repo-link-check -c ./config/link-check/config.json -r http://localhost:3000", + "link-check-exclude": "repo-link-check -c ./config/link-check/config.json -s filesystem -u only" }, "repository": { "type": "git", From 2a5e60139aafd573943ac6b86e92f364ccb467e9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 00:09:51 -0400 Subject: [PATCH 121/174] Rename check in init workflow --- .github/workflows/link-check-deploy-init.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index cc2b97af9c..52118ab521 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -9,6 +9,6 @@ jobs: - uses: LouisBrunner/checks-action@v0.1.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + name: Check status: in_progress conclusion: neutral From 852d8117674a57c4f58be07b77be000419e8d71c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 00:20:28 -0400 Subject: [PATCH 122/174] Fix config file path on workflows --- .github/workflows/link-check-all.yml | 2 +- .github/workflows/link-check-deploy.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index b4f49306d9..6d15a12769 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -17,7 +17,7 @@ jobs: uses: "iterative/link-check.action@master" with: source: "filesystem" - configFile: "./.linkcheckrc.json" + configFile: "./config/link-check/config.json" reportUnusedPatterns: true output: >- ["consoleLog", "exitCode"] diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 24387a2d59..727b2d64ea 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -15,7 +15,7 @@ jobs: id: check uses: "iterative/link-check.action@master" with: - configFile: "./.linkcheckrc.json" + configFile: "./config/link-check/config.json" rootURL: "${{ github.event.deployment.payload.web_url }}" output: checkAction From 7a8eeade26b24a31ad130b6f8219f3d5c8ddb7a4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 13:55:55 -0400 Subject: [PATCH 123/174] Upgrade repo-link-check --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index ec6a1c7a76..74945494f2 100644 --- a/package.json +++ b/package.json @@ -76,7 +76,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.4.1", + "repo-link-check": "^0.4.3", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index 344571feaf..e7a83d74b6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14407,10 +14407,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.4.1: - version "0.4.1" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.4.1.tgz#96a0a4d2d5ee9ca5ad9008e04e34e34cb78e06ef" - integrity sha512-7DbvtlYuqdZxgESULEviwJu3WIueLeoiDJEHjnwqeNcPfoJmHwk2hjUiXL1OHbda5R9IDLImiYm1w7gaNWl5uw== +repo-link-check@^0.4.3: + version "0.4.3" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.4.3.tgz#05e02ce584cf0c9b56883897f9c0a3dc1294e9d3" + integrity sha512-O3UJUwb4ZfJU5EJ6uzdsH4N1SJ5sG2dQw92dykksX9QcSQCz69/7XfPnMqykXFsRRfRnyedsKriLVleX09sJFQ== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From 5c460c1e29537ee7c4a91dc13e15f3c4238fb164 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 14:35:07 -0400 Subject: [PATCH 124/174] Add deployment run and unused patterns to test full check --- .github/workflows/link-check-all.yml | 1 + config/link-check/excluded-links.txt | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 6d15a12769..28aa3ca87a 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,5 +1,6 @@ name: Link Check All on: + deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' diff --git a/config/link-check/excluded-links.txt b/config/link-check/excluded-links.txt index 647db43627..12df1cbfe7 100644 --- a/config/link-check/excluded-links.txt +++ b/config/link-check/excluded-links.txt @@ -15,3 +15,5 @@ https://portal.aws.amazon.com/gp/aws/developer/registration/index.html https://github.com/iterative/dvc/releases/download/ https://www.kaggle.com/kurianbenoy/introduction-to-data-version-control-dvc https://timheuer.com/blog/skipping-ci-github-actions-workflows/ +https://www.unusedpattern.com +https://*.unusedglob.** From d086504652913a4c7f2169269a3428ba0d9ab1ef Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 14:50:24 -0400 Subject: [PATCH 125/174] Revert full run test This reverts commit 5c460c1e29537ee7c4a91dc13e15f3c4238fb164. --- .github/workflows/link-check-all.yml | 1 - config/link-check/excluded-links.txt | 2 -- 2 files changed, 3 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 28aa3ca87a..6d15a12769 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,6 +1,5 @@ name: Link Check All on: - deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' diff --git a/config/link-check/excluded-links.txt b/config/link-check/excluded-links.txt index 12df1cbfe7..647db43627 100644 --- a/config/link-check/excluded-links.txt +++ b/config/link-check/excluded-links.txt @@ -15,5 +15,3 @@ https://portal.aws.amazon.com/gp/aws/developer/registration/index.html https://github.com/iterative/dvc/releases/download/ https://www.kaggle.com/kurianbenoy/introduction-to-data-version-control-dvc https://timheuer.com/blog/skipping-ci-github-actions-workflows/ -https://www.unusedpattern.com -https://*.unusedglob.** From 91549d88fd282cfc64d20f8de22470987caa00df Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 14:56:36 -0400 Subject: [PATCH 126/174] Add example links for another deploy example --- content/blog/2020-08-27-august-20-community-gems.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/content/blog/2020-08-27-august-20-community-gems.md b/content/blog/2020-08-27-august-20-community-gems.md index f785f28f05..76c1198508 100644 --- a/content/blog/2020-08-27-august-20-community-gems.md +++ b/content/blog/2020-08-27-august-20-community-gems.md @@ -21,6 +21,11 @@ tags: - Pipeline --- +[Nonexistent site](https://www.notarealsite.co.uk) +[404](https://www.google.com/thisisnotarealpage) [relative pass](/doc) +[relative 404](/notdocsnotanything) +[filtered](https://github.com/iterative/dvc/releases/download/) + Here are some of our top Q&A's from around the community. With the launch of [CML](https://cml.dev) earlier in the month, we've got some new ground to cover! From f0382f4e5d222e39a2c966cd1986eee7f9048c8a Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 15:51:07 -0400 Subject: [PATCH 127/174] Upgrade repo-link-check Adds better error message for nonexistent site --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 74945494f2..4002afd466 100644 --- a/package.json +++ b/package.json @@ -76,7 +76,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.4.3", + "repo-link-check": "^0.4.4", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index e7a83d74b6..3f0cdc4be4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14407,10 +14407,10 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.4.3: - version "0.4.3" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.4.3.tgz#05e02ce584cf0c9b56883897f9c0a3dc1294e9d3" - integrity sha512-O3UJUwb4ZfJU5EJ6uzdsH4N1SJ5sG2dQw92dykksX9QcSQCz69/7XfPnMqykXFsRRfRnyedsKriLVleX09sJFQ== +repo-link-check@^0.4.4: + version "0.4.4" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.4.4.tgz#6b844e56b565d60c4209a5e18f9dfda79ae8936c" + integrity sha512-2VnOVi1Ffx+G5cGUBa0/URDd0CKYt28NAMqz/L7Abh90HXexInjKk0dvOtqAvazSn0LCwkTvevyOUKy8IGsLKg== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" From 5fcc9fd97b8d7f0d7395b58be3889a018b346f22 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 16:01:48 -0400 Subject: [PATCH 128/174] Revert failing link examples --- content/blog/2020-08-27-august-20-community-gems.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/content/blog/2020-08-27-august-20-community-gems.md b/content/blog/2020-08-27-august-20-community-gems.md index 76c1198508..f785f28f05 100644 --- a/content/blog/2020-08-27-august-20-community-gems.md +++ b/content/blog/2020-08-27-august-20-community-gems.md @@ -21,11 +21,6 @@ tags: - Pipeline --- -[Nonexistent site](https://www.notarealsite.co.uk) -[404](https://www.google.com/thisisnotarealpage) [relative pass](/doc) -[relative 404](/notdocsnotanything) -[filtered](https://github.com/iterative/dvc/releases/download/) - Here are some of our top Q&A's from around the community. With the launch of [CML](https://cml.dev) earlier in the month, we've got some new ground to cover! From dec502515d1d39660ec329550f3f9b7c943e1933 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 16:05:49 -0400 Subject: [PATCH 129/174] Remove conclusion from init to see if docs example works I feel like I've seen this not work, but it's worth a try while I'm working on this. --- .github/workflows/link-check-deploy-init.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index 52118ab521..ac4cd0ecb7 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -11,4 +11,3 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} name: Check status: in_progress - conclusion: neutral From 4eada7d70dc14b7d47bc954f16ebf07bbbda6785 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 16:08:23 -0400 Subject: [PATCH 130/174] Add blank conclusion to test --- .github/workflows/link-check-deploy-init.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index ac4cd0ecb7..23ab5b614d 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -11,3 +11,4 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} name: Check status: in_progress + conclusion: From d53be9aa96a2320599f65ffebdc8b857df5cb344 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 16:13:26 -0400 Subject: [PATCH 131/174] Re-add conclusion with better description on deploy check initializer --- .github/workflows/link-check-deploy-init.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index 23ab5b614d..1e6918c495 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -11,4 +11,6 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} name: Check status: in_progress - conclusion: + conclusion: neutral + output: >- + {"summary": "Waiting for deploy to finish"} From 89d9e656db7b029691aedc7f2457f2e3ee1e56af Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 17:38:08 -0400 Subject: [PATCH 132/174] Re-add failing link examples to test formatting This reverts commit 5fcc9fd97b8d7f0d7395b58be3889a018b346f22. --- content/blog/2020-08-27-august-20-community-gems.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/content/blog/2020-08-27-august-20-community-gems.md b/content/blog/2020-08-27-august-20-community-gems.md index f785f28f05..76c1198508 100644 --- a/content/blog/2020-08-27-august-20-community-gems.md +++ b/content/blog/2020-08-27-august-20-community-gems.md @@ -21,6 +21,11 @@ tags: - Pipeline --- +[Nonexistent site](https://www.notarealsite.co.uk) +[404](https://www.google.com/thisisnotarealpage) [relative pass](/doc) +[relative 404](/notdocsnotanything) +[filtered](https://github.com/iterative/dvc/releases/download/) + Here are some of our top Q&A's from around the community. With the launch of [CML](https://cml.dev) earlier in the month, we've got some new ground to cover! From bae960d36c2777010ab30643bcfa2a10de34a7fb Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 4 Sep 2020 23:50:53 -0400 Subject: [PATCH 133/174] Remove test examples to get an example of a passing deploy run This reverts commit 89d9e656db7b029691aedc7f2457f2e3ee1e56af. --- content/blog/2020-08-27-august-20-community-gems.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/content/blog/2020-08-27-august-20-community-gems.md b/content/blog/2020-08-27-august-20-community-gems.md index 76c1198508..f785f28f05 100644 --- a/content/blog/2020-08-27-august-20-community-gems.md +++ b/content/blog/2020-08-27-august-20-community-gems.md @@ -21,11 +21,6 @@ tags: - Pipeline --- -[Nonexistent site](https://www.notarealsite.co.uk) -[404](https://www.google.com/thisisnotarealpage) [relative pass](/doc) -[relative 404](/notdocsnotanything) -[filtered](https://github.com/iterative/dvc/releases/download/) - Here are some of our top Q&A's from around the community. With the launch of [CML](https://cml.dev) earlier in the month, we've got some new ground to cover! From 7cdbffb5cad919c6151c12261a5ee3d45e292ce9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 5 Sep 2020 00:46:58 -0400 Subject: [PATCH 134/174] Add full check deployment run for testing again --- .github/workflows/link-check-all.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 6d15a12769..28aa3ca87a 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,5 +1,6 @@ name: Link Check All on: + deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' From b34ad835a5b57dacaa395d5f1e38461f75e72519 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sat, 5 Sep 2020 01:02:34 -0400 Subject: [PATCH 135/174] Remove test deployment trigger --- .github/workflows/link-check-all.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 28aa3ca87a..6d15a12769 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,6 +1,5 @@ name: Link Check All on: - deployment: workflow_dispatch: schedule: - cron: '0 0 * * *' From fb25640dfdaca10f638e7a51d48a045676b3f941 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 8 Sep 2020 15:39:55 -0400 Subject: [PATCH 136/174] Update repo-link-check and use new YML config syntax Easier to write than JSON, more featureful and ubiquitous than text lines (like comments) --- config/link-check/config.json | 18 ------------------ config/link-check/config.yml | 12 ++++++++++++ config/link-check/excluded-files.txt | 4 ---- config/link-check/excluded-files.yml | 4 ++++ config/link-check/excluded-links.txt | 17 ----------------- config/link-check/excluded-links.yml | 17 +++++++++++++++++ package.json | 10 +++++----- yarn.lock | 11 ++++++----- 8 files changed, 44 insertions(+), 49 deletions(-) delete mode 100644 config/link-check/config.json create mode 100644 config/link-check/config.yml delete mode 100644 config/link-check/excluded-files.txt create mode 100644 config/link-check/excluded-files.yml delete mode 100644 config/link-check/excluded-links.txt create mode 100644 config/link-check/excluded-links.yml diff --git a/config/link-check/config.json b/config/link-check/config.json deleted file mode 100644 index 364234cc89..0000000000 --- a/config/link-check/config.json +++ /dev/null @@ -1,18 +0,0 @@ -{ - "rootURL": "https://dvc.org", - "fileIncludePatterns": [ - "{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}" - ], - "fileExcludePatternFiles": ["./config/link-check/excluded-files.txt"], - "linkExcludePatternFiles": ["./config/link-check/excluded-links.txt"], - "bottlenecks": { - "*.wikipedia.org": { - "minTime": 2000, - "maxConcurrent": 1 - }, - "*.github.com": { - "minTime": 1000, - "maxConcurrent": 1 - } - } -} diff --git a/config/link-check/config.yml b/config/link-check/config.yml new file mode 100644 index 0000000000..371551a52a --- /dev/null +++ b/config/link-check/config.yml @@ -0,0 +1,12 @@ +rootURL: https://dvc.org +fileIncludePatterns: '{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' +fileExcludePatternFiles: config/link-check/excluded-files.yml +linkExcludePatternFiles: config/link-check/excluded-links.yml +bottlenecks: + '*.wikipedia.org': + minTime: 2000 + maxConcurrent: 1 + + '*.github.com': + minTime: 1000 + maxConcurrent: 1 diff --git a/config/link-check/excluded-files.txt b/config/link-check/excluded-files.txt deleted file mode 100644 index e4161f4314..0000000000 --- a/config/link-check/excluded-files.txt +++ /dev/null @@ -1,4 +0,0 @@ -src/consts.js -**/*.test.js -src/server/**/* -.github/workflows/**/* diff --git a/config/link-check/excluded-files.yml b/config/link-check/excluded-files.yml new file mode 100644 index 0000000000..eb065074ae --- /dev/null +++ b/config/link-check/excluded-files.yml @@ -0,0 +1,4 @@ +- 'src/consts.js' +- '**/*.test.js' +- 'src/server/**/*' +- '.github/workflows/**/*' diff --git a/config/link-check/excluded-links.txt b/config/link-check/excluded-links.txt deleted file mode 100644 index 647db43627..0000000000 --- a/config/link-check/excluded-links.txt +++ /dev/null @@ -1,17 +0,0 @@ -http://localhost:8000** -http://millionsongdataset.com/pages/getting-dataset/#subset -https://marketplace.visualstudio.com/items?itemName=stkb.rewrap -https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml -https://remote.dvc.org/get-started -https://sweedom.us10.list-manage.com/subscribe/post?u=a08bf93caae4063c4e6a351f6&id=24c0ecc49a -https://www.meetup.com/San-Francisco-Machine-Learning-Meetup/events/264846847/ -https://www.reddit.com/r/MachineLearning/comments/bx0apm/d_how_do_you_manage_your_machine_learning/ -https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3 -**linkedin.com/in/** -link -/img/.gif -/uploads/images/2020-02-10/image.png -https://portal.aws.amazon.com/gp/aws/developer/registration/index.html -https://github.com/iterative/dvc/releases/download/ -https://www.kaggle.com/kurianbenoy/introduction-to-data-version-control-dvc -https://timheuer.com/blog/skipping-ci-github-actions-workflows/ diff --git a/config/link-check/excluded-links.yml b/config/link-check/excluded-links.yml new file mode 100644 index 0000000000..584c8672cd --- /dev/null +++ b/config/link-check/excluded-links.yml @@ -0,0 +1,17 @@ +- 'http://localhost:8000**' +- 'http://millionsongdataset.com/pages/getting-dataset/#subset' +- 'https://marketplace.visualstudio.com/items?itemName=stkb.rewrap' +- 'https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml' +- 'https://remote.dvc.org/get-started' +- 'https://sweedom.us10.list-manage.com/subscribe/post?u=a08bf93caae4063c4e6a351f6&id=24c0ecc49a' +- 'https://www.meetup.com/San-Francisco-Machine-Learning-Meetup/events/264846847/' +- 'https://www.reddit.com/r/MachineLearning/comments/bx0apm/d_how_do_you_manage_your_machine_learning/' +- 'https://www.amazon.com/DevOps-Handbook-World-Class-Reliability-Organizations-ebook/dp/B01M9ASFQ3' +- '**linkedin.com/in/**' +- 'link' +- '/img/.gif' +- '/uploads/images/2020-02-10/image.png' +- 'https://portal.aws.amazon.com/gp/aws/developer/registration/index.html' +- 'https://github.com/iterative/dvc/releases/download/' +- 'https://www.kaggle.com/kurianbenoy/introduction-to-data-version-control-dvc' +- 'https://timheuer.com/blog/skipping-ci-github-actions-workflows/' diff --git a/package.json b/package.json index 4002afd466..2cc437b0f8 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -c ./config/link-check/config.json -s filesystem -u", - "link-check-diff": "repo-link-check -c ./config/link-check/config.json", - "link-check-dev-server": "repo-link-check -c ./config/link-check/config.json -r http://localhost:3000", - "link-check-exclude": "repo-link-check -c ./config/link-check/config.json -s filesystem -u only" + "link-check": "repo-link-check -c config/link-check/config.yml -s filesystem -u", + "link-check-diff": "repo-link-check -c config/link-check/config.yml", + "link-check-dev-server": "repo-link-check -c config/link-check/config.yml -r http://localhost:3000", + "link-check-exclude": "repo-link-check -c config/link-check/config.yml -s filesystem -u only" }, "repository": { "type": "git", @@ -76,7 +76,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.4.4", + "repo-link-check": "^0.5.0", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index 3f0cdc4be4..b053ef8a6d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10266,7 +10266,7 @@ js-tokens@^3.0.2: resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b" integrity sha1-mGbfOVECEw449/mWvOtlRDIJwls= -js-yaml@^3.10.0, js-yaml@^3.11.0, js-yaml@^3.13.1: +js-yaml@^3.10.0, js-yaml@^3.11.0, js-yaml@^3.13.1, js-yaml@^3.14.0: version "3.14.0" resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.14.0.tgz#a7a34170f26a21bb162424d8adacb4113a69e482" integrity sha512-/4IbIeHcD9VMHFqDR/gQ7EdZdLimOvW2DdcxFjdyyZ9NsbS+ccrXqVWDtab/lRl5AlUqmpBx8EhPaWR+OtY17A== @@ -14407,13 +14407,14 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.4.4: - version "0.4.4" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.4.4.tgz#6b844e56b565d60c4209a5e18f9dfda79ae8936c" - integrity sha512-2VnOVi1Ffx+G5cGUBa0/URDd0CKYt28NAMqz/L7Abh90HXexInjKk0dvOtqAvazSn0LCwkTvevyOUKy8IGsLKg== +repo-link-check@^0.5.0: + version "0.5.0" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.5.0.tgz#e5626a1e0a6b672bb42939cd40235ef96983b5d6" + integrity sha512-lQuEUqJbNiUakpqN607dyTb0MntR+HcNt6hdqS3Fd8jK3B9YU6lwmumM6vMzPgaxxWm6FtpBzNrvOR2q9mT2VQ== dependencies: bottleneck "^2.19.5" fast-glob "^3.2.4" + js-yaml "^3.14.0" lodash "^4.17.20" micromatch "^4.0.2" minimist "^1.2.5" From 21e5efa6a9c7ed03409dcb36ba69aa23a7b90c8c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Tue, 8 Sep 2020 15:59:53 -0400 Subject: [PATCH 137/174] Add more detail to check init and report script failure on Check --- .github/workflows/link-check-all.yml | 2 +- .github/workflows/link-check-deploy-init.yml | 2 +- .github/workflows/link-check-deploy.yml | 22 +++++++++++++++++++- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 6d15a12769..d8914de9ba 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -17,7 +17,7 @@ jobs: uses: "iterative/link-check.action@master" with: source: "filesystem" - configFile: "./config/link-check/config.json" + configFile: "config/link-check/config.yml" reportUnusedPatterns: true output: >- ["consoleLog", "exitCode"] diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index 1e6918c495..67233a7640 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -10,7 +10,7 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} name: Check - status: in_progress + status: queued conclusion: neutral output: >- {"summary": "Waiting for deploy to finish"} diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 727b2d64ea..bf1e01e532 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -11,18 +11,38 @@ jobs: - uses: actions/checkout@v2 + - uses: LouisBrunner/checks-action@v0.1.0 + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Check + status: in_progress + conclusion: neutral + output: >- + {"summary": "Running master diff Link Check on ${{ github.event.deployment.payload.web_url }}"} + - name: Run the link check script id: check uses: "iterative/link-check.action@master" with: - configFile: "./config/link-check/config.json" + configFile: "config/link-check/config.yml" rootURL: "${{ github.event.deployment.payload.web_url }}" output: checkAction - uses: LouisBrunner/checks-action@v0.1.0 + if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} name: Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} + + - uses: LouisBrunner/checks-action@v0.1.0 + if: ${{ failure() }} + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Check + status: completed + conclusion: failure + output: >- + {"summary": "The Link Check script had an error!"} From 7ab4954a05680a2990f4f987b2ec554bef638951 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Wed, 9 Sep 2020 23:13:53 -0400 Subject: [PATCH 138/174] checkAction => checksAction --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index bf1e01e532..62973a144b 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -26,7 +26,7 @@ jobs: with: configFile: "config/link-check/config.yml" rootURL: "${{ github.event.deployment.payload.web_url }}" - output: checkAction + output: checksAction - uses: LouisBrunner/checks-action@v0.1.0 if: ${{ success() }} From 79f2bc96132d7e0c3800f4807555f924c6dd5c9f Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 10 Sep 2020 17:03:56 -0400 Subject: [PATCH 139/174] Use forked checks action for debug purposes --- .github/workflows/link-check-deploy-init.yml | 2 +- .github/workflows/link-check-deploy.yml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index 67233a7640..c836e757bf 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -6,7 +6,7 @@ jobs: name: Initialize runs-on: ubuntu-latest steps: - - uses: LouisBrunner/checks-action@v0.1.0 + - uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} name: Check diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 62973a144b..fa969deea1 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -11,7 +11,7 @@ jobs: - uses: actions/checkout@v2 - - uses: LouisBrunner/checks-action@v0.1.0 + - uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} name: Check @@ -28,7 +28,7 @@ jobs: rootURL: "${{ github.event.deployment.payload.web_url }}" output: checksAction - - uses: LouisBrunner/checks-action@v0.1.0 + - uses: rogermparent/checks-action@master if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} @@ -37,7 +37,7 @@ jobs: conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} - - uses: LouisBrunner/checks-action@v0.1.0 + - uses: rogermparent/checks-action@master if: ${{ failure() }} with: token: ${{ secrets.GITHUB_TOKEN }} From 95a2bd4ec9724da4e22ca790a6a1814865235cdf Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 10 Sep 2020 17:06:53 -0400 Subject: [PATCH 140/174] Remove conclusion on uncompleted Check and use YAML anchors for DRYing --- .github/workflows/link-check-deploy-init.yml | 1 - .github/workflows/link-check-deploy.yml | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml index c836e757bf..ac3f465944 100644 --- a/.github/workflows/link-check-deploy-init.yml +++ b/.github/workflows/link-check-deploy-init.yml @@ -11,6 +11,5 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} name: Check status: queued - conclusion: neutral output: >- {"summary": "Waiting for deploy to finish"} diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index fa969deea1..2bdf195a08 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -12,11 +12,10 @@ jobs: - uses: actions/checkout@v2 - uses: rogermparent/checks-action@master - with: + with: &checksWith token: ${{ secrets.GITHUB_TOKEN }} name: Check status: in_progress - conclusion: neutral output: >- {"summary": "Running master diff Link Check on ${{ github.event.deployment.payload.web_url }}"} @@ -31,8 +30,7 @@ jobs: - uses: rogermparent/checks-action@master if: ${{ success() }} with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Check + <<: *checksWith status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} @@ -40,8 +38,6 @@ jobs: - uses: rogermparent/checks-action@master if: ${{ failure() }} with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Check status: completed conclusion: failure output: >- From c4542824c33396bb0745e18cdec43a8f88b23dde Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 10 Sep 2020 17:16:06 -0400 Subject: [PATCH 141/174] Remove anchors because GHA doesn't support them --- .github/workflows/link-check-deploy.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 2bdf195a08..a43013941f 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/checkout@v2 - uses: rogermparent/checks-action@master - with: &checksWith + with: token: ${{ secrets.GITHUB_TOKEN }} name: Check status: in_progress @@ -30,7 +30,8 @@ jobs: - uses: rogermparent/checks-action@master if: ${{ success() }} with: - <<: *checksWith + token: ${{ secrets.GITHUB_TOKEN }} + name: Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} @@ -38,6 +39,8 @@ jobs: - uses: rogermparent/checks-action@master if: ${{ failure() }} with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Check status: completed conclusion: failure output: >- From 2e9f07bc546d011bc265e97b00098d1d17605bb0 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 10 Sep 2020 17:18:27 -0400 Subject: [PATCH 142/174] Remove init to test if 1.0 works on deploy_status --- .github/workflows/link-check-deploy-init.yml | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 .github/workflows/link-check-deploy-init.yml diff --git a/.github/workflows/link-check-deploy-init.yml b/.github/workflows/link-check-deploy-init.yml deleted file mode 100644 index ac3f465944..0000000000 --- a/.github/workflows/link-check-deploy-init.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: Link Check Deploy -on: deployment - -jobs: - run: - name: Initialize - runs-on: ubuntu-latest - steps: - - uses: rogermparent/checks-action@master - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Check - status: queued - output: >- - {"summary": "Waiting for deploy to finish"} From b5cec57dd4ba3a1fa5c43b44bdad0f3ce418458a Mon Sep 17 00:00:00 2001 From: rogermparent Date: Thu, 10 Sep 2020 17:44:39 -0400 Subject: [PATCH 143/174] Attempt to fix caching issue caught during dev --- src/gatsby/models/community/index.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gatsby/models/community/index.js b/src/gatsby/models/community/index.js index 1a40c027f1..9d1524e8b3 100644 --- a/src/gatsby/models/community/index.js +++ b/src/gatsby/models/community/index.js @@ -2,6 +2,8 @@ const moment = require('moment') const { getExpirationFields } = require('../../../utils/shared/expiration.js') const { childNodeCreator } = require('../../utils/models/nodes.js') +const restIDSeed = `DVCCommunityRest` + function expiredNodesLog(typeName, nodes) { if (nodes.length > 0) { return `${nodes.length} ${typeName}:\n${nodes @@ -30,6 +32,9 @@ const expirableFields = { } module.exports = { + async sourceNodes({ actions: { touchNode }, createNodeId }) { + touchNode({ nodeId: createNodeId(restIDSeed) }) + }, async createSchemaCustomization({ actions: { createTypes }, schema: { buildObjectType } @@ -127,7 +132,7 @@ module.exports = { data before updating all Community components. */ const restPromise = createChildNode({ - id: createNodeId(`DVCCommunityRest`), + id: createNodeId(restIDSeed), content: rest, internal: { type: 'CommunityRest', From 5e7387d30d9b23ec90c6ac5470210f096f23fae3 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 14:16:15 -0400 Subject: [PATCH 144/174] add initialization to deployment_status/action:created --- .github/workflows/link-check-deploy.yml | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index a43013941f..31783d6dcc 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -2,8 +2,21 @@ name: Link Check Deploy on: deployment_status jobs: - run: - name: Check + init: + name: Initialize Deploy Check + runs-on: ubuntu-latest + if: github.event.action == 'created' + + steps: + + - uses: rogermparent/checks-action@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Deploy Check + status: queued + + check: + name: Deploy Check runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' @@ -14,7 +27,7 @@ jobs: - uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} - name: Check + name: Deploy Check status: in_progress output: >- {"summary": "Running master diff Link Check on ${{ github.event.deployment.payload.web_url }}"} @@ -31,7 +44,7 @@ jobs: if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} - name: Check + name: Deploy Check status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} @@ -40,7 +53,7 @@ jobs: if: ${{ failure() }} with: token: ${{ secrets.GITHUB_TOKEN }} - name: Check + name: Deploy Check status: completed conclusion: failure output: >- From 40cd2eb569069dc43d62ad73c557b635b12ec9bd Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 14:29:24 -0400 Subject: [PATCH 145/174] Try initializing on pull_request --- .github/workflows/link-check-deploy.yml | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 31783d6dcc..dc32354beb 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,24 +1,27 @@ name: Link Check Deploy -on: deployment_status +on: + deployment_status: + pull_request: + types: [opened, edited] jobs: - init: - name: Initialize Deploy Check + initialize: + name: Initialize Link Check Deploy runs-on: ubuntu-latest - if: github.event.action == 'created' + if: ${{ github.event_name == 'pull_request' }} steps: - uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Check + name: Link Check Deploy status: queued check: - name: Deploy Check + name: Link Check Deploy runs-on: ubuntu-latest - if: github.event.deployment_status.state == 'success' + if: ${{ github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' }} steps: @@ -27,12 +30,12 @@ jobs: - uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Check + name: Link Check Deploy status: in_progress output: >- {"summary": "Running master diff Link Check on ${{ github.event.deployment.payload.web_url }}"} - - name: Run the link check script + - name: Run Link Check id: check uses: "iterative/link-check.action@master" with: @@ -44,7 +47,7 @@ jobs: if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Check + name: Link Check Deploy status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} @@ -53,7 +56,7 @@ jobs: if: ${{ failure() }} with: token: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Check + name: Link Check Deploy status: completed conclusion: failure output: >- From 0b24f1be9133bc657dbdd36c2fd7b0b4d0a12cef Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 14:34:31 -0400 Subject: [PATCH 146/174] Roll in deployment init in same workflow file --- .github/workflows/link-check-deploy.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index dc32354beb..2e3cd3b1f5 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,14 +1,13 @@ name: Link Check Deploy on: + deployment: deployment_status: - pull_request: - types: [opened, edited] jobs: initialize: name: Initialize Link Check Deploy runs-on: ubuntu-latest - if: ${{ github.event_name == 'pull_request' }} + if: ${{ github.event_name == 'deployment' }} steps: From 1d91f0f77537bba3a730dc290fb0557be089e4a4 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 15:21:36 -0400 Subject: [PATCH 147/174] Run Prettier and remove brackets on ifs --- .github/workflows/link-check-all.yml | 19 +++-- .github/workflows/link-check-deploy.yml | 98 +++++++++++++------------ 2 files changed, 59 insertions(+), 58 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index d8914de9ba..ba51226915 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -10,14 +10,13 @@ jobs: runs-on: ubuntu-latest steps: + - uses: actions/checkout@v2 - - uses: actions/checkout@v2 - - - name: Run Link Check - uses: "iterative/link-check.action@master" - with: - source: "filesystem" - configFile: "config/link-check/config.yml" - reportUnusedPatterns: true - output: >- - ["consoleLog", "exitCode"] + - name: Run Link Check + uses: 'iterative/link-check.action@master' + with: + source: 'filesystem' + configFile: 'config/link-check/config.yml' + reportUnusedPatterns: true + output: >- + ["consoleLog", "exitCode"] diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 2e3cd3b1f5..bc41fddf44 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,62 +1,64 @@ name: Link Check Deploy on: - deployment: - deployment_status: + - deployment + - deployment_status + +defaults: + runs-on: ubuntu-latest jobs: initialize: name: Initialize Link Check Deploy - runs-on: ubuntu-latest - if: ${{ github.event_name == 'deployment' }} + if: github.event_name == 'deployment' steps: - - - uses: rogermparent/checks-action@master - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: queued + - uses: rogermparent/checks-action@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: queued check: name: Link Check Deploy - runs-on: ubuntu-latest - if: ${{ github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' }} + if: + github.event_name == 'deployment_status' && + github.event.deployment_status.state == 'success' steps: + - uses: actions/checkout@v2 + + - uses: rogermparent/checks-action@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: in_progress + output: >- + {"summary": "Running master diff Link Check on ${{ + github.event.deployment.payload.web_url }}"} + + - name: Run Link Check + id: check + uses: 'iterative/link-check.action@master' + with: + configFile: 'config/link-check/config.yml' + rootURL: '${{ github.event.deployment.payload.web_url }}' + output: checksAction + + - uses: rogermparent/checks-action@master + if: ${{ success() }} + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: completed + conclusion: ${{ steps.check.outputs.conclusion }} + output: ${{ steps.check.outputs.output }} - - uses: actions/checkout@v2 - - - uses: rogermparent/checks-action@master - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: in_progress - output: >- - {"summary": "Running master diff Link Check on ${{ github.event.deployment.payload.web_url }}"} - - - name: Run Link Check - id: check - uses: "iterative/link-check.action@master" - with: - configFile: "config/link-check/config.yml" - rootURL: "${{ github.event.deployment.payload.web_url }}" - output: checksAction - - - uses: rogermparent/checks-action@master - if: ${{ success() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: completed - conclusion: ${{ steps.check.outputs.conclusion }} - output: ${{ steps.check.outputs.output }} - - - uses: rogermparent/checks-action@master - if: ${{ failure() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: completed - conclusion: failure - output: >- - {"summary": "The Link Check script had an error!"} + - uses: rogermparent/checks-action@master + if: ${{ failure() }} + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: completed + conclusion: failure + output: >- + {"summary": "The Link Check script had an error!"} From 45dde5e4d282ad7078980b15b86e601ae40d692e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 15:28:17 -0400 Subject: [PATCH 148/174] Remove defaults --- .github/workflows/link-check-deploy.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index bc41fddf44..02eb9e8fef 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -3,9 +3,6 @@ on: - deployment - deployment_status -defaults: - runs-on: ubuntu-latest - jobs: initialize: name: Initialize Link Check Deploy @@ -20,6 +17,7 @@ jobs: check: name: Link Check Deploy + runs-on: ubuntu-latest if: github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' From 117ea66f4318579d4a7f1e92d3d652e13ba7353b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 15:30:41 -0400 Subject: [PATCH 149/174] Re-add runs-on to init step (oops) --- .github/workflows/link-check-deploy.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 02eb9e8fef..1d40608fb1 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -6,6 +6,7 @@ on: jobs: initialize: name: Initialize Link Check Deploy + runs-on: ubuntu-latest if: github.event_name == 'deployment' steps: From 80bac85f5c73c04ba78651465b9e47c385175143 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 15:34:39 -0400 Subject: [PATCH 150/174] Try a no-checks variant that includes deployment as a dummy trigger --- .github/workflows/link-check-deploy.yml | 41 +------------------------ 1 file changed, 1 insertion(+), 40 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 1d40608fb1..a5161e7097 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -4,18 +4,6 @@ on: - deployment_status jobs: - initialize: - name: Initialize Link Check Deploy - runs-on: ubuntu-latest - if: github.event_name == 'deployment' - - steps: - - uses: rogermparent/checks-action@master - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: queued - check: name: Link Check Deploy runs-on: ubuntu-latest @@ -26,38 +14,11 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: rogermparent/checks-action@master - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: in_progress - output: >- - {"summary": "Running master diff Link Check on ${{ - github.event.deployment.payload.web_url }}"} - - name: Run Link Check id: check uses: 'iterative/link-check.action@master' with: configFile: 'config/link-check/config.yml' rootURL: '${{ github.event.deployment.payload.web_url }}' - output: checksAction - - - uses: rogermparent/checks-action@master - if: ${{ success() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: completed - conclusion: ${{ steps.check.outputs.conclusion }} - output: ${{ steps.check.outputs.output }} - - - uses: rogermparent/checks-action@master - if: ${{ failure() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: completed - conclusion: failure output: >- - {"summary": "The Link Check script had an error!"} + ["consoleLog", "exitCode"] From 0991615546f4d98cec2a411d111edd68b4583ee1 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 15:42:03 -0400 Subject: [PATCH 151/174] Revert "Try a no-checks variant that includes deployment as a dummy trigger" This reverts commit 80bac85f5c73c04ba78651465b9e47c385175143. --- .github/workflows/link-check-deploy.yml | 41 ++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index a5161e7097..1d40608fb1 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -4,6 +4,18 @@ on: - deployment_status jobs: + initialize: + name: Initialize Link Check Deploy + runs-on: ubuntu-latest + if: github.event_name == 'deployment' + + steps: + - uses: rogermparent/checks-action@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: queued + check: name: Link Check Deploy runs-on: ubuntu-latest @@ -14,11 +26,38 @@ jobs: steps: - uses: actions/checkout@v2 + - uses: rogermparent/checks-action@master + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: in_progress + output: >- + {"summary": "Running master diff Link Check on ${{ + github.event.deployment.payload.web_url }}"} + - name: Run Link Check id: check uses: 'iterative/link-check.action@master' with: configFile: 'config/link-check/config.yml' rootURL: '${{ github.event.deployment.payload.web_url }}' + output: checksAction + + - uses: rogermparent/checks-action@master + if: ${{ success() }} + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: completed + conclusion: ${{ steps.check.outputs.conclusion }} + output: ${{ steps.check.outputs.output }} + + - uses: rogermparent/checks-action@master + if: ${{ failure() }} + with: + token: ${{ secrets.GITHUB_TOKEN }} + name: Link Check Deploy + status: completed + conclusion: failure output: >- - ["consoleLog", "exitCode"] + {"summary": "The Link Check script had an error!"} From dddca0fb2df72b39c8cac4ad5c2126914f99edfb Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 15:50:27 -0400 Subject: [PATCH 152/174] Try check_suite as initializer --- .github/workflows/link-check-deploy.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 1d40608fb1..916853c6e1 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,13 +1,16 @@ name: Link Check Deploy on: - - deployment - - deployment_status + deployment_status: + check_suite: + types: + - requested + - rerequested jobs: initialize: name: Initialize Link Check Deploy runs-on: ubuntu-latest - if: github.event_name == 'deployment' + if: github.event_name == 'check_suite' steps: - uses: rogermparent/checks-action@master From b406284b12c99ddfa48e64ad7ec3644f469a70cc Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 16:14:02 -0400 Subject: [PATCH 153/174] Use updated checks flow for updates --- .github/workflows/link-check-deploy.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 916853c6e1..f27212e454 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -12,8 +12,12 @@ jobs: runs-on: ubuntu-latest if: github.event_name == 'check_suite' + outputs: + check_id: ${{ steps.check.outputs.check_id }} + steps: - - uses: rogermparent/checks-action@master + - id: check + uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} name: Link Check Deploy @@ -21,6 +25,7 @@ jobs: check: name: Link Check Deploy + needs: initialize runs-on: ubuntu-latest if: github.event_name == 'deployment_status' && @@ -32,7 +37,7 @@ jobs: - uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + check_id: ${{ needs.initialize.outputs.check_id }} status: in_progress output: >- {"summary": "Running master diff Link Check on ${{ @@ -50,7 +55,7 @@ jobs: if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + check_id: ${{ needs.initialize.outputs.check_id }} status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} @@ -59,7 +64,7 @@ jobs: if: ${{ failure() }} with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + check_id: ${{ needs.initialize.outputs.check_id }} status: completed conclusion: failure output: >- From 4a420a916efd2a4ce3a7c28bdc0209ca88c6c027 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 16:20:41 -0400 Subject: [PATCH 154/174] Go back to deployment init trigger --- .github/workflows/link-check-deploy.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index f27212e454..a341f0f738 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,16 +1,13 @@ name: Link Check Deploy on: + deployment: deployment_status: - check_suite: - types: - - requested - - rerequested jobs: initialize: name: Initialize Link Check Deploy runs-on: ubuntu-latest - if: github.event_name == 'check_suite' + if: github.event_name == 'deployment' outputs: check_id: ${{ steps.check.outputs.check_id }} From d73622c81174778530a4ccb6340327ded9de52cc Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 16:21:37 -0400 Subject: [PATCH 155/174] Remove names on steps --- .github/workflows/link-check-deploy.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index a341f0f738..c911875b05 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -5,7 +5,6 @@ on: jobs: initialize: - name: Initialize Link Check Deploy runs-on: ubuntu-latest if: github.event_name == 'deployment' @@ -21,7 +20,6 @@ jobs: status: queued check: - name: Link Check Deploy needs: initialize runs-on: ubuntu-latest if: From 495ffa53f112f4804fea52e167aca9320ba82fe9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 16:31:11 -0400 Subject: [PATCH 156/174] Unbreak deployment if statement --- .github/workflows/link-check-deploy.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index c911875b05..b7244a587d 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -23,8 +23,7 @@ jobs: needs: initialize runs-on: ubuntu-latest if: - github.event_name == 'deployment_status' && - github.event.deployment_status.state == 'success' + github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 From a59f70d06681fd2cc60de3588a2aa7dfbfdfe7ce Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 16:51:46 -0400 Subject: [PATCH 157/174] Re-wrap deploy if in interpolation --- .github/workflows/link-check-deploy.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index b7244a587d..7c57076af8 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,7 +1,7 @@ name: Link Check Deploy on: - deployment: - deployment_status: + - deployment + - deployment_status jobs: initialize: @@ -23,7 +23,7 @@ jobs: needs: initialize runs-on: ubuntu-latest if: - github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' + ${{ github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' }} steps: - uses: actions/checkout@v2 From 12277b7cf0682d406de3ba384de9b419d110e138 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 17:10:03 -0400 Subject: [PATCH 158/174] Remove event_name conditional on check --- .github/workflows/link-check-deploy.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 7c57076af8..143134261d 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -22,8 +22,7 @@ jobs: check: needs: initialize runs-on: ubuntu-latest - if: - ${{ github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success' }} + if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 From bb4d22a323d7324b5e0cd420f565c860edc65016 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 17:34:59 -0400 Subject: [PATCH 159/174] remove if conditional for testing --- .github/workflows/link-check-deploy.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 143134261d..c32a0d6838 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -22,7 +22,6 @@ jobs: check: needs: initialize runs-on: ubuntu-latest - if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 From f1854dfc799397630f0405a39f51bef3768d8c1f Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 18:48:44 -0400 Subject: [PATCH 160/174] Try deployment_status only approach --- .github/workflows/link-check-deploy.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index c32a0d6838..e4d35d5fdd 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,12 +1,9 @@ name: Link Check Deploy -on: - - deployment - - deployment_status +on: deployment_status jobs: initialize: runs-on: ubuntu-latest - if: github.event_name == 'deployment' outputs: check_id: ${{ steps.check.outputs.check_id }} @@ -22,6 +19,8 @@ jobs: check: needs: initialize runs-on: ubuntu-latest + if: github.event.deployment_status.state == 'success' + continue-on-error: true steps: - uses: actions/checkout@v2 From 3acc1de410f9101ea0f7873a881404d2f42b2a3c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 18:52:23 -0400 Subject: [PATCH 161/174] Add example relative link to test --- content/blog/2020-09-09-september-20-dvc-heartbeat.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/blog/2020-09-09-september-20-dvc-heartbeat.md b/content/blog/2020-09-09-september-20-dvc-heartbeat.md index 4db5e4def1..1835cf3df2 100644 --- a/content/blog/2020-09-09-september-20-dvc-heartbeat.md +++ b/content/blog/2020-09-09-september-20-dvc-heartbeat.md @@ -25,6 +25,8 @@ tags: ### Dmitry on Software Engineering Daily +[test link](/doc) + Our CEO Dmitry Petrov was interviewed on the much-beloved Software Engineering Daily podcast! Host [Jeff Meyerson](https://twitter.com/the_prion) kicked off the discussion: From 3b61e0ee18ce49518e1db177c4ae0528ec6f445e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 19:56:09 -0400 Subject: [PATCH 162/174] Go back to deployment+deployment_status method --- .github/workflows/link-check-deploy.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index e4d35d5fdd..7cbb0d2935 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,9 +1,12 @@ name: Link Check Deploy -on: deployment_status +on: + - deployment + - deployment_status jobs: initialize: runs-on: ubuntu-latest + if: github.event_name == 'deployment' outputs: check_id: ${{ steps.check.outputs.check_id }} @@ -19,8 +22,7 @@ jobs: check: needs: initialize runs-on: ubuntu-latest - if: github.event.deployment_status.state == 'success' - continue-on-error: true + if: github.event_name == 'deployment_status' steps: - uses: actions/checkout@v2 From 02afc5c3cceced48f1d901a7a59f08a0b41ff6bd Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 20:14:05 -0400 Subject: [PATCH 163/174] Turn initialize into a conditional step --- .github/workflows/link-check-deploy.yml | 32 ++++++------------------- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 7cbb0d2935..e247ee0463 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -4,37 +4,19 @@ on: - deployment_status jobs: - initialize: - runs-on: ubuntu-latest - if: github.event_name == 'deployment' - - outputs: - check_id: ${{ steps.check.outputs.check_id }} - - steps: - - id: check - uses: rogermparent/checks-action@master - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy - status: queued - check: - needs: initialize runs-on: ubuntu-latest - if: github.event_name == 'deployment_status' steps: - uses: actions/checkout@v2 - - uses: rogermparent/checks-action@master + - id: init + if: github.event_name == 'deployment' + uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ needs.initialize.outputs.check_id }} - status: in_progress - output: >- - {"summary": "Running master diff Link Check on ${{ - github.event.deployment.payload.web_url }}"} + name: Link Check Deploy + status: queued - name: Run Link Check id: check @@ -48,7 +30,7 @@ jobs: if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ needs.initialize.outputs.check_id }} + check_id: ${{ steps.init.outputs.check_id }} status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} @@ -57,7 +39,7 @@ jobs: if: ${{ failure() }} with: token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ needs.initialize.outputs.check_id }} + check_id: ${{ steps.init.outputs.check_id }} status: completed conclusion: failure output: >- From fb02ef1c3cc7a7acb8695208c87cb15f6d01362c Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 11 Sep 2020 20:48:23 -0400 Subject: [PATCH 164/174] Go back to deployment_status only --- .github/workflows/link-check-deploy.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index e247ee0463..6ab7e3b7ba 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,17 +1,16 @@ name: Link Check Deploy on: - - deployment - deployment_status jobs: check: runs-on: ubuntu-latest + if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 - id: init - if: github.event_name == 'deployment' uses: rogermparent/checks-action@master with: token: ${{ secrets.GITHUB_TOKEN }} From 0351915fa2c43975b295e207bac4f113b70dc815 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 13 Sep 2020 21:01:12 -0400 Subject: [PATCH 165/174] Add deployment and deployment_status triggers to deploy check for testing --- .github/workflows/link-check-deploy.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 6ab7e3b7ba..bb05a1781f 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,5 +1,6 @@ name: Link Check Deploy on: + - deployment - deployment_status jobs: From 870e1ab7a4f6b1ad89df6d6b0941e555122d41d8 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 13 Sep 2020 22:11:35 -0400 Subject: [PATCH 166/174] Remove conditional to see if shas are different on different triggers --- .github/workflows/link-check-deploy.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index bb05a1781f..a82f9bb7ec 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -6,7 +6,6 @@ on: jobs: check: runs-on: ubuntu-latest - if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 From f750f1db8571f169c6fdff30077514f43aeab15e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Sun, 13 Sep 2020 22:33:13 -0400 Subject: [PATCH 167/174] Re-add conditional and do one more try for deployment_status only --- .github/workflows/link-check-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index a82f9bb7ec..6ab7e3b7ba 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,11 +1,11 @@ name: Link Check Deploy on: - - deployment - deployment_status jobs: check: runs-on: ubuntu-latest + if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 From 99d00482a327c9c128059b5dbf57ee69b3b68b85 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 14 Sep 2020 14:42:10 -0400 Subject: [PATCH 168/174] Rename items and try pull_request init trigger Seems there's no way around needing the deployment trigger, even if the job is skipped on deployment. The prefix can't be removed, but "Run" and "Report" are the most evocative names I can think of for the suffixes --- .github/workflows/link-check-deploy.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 6ab7e3b7ba..b58e2039b9 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,20 +1,22 @@ name: Link Check Deploy on: + - pull_request - deployment_status jobs: - check: + run: + name: Run runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' steps: - uses: actions/checkout@v2 - - id: init - uses: rogermparent/checks-action@master + - id: build_check + uses: LouisBrunner/checks-action@v1.0.0 with: token: ${{ secrets.GITHUB_TOKEN }} - name: Link Check Deploy + name: Report status: queued - name: Run Link Check @@ -25,20 +27,20 @@ jobs: rootURL: '${{ github.event.deployment.payload.web_url }}' output: checksAction - - uses: rogermparent/checks-action@master + - uses: LouisBrunner/checks-action@v1.0.0 if: ${{ success() }} with: token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ steps.init.outputs.check_id }} + check_id: ${{ steps.build_check.outputs.check_id }} status: completed conclusion: ${{ steps.check.outputs.conclusion }} output: ${{ steps.check.outputs.output }} - - uses: rogermparent/checks-action@master + - uses: LouisBrunner/checks-action@v1.0.0 if: ${{ failure() }} with: token: ${{ secrets.GITHUB_TOKEN }} - check_id: ${{ steps.init.outputs.check_id }} + check_id: ${{ steps.build_check.outputs.check_id }} status: completed conclusion: failure output: >- From f0fc71d797b4a8fccb2853028db97eec3219e754 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 18 Sep 2020 13:53:51 -0400 Subject: [PATCH 169/174] Update repo-link-check and the consumer config to match --- .github/workflows/link-check-all.yml | 5 +---- .github/workflows/link-check-deploy.yml | 1 + config/link-check/config.yml | 8 ++++---- package.json | 8 ++++---- yarn.lock | 15 ++++++++++----- 5 files changed, 20 insertions(+), 17 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index ba51226915..620c53ea3c 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -15,8 +15,5 @@ jobs: - name: Run Link Check uses: 'iterative/link-check.action@master' with: - source: 'filesystem' configFile: 'config/link-check/config.yml' - reportUnusedPatterns: true - output: >- - ["consoleLog", "exitCode"] + output: consoleLog diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index b58e2039b9..8a4c5feb59 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -23,6 +23,7 @@ jobs: id: check uses: 'iterative/link-check.action@master' with: + diff: true configFile: 'config/link-check/config.yml' rootURL: '${{ github.event.deployment.payload.web_url }}' output: checksAction diff --git a/config/link-check/config.yml b/config/link-check/config.yml index 371551a52a..8fa1f6072d 100644 --- a/config/link-check/config.yml +++ b/config/link-check/config.yml @@ -1,8 +1,8 @@ rootURL: https://dvc.org -fileIncludePatterns: '{.github,content,src}/**/*.{css,js,jsx,md,tsx,ts,json}' -fileExcludePatternFiles: config/link-check/excluded-files.yml -linkExcludePatternFiles: config/link-check/excluded-links.yml -bottlenecks: +fileIncludePatterns: '{.github,content,src}/**/*!(.test).{css,js,jsx,md,tsx,ts,json}' +fileExcludePatternFile: config/link-check/excluded-files.yml +linkExcludePatternFile: config/link-check/excluded-links.yml +linkOptions: '*.wikipedia.org': minTime: 2000 maxConcurrent: 1 diff --git a/package.json b/package.json index 2cc437b0f8..ae5fbdd7fa 100644 --- a/package.json +++ b/package.json @@ -16,10 +16,10 @@ "format": "prettier --write", "lint-ts": "tsc --noEmit --skipLibCheck && eslint --ext .json,.js,.ts,.tsx .", "lint-css": "stylelint \"src/**/*.css\"", - "link-check": "repo-link-check -c config/link-check/config.yml -s filesystem -u", - "link-check-diff": "repo-link-check -c config/link-check/config.yml", + "link-check": "repo-link-check -c config/link-check/config.yml", + "link-check-diff": "repo-link-check -c config/link-check/config.yml -d", "link-check-dev-server": "repo-link-check -c config/link-check/config.yml -r http://localhost:3000", - "link-check-exclude": "repo-link-check -c config/link-check/config.yml -s filesystem -u only" + "link-check-exclude": "repo-link-check -c config/link-check/config.yml --unused-patterns-only" }, "repository": { "type": "git", @@ -76,7 +76,7 @@ "react-slick": "^0.25.2", "react-use": "^14.0.0", "rehype-react": "^5.0.1", - "repo-link-check": "^0.5.0", + "repo-link-check": "^0.6.0", "reset-css": "^5.0.1", "s3-client": "^4.4.2", "scroll": "^3.0.1", diff --git a/yarn.lock b/yarn.lock index b053ef8a6d..ef6b88fcf1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4329,6 +4329,11 @@ commander@^5.1.0: resolved "https://registry.yarnpkg.com/commander/-/commander-5.1.0.tgz#46abbd1652f8e059bddaef99bbdcb2ad9cf179ae" integrity sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg== +commander@^6.1.0: + version "6.1.0" + resolved "https://registry.yarnpkg.com/commander/-/commander-6.1.0.tgz#f8d722b78103141006b66f4c7ba1e97315ba75bc" + integrity sha512-wl7PNrYWd2y5mp1OK/LhTlv8Ff4kQJQRXXAvF+uU/TPNiVJUxZLRYGj/B0y/lPGAVcSbJqH2Za/cvHmrPMC8mA== + commander@~2.8.1: version "2.8.1" resolved "https://registry.yarnpkg.com/commander/-/commander-2.8.1.tgz#06be367febfda0c330aa1e2a072d3dc9762425d4" @@ -14407,17 +14412,17 @@ replace-ext@^1.0.0: resolved "https://registry.yarnpkg.com/replace-ext/-/replace-ext-1.0.1.tgz#2d6d996d04a15855d967443631dd5f77825b016a" integrity sha512-yD5BHCe7quCgBph4rMQ+0KkIRKwWCrHDOX1p1Gp6HwjPM5kVoCdKGNhN7ydqqsX6lJEnQDKZ/tFMiEdQ1dvPEw== -repo-link-check@^0.5.0: - version "0.5.0" - resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.5.0.tgz#e5626a1e0a6b672bb42939cd40235ef96983b5d6" - integrity sha512-lQuEUqJbNiUakpqN607dyTb0MntR+HcNt6hdqS3Fd8jK3B9YU6lwmumM6vMzPgaxxWm6FtpBzNrvOR2q9mT2VQ== +repo-link-check@^0.6.0: + version "0.6.0" + resolved "https://registry.yarnpkg.com/repo-link-check/-/repo-link-check-0.6.0.tgz#2ae67c44d725658beeaa3acf7d7de5e71175bbd1" + integrity sha512-7y05N70Nju6AQBWiYv/pXubn56dklS/Jfc5MDX4rED74DPMeqilKfBtjkV4kAg9cCfTwsnePPuuWgQGbN6cfRw== dependencies: bottleneck "^2.19.5" + commander "^6.1.0" fast-glob "^3.2.4" js-yaml "^3.14.0" lodash "^4.17.20" micromatch "^4.0.2" - minimist "^1.2.5" node-fetch "^2.6.0" request-promise-core@1.1.3: From 62fc548bb8c2f59eca0aa526ef88b4872b3879f9 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 18 Sep 2020 15:44:21 -0400 Subject: [PATCH 170/174] Add long names and a comment on deployment check --- .github/workflows/link-check-all.yml | 2 +- .github/workflows/link-check-deploy.yml | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 620c53ea3c..63fac93683 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -1,4 +1,4 @@ -name: Link Check All +name: Check all links in the repository on: workflow_dispatch: schedule: diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index 8a4c5feb59..de205186cb 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -1,11 +1,13 @@ -name: Link Check Deploy +name: Check new links against deployment +# This workflow "triggers" and skips on deployment because GitHub Actions / +# Checks refuses to show the check on deployment_status on: - - pull_request + - deployment - deployment_status jobs: run: - name: Run + name: Initialize runs-on: ubuntu-latest if: github.event.deployment_status.state == 'success' From 4bd74a449448696167186a5ac437c98f7836af51 Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 18 Sep 2020 16:05:54 -0400 Subject: [PATCH 171/174] Remove old dvc-github-actions-link-checker --- package.json | 1 - yarn.lock | 9 --------- 2 files changed, 10 deletions(-) diff --git a/package.json b/package.json index ae5fbdd7fa..fbed38b0f0 100644 --- a/package.json +++ b/package.json @@ -105,7 +105,6 @@ "babel-jest": "^26.0.1", "babel-plugin-transform-define": "^2.0.0", "babel-plugin-transform-object-assign": "^6.22.0", - "dvc-github-actions-link-checker": "^0.0.8", "eslint": "^6.8.0", "eslint-config-prettier": "^6.10.1", "eslint-plugin-json": "^2.1.1", diff --git a/yarn.lock b/yarn.lock index ef6b88fcf1..26a4ff2de8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5627,15 +5627,6 @@ duplexify@^3.4.2, duplexify@^3.6.0: readable-stream "^2.0.0" stream-shift "^1.0.0" -dvc-github-actions-link-checker@^0.0.8: - version "0.0.8" - resolved "https://registry.yarnpkg.com/dvc-github-actions-link-checker/-/dvc-github-actions-link-checker-0.0.8.tgz#47471bdcd5e178b5b3a807636596001a78f2a660" - integrity sha512-SZKGuKE2/RcYUrQRguipAMC3WN4hKvwL1EjJOW13NZx+2Ceo0CpFk/eW/tI1ZdlsKs1UVAgoXa22Rifjvrc6ag== - dependencies: - lodash "^4.17.19" - micromatch "^4.0.2" - node-fetch "^2.6.0" - ease-component@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/ease-component/-/ease-component-1.0.0.tgz#b375726db0b5b04595b77440396fec7daa5d77c9" From 084c2f27c31ad232dbe25711301d1d1844dfae2e Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 18 Sep 2020 16:08:34 -0400 Subject: [PATCH 172/174] Remove test link --- content/blog/2020-09-09-september-20-dvc-heartbeat.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/content/blog/2020-09-09-september-20-dvc-heartbeat.md b/content/blog/2020-09-09-september-20-dvc-heartbeat.md index 1835cf3df2..4db5e4def1 100644 --- a/content/blog/2020-09-09-september-20-dvc-heartbeat.md +++ b/content/blog/2020-09-09-september-20-dvc-heartbeat.md @@ -25,8 +25,6 @@ tags: ### Dmitry on Software Engineering Daily -[test link](/doc) - Our CEO Dmitry Petrov was interviewed on the much-beloved Software Engineering Daily podcast! Host [Jeff Meyerson](https://twitter.com/the_prion) kicked off the discussion: From c06f04a86bc210fded9f486afb43d6dbe449997f Mon Sep 17 00:00:00 2001 From: rogermparent Date: Fri, 18 Sep 2020 19:09:45 -0400 Subject: [PATCH 173/174] Pin to action tag v0.6 instead of master --- .github/workflows/link-check-all.yml | 2 +- .github/workflows/link-check-deploy.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 63fac93683..a92183e372 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v2 - name: Run Link Check - uses: 'iterative/link-check.action@master' + uses: 'iterative/link-check.action@v0.6' with: configFile: 'config/link-check/config.yml' output: consoleLog diff --git a/.github/workflows/link-check-deploy.yml b/.github/workflows/link-check-deploy.yml index de205186cb..b8c5095cbe 100644 --- a/.github/workflows/link-check-deploy.yml +++ b/.github/workflows/link-check-deploy.yml @@ -23,7 +23,7 @@ jobs: - name: Run Link Check id: check - uses: 'iterative/link-check.action@master' + uses: 'iterative/link-check.action@v0.6' with: diff: true configFile: 'config/link-check/config.yml' From 5bb490696229b24a6d23992f8d4bfb3bb55b371b Mon Sep 17 00:00:00 2001 From: rogermparent Date: Mon, 21 Sep 2020 22:11:12 -0400 Subject: [PATCH 174/174] Revert failed cache fix --- src/gatsby/models/community/index.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/gatsby/models/community/index.js b/src/gatsby/models/community/index.js index 9d1524e8b3..1a40c027f1 100644 --- a/src/gatsby/models/community/index.js +++ b/src/gatsby/models/community/index.js @@ -2,8 +2,6 @@ const moment = require('moment') const { getExpirationFields } = require('../../../utils/shared/expiration.js') const { childNodeCreator } = require('../../utils/models/nodes.js') -const restIDSeed = `DVCCommunityRest` - function expiredNodesLog(typeName, nodes) { if (nodes.length > 0) { return `${nodes.length} ${typeName}:\n${nodes @@ -32,9 +30,6 @@ const expirableFields = { } module.exports = { - async sourceNodes({ actions: { touchNode }, createNodeId }) { - touchNode({ nodeId: createNodeId(restIDSeed) }) - }, async createSchemaCustomization({ actions: { createTypes }, schema: { buildObjectType } @@ -132,7 +127,7 @@ module.exports = { data before updating all Community components. */ const restPromise = createChildNode({ - id: createNodeId(restIDSeed), + id: createNodeId(`DVCCommunityRest`), content: rest, internal: { type: 'CommunityRest',