Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: should not need index files in every parent sidebar element #738

Closed
jorgeorpinel opened this issue Oct 25, 2019 · 3 comments · Fixed by #891
Closed

docs: should not need index files in every parent sidebar element #738

jorgeorpinel opened this issue Oct 25, 2019 · 3 comments · Fixed by #891
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 25, 2019

From #727 (comment) with e.g. /doc/user-guide/contributing
Also related to #305

Using "source": false, on sidebar.json doesn't work unless it is the top level (e.g. get-started or understanding-dvc). In other levels, this breaks the engine.

Consider also automatically generating a list of H2s in child documents when no source field is used for a parent slug.

@jorgeorpinel jorgeorpinel added 🐛 type: bug Something isn't working. A: docs Area: user documentation (gatsby-theme-iterative) labels Oct 25, 2019
@jorgeorpinel jorgeorpinel self-assigned this Oct 25, 2019
@shcheklein

This comment has been minimized.

@shcheklein shcheklein added website: eng-doc DEPRECATED JS engine for /doc p1-important Active priorities to deal within next sprints labels Oct 25, 2019
@shcheklein shcheklein changed the title engine: should not need index.js files in every parent sidebar element should not need index files in every parent sidebar element Oct 25, 2019
@jorgeorpinel jorgeorpinel changed the title should not need index files in every parent sidebar element docs: should not need index files in every parent sidebar element Oct 26, 2019
@jorgeorpinel

This comment has been minimized.

@shcheklein

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants